Files
kernel/include/linux
Lai Jiangshan 8219fc48ad mm: node_states: introduce N_MEMORY
We have N_NORMAL_MEMORY for standing for the nodes that have normal memory
with zone_type <= ZONE_NORMAL.

And we have N_HIGH_MEMORY for standing for the nodes that have normal or
high memory.

But we don't have any word to stand for the nodes that have *any* memory.

And we have N_CPU but without N_MEMORY.

Current code reuse the N_HIGH_MEMORY for this purpose because any node
which has memory must have high memory or normal memory currently.

A)	But this reusing is bad for *readability*. Because the name
	N_HIGH_MEMORY just stands for high or normal:

A.example 1)
	mem_cgroup_nr_lru_pages():
		for_each_node_state(nid, N_HIGH_MEMORY)

	The user will be confused(why this function just counts for high or
	normal memory node? does it counts for ZONE_MOVABLE's lru pages?)
	until someone else tell them N_HIGH_MEMORY is reused to stand for
	nodes that have any memory.

A.cont) If we introduce N_MEMORY, we can reduce this confusing
	AND make the code more clearly:

A.example 2) mm/page_cgroup.c use N_HIGH_MEMORY twice:

	One is in page_cgroup_init(void):
		for_each_node_state(nid, N_HIGH_MEMORY) {

	It means if the node have memory, we will allocate page_cgroup map for
	the node. We should use N_MEMORY instead here to gaim more clearly.

	The second using is in alloc_page_cgroup():
		if (node_state(nid, N_HIGH_MEMORY))
			addr = vzalloc_node(size, nid);

	It means if the node has high or normal memory that can be allocated
	from kernel. We should keep N_HIGH_MEMORY here, and it will be better
	if the "any memory" semantic of N_HIGH_MEMORY is removed.

B)	This reusing is out-dated if we introduce MOVABLE-dedicated node.
	The MOVABLE-dedicated node should not appear in
	node_stats[N_HIGH_MEMORY] nor node_stats[N_NORMAL_MEMORY],
	because MOVABLE-dedicated node has no high or normal memory.

	In x86_64, N_HIGH_MEMORY=N_NORMAL_MEMORY, if a MOVABLE-dedicated node
	is in node_stats[N_HIGH_MEMORY], it is also means it is in
	node_stats[N_NORMAL_MEMORY], it causes SLUB wrong.

	The slub uses
		for_each_node_state(nid, N_NORMAL_MEMORY)
	and creates kmem_cache_node for MOVABLE-dedicated node and cause problem.

In one word, we need a N_MEMORY.  We just intrude it as an alias to
N_HIGH_MEMORY and fix all im-proper usages of N_HIGH_MEMORY in late
patches.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: Christoph Lameter <cl@linux.com>
Acked-by: Hillf Danton <dhillf@gmail.com>
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Cc: Lin Feng <linfeng@cn.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-12-12 17:38:32 -08:00
..
2012-11-30 12:37:36 +01:00
2012-12-07 23:14:11 +01:00
2012-10-08 13:50:20 +10:30
2012-09-19 19:08:46 -06:00
2012-09-20 14:31:45 +02:00
2012-09-17 15:00:38 -07:00
2012-11-15 00:34:23 +01:00
2012-11-28 11:54:40 +01:00
2012-10-16 18:49:15 -07:00
2012-11-28 21:49:02 -05:00
2012-11-28 21:49:02 -05:00
2012-12-11 17:22:26 -08:00
2012-11-21 10:07:48 +01:00
2012-10-29 21:31:32 +01:00
2012-11-23 12:23:40 +01:00
2012-10-06 03:04:56 +09:00
2012-11-21 15:09:26 -08:00
2012-09-26 13:52:36 -07:00
2012-10-10 01:15:44 -04:00
2012-12-06 11:56:43 -08:00
2012-12-11 17:22:27 -08:00
2012-10-10 20:00:55 +10:30
2012-12-11 17:22:27 -08:00
2012-12-12 17:38:32 -08:00
2012-10-17 15:53:02 -05:00
2012-10-10 22:41:05 -04:00
2012-11-28 13:16:47 -08:00
2012-11-16 14:33:04 -08:00
2012-10-06 03:05:01 +09:00
2012-09-27 12:45:28 +02:00
2012-10-11 20:02:04 -04:00
2012-10-07 00:40:54 -04:00
2012-10-27 15:38:29 -07:00
2012-10-09 16:22:55 +09:00
2012-10-22 15:16:06 -04:00
2012-10-09 16:22:32 +09:00
2012-10-22 16:58:28 -07:00
2012-11-15 17:20:58 -08:00