Al Viro 6319194ec5
Unify the primitives for file descriptor closing ...
Currently we have 3 primitives for removing an opened file from descriptor
table - pick_file(), __close_fd_get_file() and close_fd_get_file(). Their
calling conventions are rather odd and there's a code duplication for no
good reason. They can be unified -
1) have __range_close() cap max_fd in the very beginning; that way
we don't need separate way for pick_file() to report being past the end
of descriptor table.
2) make {__,}close_fd_get_file() return file (or NULL) directly, rather
than returning it via struct file ** argument. Don't bother with
(bogus) return value - nobody wants that -ENOENT.
3) make pick_file() return NULL on unopened descriptor - the only caller
that used to care about the distinction between descriptor past the end
of descriptor table and finding NULL in descriptor table doesn't give
a damn after (1).
4) lift ->files_lock out of pick_file()
That actually simplifies the callers, as well as the primitives themselves.
Code duplication is also gone...
Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org >
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2022-05-14 18:49:01 -04:00
2022-02-28 13:59:17 +00:00
2022-02-24 08:26:03 +01:00
2022-03-01 18:26:37 +01:00
2022-04-01 09:37:18 -07:00
2022-02-27 11:06:14 +00:00
2022-03-28 12:27:35 -07:00
2022-04-01 10:26:09 -07:00
2022-03-30 10:36:41 -07:00
2022-02-27 13:38:10 +00:00
2022-03-14 21:11:09 -07:00
2022-03-25 13:56:18 -07:00
2022-03-24 13:13:26 -07:00
2022-03-23 18:08:03 +01:00
2022-03-25 10:11:38 -07:00
2022-03-25 13:35:34 -07:00
2022-03-23 19:58:38 +01:00
2022-03-28 17:29:53 -07:00
2022-03-30 10:11:04 -07:00
2022-03-25 13:35:34 -07:00
2022-03-29 18:55:37 -07:00
2022-03-15 18:20:34 +01:00
2022-03-10 20:17:28 +01:00
2022-03-25 12:14:39 -07:00
2022-03-10 20:21:58 +01:00
2022-03-03 20:24:22 +01:00
2022-03-22 15:57:01 -07:00
2022-03-22 15:57:01 -07:00
2022-03-28 16:52:57 -04:00
2022-03-08 12:50:58 -06:00
2022-03-24 19:37:53 -07:00
2022-03-23 19:00:33 -07:00
2022-04-01 13:19:27 -04:00
2022-03-22 19:52:23 -06:00
2022-03-07 12:48:35 -07:00
2022-03-08 19:39:38 -07:00
2022-03-26 11:51:46 -07:00
2022-03-20 18:55:05 -07:00
2022-03-17 20:17:18 -07:00
2022-03-05 15:29:35 -08:00
2022-03-22 11:18:49 -07:00
2022-03-01 22:21:50 -05:00
2022-03-16 13:37:04 -04:00
2022-03-23 10:11:03 -07:00
2022-03-15 10:32:42 +01:00
2022-03-12 13:22:11 +01:00
2022-03-29 10:18:56 -07:00
2022-03-11 19:15:03 -08:00
2022-03-31 11:43:01 -07:00
2022-03-24 14:14:07 -07:00
2022-03-05 15:29:36 -08:00
2022-03-24 13:13:26 -07:00
2022-03-15 10:32:45 +01:00
2022-02-25 12:16:12 +01:00
2022-03-08 13:04:19 -06:00
2022-03-11 10:07:57 +00:00
2022-02-28 20:47:57 +01:00
2022-03-25 10:11:38 -07:00
2022-03-07 12:48:35 -07:00
2022-03-15 10:32:44 +01:00
2022-03-03 10:47:51 +12:00
2022-03-22 15:57:13 -07:00
2022-03-24 19:37:53 -07:00
2022-03-28 11:37:05 -07:00
2022-02-23 19:45:40 +01:00
2022-03-03 09:35:04 +05:30
2022-03-28 17:29:53 -07:00
2022-03-10 16:51:50 -06:00
2022-02-23 20:33:05 -08:00
2022-03-22 15:57:07 -07:00
2022-02-25 05:50:18 +10:00
2022-05-14 18:49:01 -04:00
2022-05-14 18:47:28 -04:00
2022-03-16 15:13:36 -07:00
2022-03-17 20:17:02 -07:00
2022-05-14 18:47:28 -04:00
2022-03-31 15:49:36 -07:00
2022-02-24 14:05:18 +01:00
2022-04-01 13:45:33 -04:00
2022-04-03 12:26:01 -07:00
2022-04-01 11:46:09 -07:00
2022-03-01 15:46:03 +01:00
2022-03-22 15:57:11 -07:00
2022-03-15 11:34:09 -06:00
2022-03-03 12:47:33 -05:00
2022-03-24 19:06:50 -07:00
2022-03-22 17:03:12 -07:00
2022-02-27 17:03:19 -08:00
2022-03-20 00:11:05 +01:00
2022-03-16 19:38:41 -07:00
2022-03-17 16:49:58 -07:00
2022-03-02 22:44:49 -08:00
2022-03-14 10:06:54 +00:00
2022-03-23 19:00:34 -07:00
2022-02-28 23:26:27 -08:00
2022-03-04 16:46:31 +01:00
2022-02-28 13:25:48 +01:00
2022-03-01 16:31:05 +02:00
2022-03-07 23:53:50 +01:00
2022-03-10 06:32:49 -07:00
2022-03-15 08:23:29 -04:00
2022-02-28 13:25:49 +01:00
2022-03-22 18:26:56 -07:00
2022-03-09 12:13:37 +00:00
2022-03-24 19:06:50 -07:00
2022-03-26 12:01:35 -07:00
2022-03-18 09:47:04 +01:00
2022-03-23 19:00:34 -07:00
2022-03-28 19:38:09 -07:00
2022-03-21 13:01:35 -04:00
2022-03-22 15:57:00 -07:00
2022-04-02 05:34:41 -04:00
2022-04-02 05:34:41 -04:00
2022-03-23 14:35:59 -07:00
2022-03-11 15:53:13 -08:00
2022-03-22 15:57:03 -07:00
2022-03-21 12:07:05 -07:00
2022-03-23 19:00:33 -07:00
2022-03-21 20:47:54 -07:00
2022-03-10 07:41:14 +01:00
2022-02-25 10:27:57 +01:00
2022-03-29 22:45:31 +02:00
2022-03-22 15:57:04 -07:00
2022-03-22 15:57:10 -07:00
2022-03-22 15:57:10 -07:00
2022-03-21 12:57:38 -04:00
2022-03-22 15:57:11 -07:00
2022-03-22 17:03:12 -07:00
2022-03-22 17:03:12 -07:00
2022-03-24 19:06:51 -07:00
2022-03-22 15:57:09 -07:00
2022-03-12 18:00:56 -07:00
2022-03-23 12:17:36 -07:00
2022-04-01 14:40:44 -04:00
2022-03-28 14:40:08 -07:00
2022-03-24 15:09:53 +01:00
2022-03-18 09:29:05 +00:00
2022-03-29 18:55:37 -07:00
2022-03-29 18:55:37 -07:00
2022-03-13 12:59:35 -04:00
2022-03-22 15:57:10 -07:00
2022-02-28 13:45:04 +02:00
2022-04-01 16:26:57 -07:00
2022-02-28 07:30:32 +01:00
2022-03-15 10:32:45 +01:00
2022-03-21 11:35:29 -05:00
2022-03-24 19:06:45 -07:00
2022-03-22 15:57:06 -07:00
2022-04-01 13:45:08 -04:00
2022-03-25 13:02:05 -07:00
2022-03-30 07:22:13 +02:00
2022-03-10 17:16:56 -08:00
2022-02-28 11:57:49 +00:00
2022-03-03 09:35:04 +05:30
2022-03-04 18:26:54 +01:00
2022-03-08 19:57:01 +01:00
2022-03-28 17:29:53 -07:00
2022-02-28 11:34:32 +01:00
2022-03-21 11:13:49 +01:00
2022-03-15 11:08:23 -07:00
2022-03-07 11:31:34 +00:00
2022-03-18 09:52:10 -05:00
2022-03-22 09:17:20 -07:00
2022-03-07 23:01:26 +01:00
2022-03-21 14:00:56 -07:00
2022-03-18 16:53:19 +00:00
2022-03-11 14:31:55 -06:00
2022-03-08 14:33:36 -06:00
2022-03-10 16:51:50 -06:00
2022-03-17 20:16:29 -07:00
2022-03-01 10:59:13 +01:00
2022-03-21 13:01:35 -04:00
2022-03-23 19:58:41 +01:00
2022-03-03 10:37:23 +00:00
2022-03-21 20:01:34 -06:00
2022-03-31 10:36:55 +02:00
2022-03-18 13:30:54 +01:00
2022-02-28 21:49:06 +01:00
2022-03-22 15:57:01 -07:00
2022-02-24 15:04:51 +00:00
2022-03-22 11:18:49 -07:00
2022-03-15 16:43:31 +01:00
2022-03-23 12:33:21 -07:00
2022-03-17 20:17:18 -07:00
2022-03-23 19:00:33 -07:00
2022-03-24 19:06:51 -07:00
2022-02-25 09:36:06 +01:00
2022-03-07 12:48:35 -07:00
2022-03-10 13:39:04 -06:00
2022-03-22 15:57:11 -07:00
2022-03-24 13:13:26 -07:00
2022-03-17 20:17:18 -07:00
2022-03-23 18:03:08 -07:00
2022-04-02 10:32:14 -07:00
2022-03-28 16:53:00 -04:00
2022-03-03 09:55:34 -07:00
2022-03-03 13:00:16 +02:00
2022-03-04 08:33:21 -05:00
2022-03-04 08:33:21 -05:00
2022-03-22 15:57:09 -07:00
2022-03-24 19:06:47 -07:00
2022-03-11 10:17:12 -08:00
2022-04-01 13:40:44 -07:00
Al Viro
6319194ec5