Nicolas Schichan 5dbe7c178d
net: fix kernel deadlock with interface rename and netdev name retrieval. ...
When the kernel (compiled with CONFIG_PREEMPT=n) is performing the
rename of a network interface, it can end up waiting for a workqueue
to complete. If userland is able to invoke a SIOCGIFNAME ioctl or a
SO_BINDTODEVICE getsockopt in between, the kernel will deadlock due to
the fact that read_secklock_begin() will spin forever waiting for the
writer process (the one doing the interface rename) to update the
devnet_rename_seq sequence.
This patch fixes the problem by adding a helper (netdev_get_name())
and using it in the code handling the SIOCGIFNAME ioctl and
SO_BINDTODEVICE setsockopt.
The netdev_get_name() helper uses raw_seqcount_begin() to avoid
spinning forever, waiting for devnet_rename_seq->sequence to become
even. cond_resched() is used in the contended case, before retrying
the access to give the writer process a chance to finish.
The use of raw_seqcount_begin() will incur some unneeded work in the
reader process in the contended case, but this is better than
deadlocking the system.
Signed-off-by: Nicolas Schichan <nschichan@freebox.fr >
Acked-by: Eric Dumazet <edumazet@google.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2013-06-26 13:42:54 -07:00
2013-03-29 09:20:05 -07:00
2013-05-17 14:31:05 -04:00
2013-05-02 11:58:41 -05:00
2013-05-04 12:31:18 -07:00
2013-04-08 16:36:23 +02:00
2013-04-30 09:36:50 -07:00
2013-05-05 17:36:20 -07:00
2013-04-11 03:39:00 -07:00
2013-05-17 00:42:33 +02:00
2013-05-11 16:12:44 -07:00
2013-05-06 15:41:42 -07:00
2013-05-09 10:15:46 -07:00
2013-04-29 20:09:03 +02:00
2013-05-14 13:40:45 +02:00
2013-05-25 20:30:31 -07:00
2013-04-16 17:38:10 -07:00
2013-04-28 02:13:43 +01:00
2013-05-13 18:27:18 +04:00
2013-04-23 14:09:39 -04:00
2013-04-29 16:23:34 -04:00
2013-05-16 17:32:21 -07:00
2013-05-14 10:23:57 +05:30
2013-04-12 00:31:18 +02:00
2013-04-30 15:21:02 -07:00
2013-05-30 10:51:20 -07:00
2013-05-07 19:46:02 -07:00
2013-03-12 13:59:14 -07:00
2013-04-03 19:33:40 -04:00
2013-05-07 22:27:15 -04:00
2013-04-01 19:08:06 -07:00
2013-04-10 23:41:16 +02:00
2013-04-29 15:40:23 -04:00
2013-03-23 14:26:34 -07:00
2013-05-08 10:13:35 -07:00
2013-05-08 10:13:35 -07:00
2013-04-18 09:00:26 -07:00
2013-04-29 15:54:39 -07:00
2013-05-15 14:42:15 -07:00
2013-05-01 08:04:12 -07:00
2013-04-14 10:06:31 -07:00
2013-03-23 16:11:31 -07:00
2013-05-24 10:50:24 +09:00
2013-04-30 17:04:01 -07:00
2013-03-22 15:18:18 -07:00
2013-04-12 11:22:35 -07:00
2013-04-10 16:33:53 -07:00
2013-04-30 15:21:02 -07:00
2013-05-02 09:03:55 -07:00
2013-03-20 13:23:21 -04:00
2013-05-09 13:46:38 -04:00
2013-04-29 18:28:13 -07:00
2013-04-08 17:28:34 +02:00
2013-04-29 18:28:13 -07:00
2013-03-07 17:10:11 +01:00
2013-04-27 09:25:59 +08:00
2013-06-12 16:29:44 -07:00
2013-04-02 15:24:00 +02:00
2013-05-11 15:23:17 -07:00
2013-03-12 11:30:04 -07:00
2013-05-01 17:51:54 -07:00
2013-04-29 18:28:19 -07:00
2013-04-29 15:54:27 -07:00
2013-04-02 01:28:41 +02:00
2013-05-10 14:37:17 +01:00
2013-05-01 13:20:04 -07:00
2013-05-01 16:36:22 +05:30
2013-05-02 21:52:26 +05:30
2013-04-30 17:04:02 -07:00
2013-03-22 22:18:09 -06:00
2013-03-28 10:10:25 -06:00
2013-03-16 06:32:30 +01:00
2013-04-30 16:03:10 +01:00
2013-05-07 18:38:27 -07:00
2013-03-27 13:48:25 +01:00
2013-03-15 15:09:43 +10:30
2013-04-29 18:28:40 -07:00
2013-03-18 21:00:35 +09:00
2013-05-01 17:31:42 -04:00
2013-06-10 22:23:32 -07:00
2013-03-31 11:38:33 -07:00
2013-04-30 17:04:00 -07:00
2013-03-27 07:49:29 -07:00
2013-05-07 02:16:31 -04:00
2013-04-29 18:28:41 -07:00
2013-05-09 20:14:25 -04:00
2013-05-09 20:10:22 -04:00
2013-04-29 18:28:13 -07:00
2013-04-11 10:00:05 +08:00
2013-04-16 18:47:14 +09:00
2013-03-18 10:21:23 +01:00
2013-04-30 10:09:06 +02:00
2013-05-06 13:07:33 +02:00
2013-03-22 16:19:59 -07:00
2013-04-29 15:54:38 -07:00
2013-05-07 18:38:27 -07:00
2013-04-29 15:54:26 -07:00
2013-04-02 07:07:32 +02:00
2013-04-02 07:06:17 +02:00
2013-04-29 13:54:36 -04:00
2013-05-08 11:51:05 -07:00
2013-04-16 15:29:45 +02:00
2013-03-26 12:32:13 -04:00
2013-06-12 00:56:27 -07:00
2013-06-19 23:16:50 -07:00
2013-03-27 13:48:25 +01:00
2013-03-27 13:48:25 +01:00
2013-05-02 12:10:19 +02:00
2013-04-29 15:54:37 -07:00
2013-03-15 12:23:09 -07:00
2013-05-01 08:12:58 -07:00
2013-03-22 16:41:19 -07:00
2013-04-19 17:49:23 -04:00
2013-04-25 15:25:23 +02:00
2013-03-22 16:20:00 -07:00
2013-05-13 09:45:01 -04:00
2013-04-29 15:42:02 -04:00
2013-05-24 16:22:51 -07:00
2013-04-17 12:35:33 -07:00
2013-04-30 17:04:06 -07:00
2013-04-08 17:28:34 +02:00
2013-05-16 07:55:07 -07:00
2013-04-30 17:04:02 -07:00
2013-04-19 16:39:13 -04:00
2013-05-05 14:47:31 -07:00
2013-04-07 13:05:35 +03:00
2013-04-01 11:04:50 -07:00
2013-04-03 19:33:43 -04:00
2013-05-05 10:58:06 -07:00
2013-03-12 14:07:41 -07:00
2013-05-31 17:31:52 -07:00
2013-03-22 22:17:36 -06:00
2013-06-12 16:29:47 -07:00
2013-04-15 14:06:39 +00:00
2013-04-08 16:57:15 -07:00
2013-04-29 15:54:37 -07:00
2013-04-30 17:04:00 -07:00
2013-03-12 06:50:58 -04:00
2013-05-07 18:38:26 -07:00
2013-03-28 17:45:51 -07:00
2013-04-30 09:36:50 -07:00
2013-03-29 08:35:47 -07:00
2013-03-15 15:09:43 +10:30
2013-03-27 07:50:04 -07:00
2013-04-23 09:50:30 -06:00
2013-04-19 09:33:36 +02:00
2013-03-22 10:25:15 -04:00
2013-04-29 18:28:44 -07:00
2013-05-02 07:34:58 -07:00
2013-06-26 13:42:54 -07:00
2013-05-23 11:58:55 +02:00
2013-04-05 21:08:11 +02:00
2013-04-19 14:57:58 -04:00
2013-05-01 15:00:24 -04:00
2013-04-14 12:59:28 -04:00
2013-04-08 22:12:33 -04:00
2013-05-06 17:24:22 -04:00
2013-04-29 15:54:36 -07:00
2013-05-04 14:47:26 -04:00
2013-05-08 09:55:05 -04:00
2013-05-02 21:50:38 +05:30
2013-04-02 16:43:09 -04:00
2013-04-09 14:58:32 -05:00
2013-05-07 11:22:14 -07:00
2013-03-29 17:54:33 -07:00
2013-04-29 15:54:28 -07:00
2013-04-19 22:25:51 +02:00
2013-04-17 10:21:17 -06:00
2013-05-02 07:32:24 -07:00
2013-05-17 14:12:06 -06:00
2013-04-17 10:21:17 -06:00
2013-04-17 10:21:17 -06:00
2013-05-01 14:08:52 -07:00
2013-04-17 10:21:17 -06:00
2013-05-02 17:54:19 +02:00
2013-03-12 11:40:53 -04:00
2013-05-07 20:16:25 -07:00
2013-04-09 14:13:02 -04:00
2013-03-29 09:14:16 -07:00
2013-03-07 12:35:51 +08:00
2013-03-19 09:47:30 +01:00
2013-05-05 13:23:27 -07:00
2013-04-16 18:51:16 -07:00
2013-04-09 10:48:33 -07:00
2013-05-22 01:34:24 +02:00
2013-05-01 17:29:47 -04:00
2013-05-01 17:29:39 -04:00
2013-04-09 14:13:35 -04:00
2013-04-03 21:50:00 -07:00
2013-04-29 15:54:28 -07:00
2013-05-07 18:38:27 -07:00
2013-03-12 14:07:41 -07:00
2013-06-02 20:53:59 -07:00
2013-05-28 22:47:13 -04:00
2013-05-28 22:47:13 -04:00
2013-03-27 13:03:39 +00:00
2013-04-30 17:04:09 -07:00
2013-04-07 14:06:17 +03:00
2013-04-29 19:14:20 -07:00
2013-04-12 10:26:23 +02:00
2013-04-12 10:26:23 +02:00
2013-03-15 00:34:50 -04:00
2013-05-24 16:22:50 -07:00
2013-05-24 16:22:50 -07:00
2013-04-29 18:28:22 -07:00
2013-03-07 15:29:45 -05:00
2013-03-23 15:53:52 -07:00
2013-05-30 09:20:20 +02:00
2013-05-11 14:29:11 -07:00
2013-04-09 13:19:39 -04:00
2013-04-30 16:27:51 -07:00
2013-04-09 14:13:29 -04:00
2013-04-11 13:14:36 -07:00
2013-03-29 15:31:30 -04:00
2013-05-01 17:51:54 -07:00
2013-06-25 16:07:44 -07:00
2013-05-06 09:24:16 +03:00
2013-06-14 19:24:42 -10:00
2013-04-29 13:21:30 -04:00
2013-06-06 11:52:14 -07:00
2013-04-09 10:48:33 -07:00
2013-03-25 10:39:40 -07:00
2013-04-30 17:04:03 -07:00
2013-04-30 15:50:12 +05:30
2013-04-29 15:54:38 -07:00
2013-06-12 16:29:46 -07:00
2013-04-17 12:35:32 -07:00
2013-06-12 16:29:44 -07:00
2013-03-21 11:47:51 -04:00
2013-03-29 18:10:22 -06:00
2013-05-09 09:40:49 -07:00
2013-04-22 20:29:07 +02:00
2013-05-14 20:54:06 +02:00
2013-04-04 13:18:31 -07:00
2013-04-25 21:01:45 +08:00
2013-04-04 13:18:14 -07:00
2013-03-15 00:36:09 -04:00
2013-06-10 13:37:10 -07:00
2013-03-18 16:14:55 -07:00
2013-05-11 14:29:11 -07:00
2013-04-19 00:40:07 +02:00
2013-04-15 21:23:03 +01:00
2013-03-20 12:10:38 -04:00
2013-05-20 10:24:22 +09:30
2013-04-13 15:31:58 +02:00
2013-03-28 11:10:22 -07:00
2013-03-27 07:50:08 -07:00
2013-03-21 15:17:40 +00:00
2013-03-11 09:28:44 -06:00
2013-03-20 14:06:06 +10:30
2013-03-20 14:00:41 +10:30
2013-05-02 14:14:04 -07:00
2013-03-08 12:24:48 -05:00
2013-04-29 15:54:34 -07:00
2013-04-29 15:54:38 -07:00
2013-04-29 15:54:37 -07:00
2013-03-20 14:06:05 +10:30
2013-05-20 12:15:59 -07:00
2013-05-24 16:22:50 -07:00
2013-04-30 17:04:02 -07:00
2013-05-07 20:16:25 -07:00
5dbe7c178d