Eric Dumazet 7c6d2ecbda
net: be more gentle about silly gso requests coming from user ...
Recent change in virtio_net_hdr_to_skb() broke some packetdrill tests.
When --mss=XXX option is set, packetdrill always provide gso_type & gso_size
for its inbound packets, regardless of packet size.
if (packet->tcp && packet->mss) {
if (packet->ipv4)
gso.gso_type = VIRTIO_NET_HDR_GSO_TCPV4;
else
gso.gso_type = VIRTIO_NET_HDR_GSO_TCPV6;
gso.gso_size = packet->mss;
}
Since many other programs could do the same, relax virtio_net_hdr_to_skb()
to no longer return an error, but instead ignore gso settings.
This keeps Willem intent to make sure no malicious packet could
reach gso stack.
Note that TCP stack has a special logic in tcp_set_skb_tso_segs()
to clear gso_size for small packets.
Fixes: 6dd912f826edumazet@google.com >
Cc: Willem de Bruijn <willemb@google.com >
Acked-by: Willem de Bruijn <willemb@google.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2020-05-28 16:31:30 -07:00
2020-04-28 17:44:34 +02:00
2020-04-18 15:44:54 -05:00
2020-03-30 12:42:42 +02:00
2020-03-24 16:19:01 -07:00
2020-04-03 15:05:35 -07:00
2020-04-01 14:47:40 -07:00
2020-03-31 21:29:04 +02:00
2020-04-20 14:07:00 +02:00
2020-04-16 10:28:12 +01:00
2020-04-08 21:29:10 -07:00
2020-05-22 17:28:38 -07:00
2020-03-26 14:45:31 +01:00
2020-03-30 10:14:19 +02:00
2020-05-27 13:39:08 +02:00
2020-03-15 15:20:16 +01:00
2020-03-15 15:20:16 +01:00
2020-03-15 15:20:16 +01:00
2020-03-15 15:20:16 +01:00
2020-03-17 22:50:30 +00:00
2020-03-19 13:59:46 +01:00
2020-03-31 22:08:54 +02:00
2020-05-06 16:40:14 -07:00
2020-04-10 15:36:22 -07:00
2020-03-30 11:45:18 -07:00
2020-03-24 07:57:08 -06:00
2020-03-18 21:57:20 +00:00
2020-04-18 15:44:56 -05:00
2020-04-03 15:05:35 -07:00
2020-03-20 19:25:14 +05:30
2020-04-07 19:44:52 -07:00
2020-05-11 12:04:52 -07:00
2020-03-16 22:08:34 -04:00
2020-04-02 15:50:04 -07:00
2020-04-08 21:03:40 -07:00
2020-03-28 13:19:05 -05:00
2020-03-31 10:05:01 -07:00
2020-05-09 16:07:57 -06:00
2020-05-07 08:45:47 -06:00
2020-03-25 10:03:36 -05:00
2020-04-18 15:44:54 -05:00
2020-03-12 15:48:37 -07:00
2020-04-07 10:43:42 -07:00
2020-04-07 10:43:43 -07:00
2020-04-18 15:44:54 -05:00
2020-04-01 14:56:44 -06:00
2020-04-18 15:44:54 -05:00
2020-03-30 11:43:51 -07:00
2020-03-30 01:34:00 +02:00
2020-03-30 01:34:00 +02:00
2020-03-30 14:59:53 -07:00
2020-03-30 17:36:33 -07:00
2020-03-30 19:52:37 -07:00
2020-05-14 17:40:06 -07:00
2020-04-15 23:58:48 -04:00
2020-04-03 11:30:20 -07:00
2020-03-25 17:38:23 -07:00
2020-03-21 15:23:56 +01:00
2020-04-10 15:36:21 -07:00
2020-03-31 11:04:05 -07:00
2020-04-07 10:43:42 -07:00
2020-05-15 11:48:01 +02:00
2020-03-21 16:00:24 +01:00
2020-03-17 15:26:43 +01:00
2020-03-21 15:23:53 +01:00
2020-03-21 11:32:20 +01:00
2020-05-14 11:11:20 +02:00
2020-04-18 15:44:55 -05:00
2020-03-28 11:42:55 +01:00
2020-03-16 15:48:54 +00:00
2020-03-20 13:06:18 +01:00
2020-04-03 11:32:13 -04:00
2020-04-02 19:15:03 -07:00
2020-04-17 17:08:50 +02:00
2020-04-07 10:45:15 +02:00
2020-03-25 08:35:03 +09:00
2020-04-02 19:15:03 -07:00
2020-04-08 11:00:00 -07:00
2020-04-18 15:44:54 -05:00
2020-04-18 15:44:54 -05:00
2020-04-30 19:47:39 +05:30
2020-03-16 10:48:12 +01:00
2020-04-27 21:26:23 +05:30
2020-03-10 10:30:52 +01:00
2020-03-20 14:57:54 +01:00
2020-05-17 11:46:50 +02:00
2020-03-21 15:24:00 +01:00
2020-04-18 15:44:54 -05:00
2020-04-18 15:44:54 -05:00
2020-03-22 23:06:34 +01:00
2020-04-18 15:44:54 -05:00
2020-03-19 07:41:01 +01:00
2020-03-25 08:16:13 +09:00
2020-03-22 21:16:28 -07:00
2020-03-25 23:17:16 +01:00
2020-03-20 08:47:27 -06:00
2020-03-13 12:49:51 -07:00
2020-03-20 14:54:04 +01:00
2020-05-04 09:16:37 -07:00
2020-03-19 21:56:54 -07:00
2020-03-25 10:27:16 +01:00
2020-03-25 10:27:16 +01:00
2020-05-12 18:24:34 -04:00
2020-04-18 15:44:54 -05:00
2020-03-30 11:20:13 -07:00
2020-04-07 10:43:38 -07:00
2020-03-21 16:03:53 +01:00
2020-03-17 17:25:06 +01:00
2020-03-27 20:19:24 -03:00
2020-04-28 11:44:07 +02:00
2020-04-07 10:43:39 -07:00
2020-04-02 09:35:32 -07:00
2020-04-10 15:36:21 -07:00
2020-05-15 11:23:49 +02:00
2020-03-10 12:20:04 +01:00
2020-05-05 16:29:09 +02:00
2020-05-25 10:33:50 +02:00
2020-04-18 15:44:55 -05:00
2020-04-18 15:44:55 -05:00
2020-03-12 07:43:57 -04:00
2020-03-12 22:34:48 -07:00
2020-03-13 14:25:46 +01:00
2020-03-11 14:15:20 -06:00
2020-03-12 07:07:38 -06:00
2020-03-27 11:14:52 +01:00
2020-03-23 22:00:02 -07:00
2020-03-29 22:30:57 -07:00
2020-03-21 16:00:24 +01:00
2020-04-19 11:23:33 -07:00
2020-03-17 19:13:32 +01:00
2020-04-01 13:20:14 +02:00
2020-03-21 15:23:58 +01:00
2020-04-02 09:35:30 -07:00
2020-03-16 15:53:47 -04:00
2020-03-29 12:40:41 +01:00
2020-04-02 09:35:25 -07:00
2020-03-30 18:51:47 -07:00
2020-05-08 07:44:32 -04:00
2020-04-06 22:55:27 +02:00
2020-03-26 10:28:20 -06:00
2020-03-17 12:23:21 -07:00
2020-03-31 17:29:33 -07:00
2020-04-18 15:44:55 -05:00
2020-03-17 17:25:06 +01:00
2020-03-23 18:40:25 +01:00
2020-05-15 13:10:06 -07:00
2020-03-31 17:29:33 -07:00
2020-03-21 15:23:56 +01:00
2020-03-09 20:13:16 -07:00
2020-03-17 22:51:16 -07:00
2020-04-10 15:36:21 -07:00
2020-05-14 10:00:35 -07:00
2020-04-10 15:36:21 -07:00
2020-04-07 10:43:40 -07:00
2020-04-02 09:35:31 -07:00
2020-04-08 21:03:40 -07:00
2020-05-05 16:58:36 +02:00
2020-03-26 14:33:38 -03:00
2020-03-15 17:10:14 -07:00
2020-03-19 07:41:02 +01:00
2020-04-07 10:43:38 -07:00
2020-04-07 10:43:41 -07:00
2020-04-10 15:36:21 -07:00
2020-04-08 21:03:40 -07:00
2020-04-03 13:22:40 -07:00
2020-03-24 13:42:44 +01:00
2020-03-24 07:57:08 -06:00
2020-03-21 16:00:24 +01:00
2020-03-13 21:08:19 -04:00
2020-03-26 20:17:36 -07:00
2020-03-30 19:52:37 -07:00
2020-03-18 16:35:48 -07:00
2020-03-25 18:58:11 -07:00
2020-04-06 13:56:33 -04:00
2020-04-01 13:37:57 -04:00
2020-04-28 15:58:38 -04:00
2020-04-04 09:09:39 +02:00
2020-03-19 07:41:02 +01:00
2020-04-02 09:35:27 -07:00
2020-04-07 10:43:39 -07:00
2020-04-07 10:43:38 -07:00
2020-04-07 10:43:38 -07:00
2020-03-25 09:50:09 -06:00
2020-04-03 14:25:02 -07:00
2020-03-28 13:19:04 -05:00
2020-04-02 17:57:10 +01:00
2020-04-02 17:57:10 +01:00
2020-04-03 14:25:02 -07:00
2020-04-07 10:43:43 -07:00
2020-03-27 10:41:44 -03:00
2020-03-23 22:00:02 -07:00
2020-03-30 11:52:27 -07:00
2020-04-09 12:15:35 -05:00
2020-04-28 17:44:33 +02:00
2020-04-22 11:36:11 +02:00
2020-04-18 15:44:55 -05:00
2020-04-10 13:18:57 -07:00
2020-04-07 10:43:42 -07:00
2020-04-02 11:22:17 -07:00
2020-03-20 13:06:18 +01:00
2020-03-20 13:06:19 +01:00
2020-05-12 12:10:17 -07:00
2020-03-18 15:05:57 +00:00
2020-03-30 16:55:26 +02:00
2020-03-21 16:00:22 +01:00
2020-04-08 12:05:07 +02:00
2020-03-25 22:29:45 -07:00
2020-03-27 16:39:01 -04:00
2020-04-18 15:44:56 -05:00
2020-04-18 15:44:56 -05:00
2020-04-02 18:47:30 +02:00
2020-03-21 16:00:24 +01:00
2020-03-21 16:00:24 +01:00
2020-04-02 11:22:17 -07:00
2020-03-31 15:49:51 -07:00
2020-04-07 10:43:42 -07:00
2020-03-17 15:58:00 +01:00
2020-03-12 17:16:42 +01:00
2020-04-07 10:43:38 -07:00
2020-03-26 14:41:22 -04:00
2020-04-18 15:44:56 -05:00
2020-05-06 00:22:22 +02:00
2020-04-10 15:36:20 -07:00
2020-03-30 12:18:49 -07:00
2020-03-21 16:00:24 +01:00
2020-03-21 16:00:24 +01:00
2020-04-07 10:43:43 -07:00
2020-03-18 09:50:20 +00:00
2020-04-21 15:54:45 -07:00
2020-03-23 13:41:55 +01:00
2020-04-18 15:44:56 -05:00
2020-04-07 10:43:41 -07:00
2020-04-05 11:34:35 -07:00
2020-04-30 12:23:22 -07:00
2020-03-12 11:56:53 +01:00
2020-03-21 17:48:13 +01:00
2020-04-18 15:44:56 -05:00
2020-03-30 18:51:47 -07:00
2020-03-21 15:23:58 +01:00
2020-03-21 15:23:57 +01:00
2020-03-30 14:59:53 -07:00
2020-04-02 09:35:26 -07:00
2020-04-18 15:44:56 -05:00
2020-03-19 17:48:36 -04:00
2020-04-22 22:06:35 -04:00
2020-05-04 09:16:37 -07:00
2020-03-18 12:34:10 +01:00
2020-04-07 10:43:39 -07:00
2020-03-23 17:01:47 +01:00
2020-04-17 06:05:30 -04:00
2020-04-23 10:50:26 +09:00
2020-03-24 09:32:41 -06:00
2020-04-01 12:06:26 -04:00
2020-05-28 16:31:30 -07:00
2020-04-27 10:18:01 -07:00
2020-04-17 06:05:30 -04:00
2020-04-07 10:43:38 -07:00
2020-04-21 11:11:56 -07:00
2020-04-16 18:31:08 -04:00
2020-04-03 12:27:36 -07:00
2020-03-12 17:42:08 -04:00
2020-04-18 15:44:56 -05:00
Eric Dumazet
7c6d2ecbda