Files
kernel/include/linux
Martin KaFai Lau 4a9c7bbe2e bpf: Resolve to prog->aux->dst_prog->type only for BPF_PROG_TYPE_EXT
The commit 7e40781cc8 ("bpf: verifier: Use target program's type for access verifications")
fixes the verifier checking for BPF_PROG_TYPE_EXT (extension)
prog such that the verifier looks for things based
on the target prog type that it is extending instead of
the BPF_PROG_TYPE_EXT itself.

The current resolve_prog_type() returns the target prog type.
It checks for nullness on prog->aux->dst_prog.  However,
when loading a BPF_PROG_TYPE_TRACING prog and it is tracing another
bpf prog instead of a kernel function, prog->aux->dst_prog is not
NULL also.  In this case, the verifier should still verify as the
BPF_PROG_TYPE_TRACING type instead of the traced prog type in
prog->aux->dst_prog->type.

An oops has been reported when tracing a struct_ops prog.  A NULL
dereference happened in check_return_code() when accessing the
prog->aux->attach_func_proto->type and prog->aux->attach_func_proto
is NULL here because the traced struct_ops prog has the "unreliable" set.

This patch is to change the resolve_prog_type() to only
return the target prog type if the prog being verified is
BPF_PROG_TYPE_EXT.

Fixes: 7e40781cc8 ("bpf: verifier: Use target program's type for access verifications")
Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/20220330011456.2984509-1-kafai@fb.com
2022-03-30 19:31:30 -07:00
..
2022-02-27 13:38:10 +00:00
2022-02-01 14:25:50 +02:00
2022-03-08 19:39:38 -07:00
2022-03-17 20:17:18 -07:00
2022-03-15 10:32:44 +01:00
2022-02-07 16:35:35 -08:00
2022-02-07 16:35:35 -08:00
2022-03-16 15:13:36 -07:00
2022-02-13 16:50:07 -08:00
2022-03-02 22:44:49 -08:00
2022-03-15 08:23:29 -04:00
2022-02-28 13:25:49 +01:00
2022-02-19 19:23:53 -08:00
2022-02-14 15:43:15 +01:00
2022-02-05 15:20:34 +00:00
2022-03-18 09:47:04 +01:00
2022-01-27 13:53:26 +00:00
2022-03-21 12:57:38 -04:00
2022-02-09 09:24:40 -05:00
2022-02-28 13:45:04 +02:00
2022-03-07 12:49:13 -07:00
2022-03-24 19:06:45 -07:00
2022-02-02 07:49:59 -07:00
2022-02-09 08:04:44 +01:00
2022-02-09 08:04:44 +01:00
2022-01-22 08:33:37 +02:00
2022-01-24 14:45:02 +01:00
2022-03-08 14:33:36 -06:00
2022-03-17 20:16:29 -07:00
2022-01-22 08:33:37 +02:00
2022-02-24 15:04:51 +00:00
2022-02-25 09:36:06 +01:00
2022-03-07 12:48:35 -07:00
2022-02-16 07:49:41 +01:00
2022-03-22 15:57:11 -07:00
2022-01-26 14:54:48 +01:00
2022-01-27 13:53:27 +00:00