Al Viro b4c0353693
sanitize handling of nd->last_type, kill LAST_BIND ...
->last_type values are set in 3 places: path_init() (sets to LAST_ROOT),
link_path_walk (LAST_NORM/DOT/DOTDOT) and pick_link (LAST_BIND).
The are checked in walk_component(), lookup_last() and do_last().
They also get copied to the caller by filename_parentat(). In the last
3 cases the value is what we had at the return from link_path_walk().
In case of walk_component() it's either directly downstream from
assignment in link_path_walk() or, when called by lookup_last(), the
value we have at the return from link_path_walk().
The value at the entry into link_path_walk() can survive to return only
if the pathname contains nothing but slashes. Note that pick_link()
never returns such - pure jumps are handled directly. So for the calls
of link_path_walk() for trailing symlinks it does not matter what value
had been there at the entry; the value at the return won't depend upon it.
There are 3 call chains that might have pick_link() storing LAST_BIND:
1) pick_link() from step_into() from walk_component() from
link_path_walk(). In that case we will either be parsing the next
component immediately after return into link_path_walk(), which will
overwrite the ->last_type before anyone has a chance to look at it,
or we'll fail, in which case nobody will be looking at ->last_type at all.
2) pick_link() from step_into() from walk_component() from lookup_last().
The value is never looked at due to the above; it won't affect the value
seen at return from any link_path_walk().
3) pick_link() from step_into() from do_last(). Ditto.
In other words, assignemnt in pick_link() is pointless, and so is
LAST_BIND itself; nothing ever looks at that value. Kill it off.
And make link_path_walk() _always_ assign ->last_type - in the only
case when the value at the entry might survive to the return that value
is always LAST_ROOT, inherited from path_init(). Move that assignment
from path_init() into the beginning of link_path_walk(), to consolidate
the things.
Historical note: LAST_BIND used to be used for the kludge with trailing
pure jump symlinks (extra iteration through the top-level loop).
No point keeping it anymore...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
2020-03-13 21:08:19 -04:00
2020-01-02 15:34:27 +01:00
2020-02-08 13:26:41 -08:00
2019-12-16 10:11:16 +01:00
2020-01-21 11:06:12 +05:30
2020-01-05 15:13:13 -08:00
2020-02-08 14:04:19 -08:00
2020-01-05 23:22:32 -08:00
2020-01-29 09:51:36 -08:00
2020-01-18 14:26:13 +00:00
2020-02-08 10:01:33 +00:00
2019-12-11 09:12:38 +01:00
2020-01-08 12:59:53 +01:00
2020-02-04 07:17:41 +00:00
2020-01-31 14:40:36 -08:00
2020-02-06 12:24:24 -08:00
2020-01-28 16:02:33 -08:00
2020-01-27 17:49:15 +01:00
2020-01-24 20:54:29 +01:00
2020-01-14 10:50:19 +05:30
2019-12-30 14:27:53 +01:00
2020-02-08 17:15:08 -08:00
2019-12-19 01:07:53 +01:00
2020-01-27 14:35:32 +01:00
2020-01-13 11:44:09 -08:00
2020-01-15 14:10:45 +00:00
2020-01-20 10:29:56 -08:00
2020-01-20 10:29:56 -08:00
2020-01-28 10:07:09 -08:00
2020-02-08 14:04:19 -08:00
2020-01-16 17:32:43 +05:30
2020-01-23 12:37:18 +00:00
2020-02-07 17:39:56 -08:00
2020-01-29 10:09:44 -08:00
2019-12-27 11:02:07 +01:00
2019-12-04 13:32:45 +10:00
2019-12-25 20:47:19 -07:00
2020-01-24 21:03:53 +01:00
2020-01-14 15:16:50 +01:00
2020-01-15 22:55:36 -05:00
2020-01-31 10:30:36 -08:00
2019-12-28 09:44:56 -07:00
2020-02-04 03:05:26 +00:00
2020-02-04 03:05:26 +00:00
2019-12-12 09:26:55 -07:00
2020-01-29 18:16:16 -08:00
2020-01-13 13:19:38 -05:00
2020-01-22 23:04:52 +01:00
2020-01-10 17:20:07 +01:00
2019-12-27 14:20:10 -08:00
2020-01-29 16:40:54 +01:00
2020-01-22 23:04:52 +01:00
2019-12-04 19:44:12 -08:00
2020-01-04 20:23:39 -07:00
2020-01-31 13:14:26 -08:00
2020-01-07 11:31:47 +01:00
2020-01-27 10:24:32 +01:00
2020-01-03 09:32:51 +01:00
2020-01-21 13:28:24 +01:00
2020-01-27 19:59:55 +01:00
2020-01-27 10:24:32 +01:00
2020-01-27 10:33:33 +01:00
2020-02-08 14:04:19 -08:00
2020-01-23 00:35:50 +01:00
2020-02-04 03:05:27 +00:00
2020-01-09 11:30:53 +08:00
2019-12-10 22:29:58 -05:00
2019-12-16 10:11:10 +01:00
2019-12-30 09:59:06 +09:00
2019-12-16 10:11:16 +01:00
2019-12-11 11:13:33 +05:30
2019-11-28 11:16:43 -08:00
2020-01-27 10:55:50 -08:00
2019-12-03 11:20:37 +01:00
2020-01-20 08:14:29 +01:00
2020-01-27 11:09:31 +01:00
2019-12-27 16:40:02 -08:00
2020-02-03 17:27:38 -07:00
2020-01-29 15:45:47 -07:00
2019-12-16 10:35:33 +01:00
2020-01-13 14:15:27 +09:00
2020-01-17 16:48:07 -08:00
2020-01-03 09:42:52 +01:00
2020-01-03 14:27:40 +01:00
2020-01-18 09:19:18 -05:00
2020-01-13 21:48:42 +01:00
2020-01-16 20:03:34 -08:00
2020-02-07 14:48:39 -05:00
2020-02-07 14:48:38 -05:00
2020-02-08 13:26:41 -08:00
2020-01-22 14:50:03 -08:00
2020-01-14 13:27:32 -08:00
2019-12-11 12:22:38 -08:00
2019-12-04 19:44:13 -08:00
2020-01-28 10:07:09 -08:00
2019-12-01 12:59:06 -08:00
2020-01-15 16:21:28 +10:00
2020-01-14 12:20:55 +01:00
2020-01-27 20:00:01 +01:00
2019-12-16 12:41:40 -08:00
2020-01-23 13:15:09 -08:00
2020-01-26 22:10:17 -05:00
2019-12-17 16:48:34 +01:00
2020-01-30 07:39:10 -08:00
2020-01-08 12:52:33 -08:00
2020-01-22 15:22:51 -05:00
2019-12-12 18:58:24 +01:00
2020-01-07 14:05:58 +01:00
2019-12-16 09:25:24 +02:00
2019-12-03 12:20:25 -08:00
2020-01-31 10:30:41 -08:00
2020-01-10 15:52:25 +00:00
2020-01-06 09:45:59 +01:00
2020-01-24 15:39:39 +01:00
2020-02-01 09:31:47 +01:00
2020-02-09 12:11:12 -08:00
2020-01-25 03:01:56 -05:00
2019-12-18 18:07:33 +01:00
2019-12-31 13:15:38 +01:00
2019-12-04 19:44:14 -08:00
2020-01-31 17:33:54 +00:00
2019-12-30 12:01:56 -08:00
2019-12-11 09:12:38 +01:00
2020-01-30 18:47:59 +01:00
2020-01-30 18:45:55 +01:00
2019-12-21 20:09:54 +01:00
2020-01-06 00:20:18 +01:00
2020-02-06 06:11:50 +00:00
2020-01-10 14:00:57 -08:00
2020-01-28 08:46:13 -08:00
2019-12-11 11:13:50 +02:00
2019-12-09 17:53:58 -05:00
2020-01-31 10:30:38 -08:00
2019-12-01 12:59:07 -08:00
2020-02-04 03:05:23 +00:00
2020-01-31 10:30:39 -08:00
2019-12-25 19:51:33 -08:00
2020-01-05 23:22:32 -08:00
2019-12-06 10:28:09 -08:00
2020-02-04 07:21:04 +00:00
2020-02-04 07:24:48 +00:00
2020-01-14 11:54:47 -04:00
2020-02-04 03:05:23 +00:00
2019-12-20 21:47:04 -08:00
2020-02-01 10:01:52 -08:00
2019-12-01 12:59:05 -08:00
2019-12-09 10:55:03 +01:00
2020-03-13 21:08:19 -04:00
2019-12-12 17:04:54 -08:00
2020-01-27 11:00:21 +01:00
2020-01-27 11:31:35 +01:00
2020-01-15 10:54:33 -05:00
2020-02-04 10:50:44 -05:00
2020-01-24 16:51:13 -05:00
2019-12-04 19:44:12 -08:00
2020-01-14 12:20:48 +01:00
2020-01-09 10:48:54 +01:00
2020-02-05 14:52:03 -08:00
2019-12-26 15:17:26 -08:00
2020-01-02 16:50:04 +01:00
2019-12-17 08:06:51 -08:00
2019-12-11 16:37:02 +08:00
2020-01-31 10:30:39 -08:00
2020-01-06 08:58:23 -08:00
2020-02-04 03:05:25 +00:00
2020-01-16 17:09:18 +01:00
2020-01-15 16:30:28 +00:00
2020-01-29 17:00:02 -06:00
2020-01-31 11:15:59 -08:00
2020-01-20 17:04:02 -07:00
2020-02-09 12:04:09 -08:00
2019-12-09 10:36:44 -08:00
2020-01-21 10:50:41 +01:00
2020-01-05 23:22:32 -08:00
2020-02-08 11:39:19 -08:00
2020-01-02 16:52:40 +01:00
2019-11-29 12:04:50 +01:00
2020-01-23 13:15:09 -08:00
2019-12-30 20:19:27 -08:00
2019-12-19 01:36:32 +01:00
2019-12-06 10:47:28 +01:00
2020-02-04 03:05:26 +00:00
2020-01-29 11:20:24 -08:00
2019-12-03 11:46:20 +01:00
2020-01-02 16:49:59 +01:00
2020-01-04 13:49:51 +08:00
2020-02-04 03:05:25 +00:00
2019-12-30 20:31:40 -08:00
2020-01-13 18:16:43 -08:00
2020-01-07 22:14:38 -08:00
2020-02-07 14:48:37 -05:00
2020-01-25 12:18:50 -05:00
2019-12-04 19:44:13 -08:00
2020-01-24 10:24:31 -08:00
2020-01-25 10:05:23 +01:00
2020-01-10 14:00:58 -08:00
2020-01-24 10:37:27 -08:00
2020-01-24 10:24:31 -08:00
2020-01-24 10:24:31 -08:00
2020-01-09 21:23:36 +00:00
2020-01-20 16:19:10 +01:00
2019-12-05 11:43:31 -08:00
2019-12-05 11:43:31 -08:00
2020-01-13 13:19:38 -05:00
2019-12-18 10:38:07 +01:00
2020-01-29 19:38:34 -08:00
2019-12-24 11:35:48 +00:00
2019-12-09 17:53:58 -05:00
2020-02-04 03:05:26 +00:00
2019-12-18 15:04:42 +01:00
2020-01-15 13:39:14 +01:00
2019-12-11 11:53:41 -08:00
2020-02-07 14:48:37 -05:00
2020-02-06 13:59:10 +01:00
2020-01-15 23:26:13 +01:00
2020-02-04 03:05:24 +00:00
2020-01-24 20:40:09 +01:00
2019-12-03 07:04:30 -07:00
2020-01-13 18:31:48 -08:00
2020-01-17 10:19:21 +01:00
2020-02-04 03:05:26 +00:00
2020-01-16 21:47:03 +01:00
2020-01-31 10:30:40 -08:00
2019-12-01 12:59:07 -08:00
2020-01-15 11:00:39 -06:00
2020-01-06 13:33:14 -08:00
2020-01-29 19:38:34 -08:00
2019-12-04 19:44:11 -08:00
2020-01-29 17:45:20 +01:00
2020-01-31 10:30:40 -08:00
2019-12-04 19:44:14 -08:00
2019-12-09 12:32:59 -08:00
2020-01-14 12:20:59 +01:00
2020-01-14 12:20:57 +01:00
2020-01-15 13:39:59 -08:00
2019-12-17 11:46:43 +02:00
2020-02-06 07:12:11 +00:00
2019-12-10 22:29:58 -05:00
2020-01-15 22:55:37 -05:00
2019-12-01 14:00:59 -08:00
2020-01-31 10:30:39 -08:00
2020-01-14 12:20:48 +01:00
2019-12-10 10:12:55 +01:00
2019-12-04 19:44:11 -08:00
2020-01-17 22:33:37 -05:00
2020-01-31 10:30:40 -08:00
Al Viro
b4c0353693