Kent Overstreet 11599ebac4
aio: make aio_put_req() lockless ...
Freeing a kiocb needed to touch the kioctx for three things:
* Pull it off the reqs_active list
* Decrementing reqs_active
* Issuing a wakeup, if the kioctx was in the process of being freed.
This patch moves these to aio_complete(), for a couple reasons:
* aio_complete() already has to issue the wakeup, so if we drop the
kioctx refcount before aio_complete does its wakeup we don't have to
do it twice.
* aio_complete currently has to take the kioctx lock, so it makes sense
for it to pull the kiocb off the reqs_active list too.
* A later patch is going to change reqs_active to include unreaped
completions - this will mean allocating a kiocb doesn't have to look
at the ringbuffer. So taking the decrement of reqs_active out of
kiocb_free() is useful prep work for that patch.
This doesn't really affect cancellation, since existing (usb) code that
implements a cancel function still calls aio_complete() - we just have
to make sure that aio_complete does the necessary teardown for cancelled
kiocbs.
It does affect code paths where we free kiocbs that were never
submitted; they need to decrement reqs_active and pull the kiocb off the
reqs_active list. This occurs in two places: kiocb_batch_free(), which
is going away in a later patch, and the error path in io_submit_one.
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Kent Overstreet <koverstreet@google.com>
Cc: Zach Brown <zab@redhat.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Asai Thambi S P <asamymuthupa@micron.com>
Cc: Selvan Mani <smani@micron.com>
Cc: Sam Bradshaw <sbradshaw@micron.com>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Benjamin LaHaise <bcrl@kvack.org>
Reviewed-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-05-07 18:38:28 -07:00
2013-03-29 09:20:05 -07:00
2013-04-12 14:27:55 -04:00
2013-05-02 11:58:41 -05:00
2013-05-04 12:31:18 -07:00
2013-03-01 13:39:00 -08:00
2013-04-08 16:36:23 +02:00
2013-04-30 09:36:50 -07:00
2013-05-05 17:36:20 -07:00
2013-04-11 03:39:00 -07:00
2013-02-28 18:02:55 -08:00
2013-05-05 17:36:20 -07:00
2013-04-26 23:29:14 -04:00
2013-05-06 15:41:42 -07:00
2013-03-14 12:48:54 +00:00
2013-04-29 20:09:03 +02:00
2013-04-19 15:45:05 +02:00
2013-05-06 15:41:42 -07:00
2013-04-16 17:38:10 -07:00
2013-04-28 02:13:43 +01:00
2013-02-22 09:20:11 -08:00
2013-05-01 14:08:52 -07:00
2013-04-23 14:09:39 -04:00
2013-04-29 16:23:34 -04:00
2013-05-03 09:10:23 -07:00
2013-04-12 00:31:18 +02:00
2013-04-30 15:21:02 -07:00
2013-05-07 18:38:28 -07:00
2013-03-12 13:59:14 -07:00
2013-04-03 19:33:40 -04:00
2013-02-21 17:22:19 -08:00
2013-04-10 23:41:16 +02:00
2013-03-01 12:47:16 +01:00
2013-04-29 15:40:23 -04:00
2013-04-29 15:54:33 -07:00
2013-04-18 09:00:26 -07:00
2013-04-29 15:54:39 -07:00
2013-02-20 09:37:28 -05:00
2013-05-01 08:04:12 -07:00
2013-02-21 17:22:16 -08:00
2013-04-14 10:06:31 -07:00
2013-05-01 17:51:54 -07:00
2013-04-30 17:04:01 -07:00
2013-03-22 15:18:18 -07:00
2013-04-12 11:22:35 -07:00
2013-04-10 16:33:53 -07:00
2013-04-30 15:21:02 -07:00
2013-05-02 09:03:55 -07:00
2013-03-20 13:23:21 -04:00
2013-02-23 17:50:10 -08:00
2013-05-01 07:21:43 -07:00
2013-02-21 17:22:15 -08:00
2013-04-29 18:28:13 -07:00
2013-02-21 17:22:15 -08:00
2013-04-08 17:28:34 +02:00
2013-04-29 18:28:13 -07:00
2013-03-07 17:10:11 +01:00
2013-04-08 17:39:23 +02:00
2013-04-02 15:24:00 +02:00
2013-04-23 13:45:22 +02:00
2013-03-12 11:30:04 -07:00
2013-05-01 17:51:54 -07:00
2013-04-29 18:28:19 -07:00
2013-02-26 02:46:09 -05:00
2013-04-29 15:54:27 -07:00
2013-04-02 01:28:41 +02:00
2013-03-01 22:45:49 +00:00
2013-05-01 13:20:04 -07:00
2013-03-01 22:45:49 +00:00
2013-05-01 16:36:22 +05:30
2013-02-27 22:37:34 +05:30
2013-04-30 17:04:02 -07:00
2013-02-28 09:53:21 +05:30
2013-03-03 23:59:59 -08:00
2013-03-16 06:32:30 +01:00
2013-04-30 16:03:10 +01:00
2013-02-28 12:52:24 -08:00
2013-02-26 02:46:08 -05:00
2013-05-07 18:38:27 -07:00
2013-02-27 19:10:23 -08:00
2013-03-27 13:48:25 +01:00
2013-03-15 15:09:43 +10:30
2013-04-29 18:28:40 -07:00
2013-02-20 01:33:41 +01:00
2013-05-01 17:31:42 -04:00
2013-05-01 16:28:48 -04:00
2013-02-23 17:50:12 -08:00
2013-03-31 11:38:33 -07:00
2013-04-30 17:04:00 -07:00
2013-03-27 07:49:29 -07:00
2013-05-04 14:57:58 -04:00
2013-04-29 18:28:41 -07:00
2013-02-22 23:31:31 -05:00
2013-04-19 17:10:27 -04:00
2013-04-29 13:55:38 -07:00
2013-04-29 18:28:13 -07:00
2013-02-26 03:10:52 +11:00
2013-04-11 10:00:05 +08:00
2013-02-22 00:05:07 +01:00
2013-03-18 10:21:23 +01:00
2013-02-27 19:10:24 -08:00
2013-02-22 08:20:05 +01:00
2013-04-30 10:09:06 +02:00
2013-04-30 10:17:48 +02:00
2013-02-23 17:50:16 -08:00
2013-03-22 16:19:59 -07:00
2013-04-29 15:54:38 -07:00
2013-05-07 18:38:27 -07:00
2013-04-29 15:54:26 -07:00
2013-04-02 07:07:32 +02:00
2013-04-02 07:06:17 +02:00
2013-04-29 13:54:36 -04:00
2013-04-29 18:28:41 -07:00
2013-04-16 15:29:45 +02:00
2013-03-26 12:32:13 -04:00
2013-03-06 14:55:20 -05:00
2013-04-21 15:56:59 -04:00
2013-03-27 13:48:25 +01:00
2013-02-19 08:06:01 +01:00
2013-03-27 13:48:25 +01:00
2013-05-02 12:10:19 +02:00
2013-04-29 15:54:37 -07:00
2013-03-15 12:23:09 -07:00
2013-05-01 08:12:58 -07:00
2013-02-27 19:10:21 -08:00
2013-03-22 16:41:19 -07:00
2013-04-19 17:49:23 -04:00
2013-04-25 15:25:23 +02:00
2013-03-22 16:20:00 -07:00
2013-04-12 00:03:42 -04:00
2013-04-29 15:42:02 -04:00
2013-05-05 10:58:06 -07:00
2013-04-17 12:35:33 -07:00
2013-04-30 17:04:06 -07:00
2013-04-08 17:28:34 +02:00
2013-02-23 17:50:19 -08:00
2013-04-30 17:04:02 -07:00
2013-04-19 16:39:13 -04:00
2013-05-05 14:47:31 -07:00
2013-04-07 13:05:35 +03:00
2013-04-01 11:04:50 -07:00
2013-04-03 19:33:43 -04:00
2013-05-05 10:58:06 -07:00
2013-03-12 14:07:41 -07:00
2013-03-14 13:18:30 -07:00
2013-02-19 15:17:08 -05:00
2013-02-22 19:25:09 -08:00
2013-02-20 19:36:01 +01:00
2013-04-30 19:13:05 +02:00
2013-04-08 16:57:15 -07:00
2013-03-02 09:34:39 -08:00
2013-02-23 17:50:20 -08:00
2013-04-29 15:54:37 -07:00
2013-04-30 17:04:00 -07:00
2013-03-12 06:50:58 -04:00
2013-02-23 17:50:19 -08:00
2013-02-23 17:50:17 -08:00
2013-05-07 18:38:26 -07:00
2013-03-28 17:45:51 -07:00
2013-04-30 09:36:50 -07:00
2013-03-29 08:35:47 -07:00
2013-03-15 15:09:43 +10:30
2013-03-27 07:50:04 -07:00
2013-04-23 09:50:30 -06:00
2013-04-19 09:33:36 +02:00
2013-03-22 10:25:15 -04:00
2013-03-19 11:07:58 +08:00
2013-04-29 18:28:44 -07:00
2013-05-02 07:34:58 -07:00
2013-05-06 11:06:51 -04:00
2013-04-05 21:08:11 +02:00
2013-04-19 14:57:58 -04:00
2013-05-01 15:00:24 -04:00
2013-04-14 12:59:28 -04:00
2013-04-08 22:12:33 -04:00
2013-04-23 15:40:40 -04:00
2013-04-29 15:54:36 -07:00
2013-05-04 14:47:26 -04:00
2013-04-02 16:43:09 -04:00
2013-05-05 17:36:20 -07:00
2013-03-29 17:54:33 -07:00
2013-02-23 00:30:08 +01:00
2013-02-23 17:50:17 -08:00
2013-02-23 17:50:15 -08:00
2013-04-29 15:54:28 -07:00
2013-03-01 23:51:07 -05:00
2013-04-17 10:21:17 -06:00
2013-04-30 08:42:45 -07:00
2013-04-12 16:52:01 -06:00
2013-04-17 10:21:17 -06:00
2013-04-17 10:21:17 -06:00
2013-05-01 14:08:52 -07:00
2013-04-17 10:21:17 -06:00
2013-05-02 17:54:19 +02:00
2013-03-12 11:40:53 -04:00
2013-05-01 17:51:54 -07:00
2013-02-27 19:10:24 -08:00
2013-04-09 14:13:02 -04:00
2013-03-29 09:14:16 -07:00
2013-03-07 12:35:51 +08:00
2013-02-23 17:50:16 -08:00
2013-03-19 09:47:30 +01:00
2013-05-05 13:23:27 -07:00
2013-04-16 18:51:16 -07:00
2013-04-09 10:48:33 -07:00
2013-04-30 17:04:02 -07:00
2013-05-01 17:29:47 -04:00
2013-05-01 17:29:39 -04:00
2013-04-09 14:13:35 -04:00
2013-04-03 21:50:00 -07:00
2013-02-26 09:34:29 -08:00
2013-04-29 15:54:28 -07:00
2013-05-07 18:38:27 -07:00
2013-03-12 14:07:41 -07:00
2013-02-27 19:10:24 -08:00
2013-05-02 17:54:19 +02:00
2013-03-27 13:03:39 +00:00
2013-04-30 17:04:09 -07:00
2013-04-29 19:14:20 -07:00
2013-04-12 10:26:23 +02:00
2013-04-12 10:26:23 +02:00
2013-03-15 00:34:50 -04:00
2013-02-23 17:50:17 -08:00
2013-04-29 18:28:22 -07:00
2013-03-07 15:29:45 -05:00
2013-05-02 19:40:34 -07:00
2013-05-05 13:23:27 -07:00
2013-04-09 13:19:39 -04:00
2013-04-30 16:27:51 -07:00
2013-04-09 14:13:29 -04:00
2013-02-19 08:43:34 +01:00
2013-04-11 13:14:36 -07:00
2013-03-29 15:31:30 -04:00
2013-05-01 17:51:54 -07:00
2013-04-19 14:57:57 -04:00
2013-05-06 09:24:16 +03:00
2013-04-30 17:04:03 -07:00
2013-02-26 22:25:17 +01:00
2013-04-29 13:21:30 -04:00
2013-03-10 22:20:05 +01:00
2013-04-09 10:48:33 -07:00
2013-03-25 10:39:40 -07:00
2013-03-01 12:40:36 +01:00
2013-04-30 17:04:03 -07:00
2013-04-29 15:54:38 -07:00
2013-04-17 12:35:32 -07:00
2013-03-05 15:36:40 -05:00
2013-03-21 11:47:51 -04:00
2013-03-29 18:10:22 -06:00
2013-03-20 17:56:58 -04:00
2013-04-22 20:29:07 +02:00
2013-03-22 16:19:59 -07:00
2013-04-04 13:18:31 -07:00
2013-04-25 21:01:45 +08:00
2013-04-04 13:18:14 -07:00
2013-03-15 00:36:09 -04:00
2013-03-18 16:14:55 -07:00
2013-05-01 17:51:54 -07:00
2013-04-19 00:40:07 +02:00
2013-04-15 21:23:03 +01:00
2013-03-20 12:10:38 -04:00
2013-04-13 15:31:58 +02:00
2013-03-28 11:10:22 -07:00
2013-03-27 07:50:08 -07:00
2013-03-21 15:17:40 +00:00
2013-03-11 09:28:44 -06:00
2013-03-20 14:06:06 +10:30
2013-03-20 14:00:41 +10:30
2013-05-02 14:14:04 -07:00
2013-02-23 17:50:15 -08:00
2013-03-08 12:24:48 -05:00
2013-04-29 15:54:34 -07:00
2013-04-29 15:54:38 -07:00
2013-04-29 15:54:37 -07:00
2013-03-20 14:06:05 +10:30
2013-03-01 12:48:36 +01:00
2013-04-30 17:04:02 -07:00
11599ebac4