Chris Wilson
03e4e0a9e0
dma-buf/fence: Fix lock inversion within dma-fence-array
Ages ago Rob Clark noted,
"Currently with fence-array, we have a potential deadlock situation. If
we fence_add_callback() on an array-fence, the array-fence's lock is
acquired first, and in it's ->enable_signaling() callback, it will install
cbs on it's array-member fences, so the array-member's lock is acquired
second.
But in the signal path, the array-member's lock is acquired first, and
the array-fence's lock acquired second."
Rob proposed either extensive changes to dma-fence to unnest the
fence-array signaling, or to defer the signaling onto a workqueue. This
is a more refined version of the later, that should keep the latency
of the fence signaling to a minimum by using an irq-work, which is
executed asap.
Reported-by: Rob Clark <robdclark@gmail.com>
Suggested-by: Rob Clark <robdclark@gmail.com>
References: 1476635975-21981-1-git-send-email-robdclark@gmail.com
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Christian König <christian.koenig@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20171114162719.30958-1-chris@chris-wilson.co.uk
2017-11-21 22:37:05 +05:30
..
2017-08-27 15:47:43 -07:00
2017-09-08 18:26:48 -07:00
2017-09-06 19:56:49 +02:00
2017-09-13 11:04:14 -07:00
2017-08-01 16:46:44 +02:00
2017-08-28 16:40:18 +05:30
2017-08-23 09:16:35 +02:00
2017-09-09 14:18:40 -07:00
2017-09-25 10:58:22 +02:00
2017-10-13 16:30:58 +01:00
2017-09-09 14:48:21 -07:00
2017-09-06 14:45:08 -07:00
2017-10-26 00:47:27 -07:00
2017-10-04 10:22:55 +02:00
2017-09-01 15:34:30 +02:00
2017-08-28 17:11:28 +02:00
2017-09-04 12:54:42 +02:00
2017-09-29 13:36:06 +02:00
2017-08-30 15:17:45 -07:00
2017-08-31 09:15:21 +02:00
2017-09-10 20:35:46 -07:00
2017-08-30 17:31:51 +02:00
2017-08-09 18:52:07 +01:00
2017-08-15 12:50:48 +01:00
2017-08-02 12:43:20 -07:00
2017-08-29 20:33:57 -07:00
2017-10-19 22:13:40 -04:00
2017-09-10 20:40:00 -07:00
2017-09-11 22:01:44 -07:00
2017-08-31 18:08:47 +02:00
2017-08-07 14:28:51 +02:00
2017-09-05 12:50:00 -07:00
2017-09-01 16:35:50 -05:00
2017-08-04 13:34:14 -07:00
2017-08-29 08:33:24 -07:00
2017-08-10 12:29:02 +02:00
2017-09-22 16:16:41 -10:00
2017-10-03 17:54:25 -07:00
2017-09-07 11:59:42 -07:00
2017-10-03 17:54:25 -07:00
2017-09-08 18:26:49 -07:00
2017-09-08 18:26:48 -07:00
2017-08-23 12:49:55 -06:00
2017-08-08 14:58:03 -04:00
2017-08-18 08:36:58 -06:00
2017-09-25 08:56:05 -06:00
2017-08-16 15:34:13 -07:00
2017-08-23 22:38:08 -07:00
2017-10-09 15:18:04 +02:00
2017-09-07 21:11:05 -07:00
2017-10-13 16:18:33 -07:00
2017-09-01 14:57:15 -05:00
2017-08-04 09:27:41 +08:00
2017-08-18 08:24:21 -07:00
2017-09-07 11:59:42 -07:00
2017-08-31 18:35:45 -07:00
2017-09-14 17:37:26 -07:00
2017-09-04 12:21:28 -07:00
2017-09-04 12:21:28 -07:00
2017-08-29 15:14:38 +02:00
2017-08-28 17:35:43 +02:00
2017-08-30 14:40:40 +02:00
2017-09-04 00:05:22 +02:00
2017-09-25 22:11:44 +02:00
2017-09-04 00:06:02 +02:00
2017-09-08 18:26:51 -07:00
2017-09-07 11:45:21 +02:00
2017-09-14 13:43:16 -07:00
2017-09-05 12:53:11 +02:00
2017-08-28 10:22:27 +09:00
2017-09-11 11:00:55 -04:00
2017-10-03 08:57:07 -07:00
2017-08-24 13:23:03 -07:00
2017-11-21 22:37:05 +05:30
2017-11-09 20:32:53 +02:00
2017-09-12 13:30:06 -07:00
2017-09-06 21:55:10 +05:30
2017-08-29 15:34:44 -06:00
2017-08-29 15:34:44 -06:00
2017-08-29 15:34:46 -06:00
2017-08-28 16:55:47 +02:00
2017-09-12 13:27:21 -07:00
2017-08-18 16:30:17 -07:00
2017-08-16 09:27:55 +09:00
2017-08-03 19:09:26 -07:00
2017-08-01 17:33:02 +02:00
2017-08-07 17:22:14 +02:00
2017-10-20 13:01:29 +01:00
2017-08-28 16:24:22 +02:00
2017-10-03 17:54:26 -07:00
2017-09-06 17:27:26 -07:00
2017-08-31 15:49:11 -04:00
2017-08-01 14:36:35 +02:00
2017-08-31 09:47:22 -06:00
2017-08-09 13:09:28 -06:00
2017-09-13 18:53:16 -07:00
2017-09-05 11:54:41 -07:00
2017-09-08 18:26:46 -07:00
2017-10-20 14:19:51 +02:00
2017-09-08 18:26:45 -07:00
2017-08-15 23:20:30 +10:00
2017-10-04 11:25:09 +02:00
2017-08-30 14:36:44 -07:00
2017-10-28 19:17:21 +09:00
2017-08-07 11:39:22 -07:00
2017-09-01 18:38:09 -07:00
2017-09-08 18:26:49 -07:00
2017-10-19 16:54:49 -07:00
2017-08-10 16:28:53 +02:00
2017-09-08 18:26:49 -07:00
2017-09-08 18:26:49 -07:00
2017-09-27 17:02:45 +02:00
2017-09-08 18:26:46 -07:00
2017-08-15 18:23:52 +02:00
2017-09-08 18:26:51 -07:00
2017-09-08 18:26:51 -07:00
2017-08-07 11:39:22 -07:00
2017-08-16 16:40:02 +02:00
2017-10-13 16:31:05 +01:00
2017-09-05 12:50:00 -07:00
2017-08-29 15:14:38 +02:00
2017-08-10 12:28:59 +02:00
2017-10-13 16:18:33 -07:00
2017-10-18 09:12:40 +01:00
2017-09-08 18:26:51 -07:00
2017-08-14 13:33:39 -07:00
2017-08-02 16:34:47 -07:00
2017-08-08 10:57:43 +02:00
2017-08-29 21:10:40 +02:00
2017-08-29 08:36:58 -07:00
2017-08-31 15:05:10 -07:00
2017-08-29 15:14:38 +02:00
2017-08-17 15:33:39 -04:00
2017-09-12 13:21:00 -07:00
2017-10-12 15:01:30 +02:00
2017-08-28 20:51:22 +02:00
2017-09-05 14:42:52 -07:00
2017-09-07 11:53:11 +02:00
2017-08-18 15:32:01 -07:00
2017-09-06 17:27:27 -07:00
2017-09-08 18:26:46 -07:00
2017-09-08 18:26:46 -07:00
2017-09-08 18:26:46 -07:00
2017-09-08 18:26:46 -07:00
2017-08-17 10:30:49 +02:00
2017-10-19 22:13:40 -04:00
2017-10-03 17:54:23 -07:00
2017-10-03 17:54:24 -07:00
2017-10-03 17:54:25 -07:00
2017-10-21 21:46:39 -04:00
2017-09-14 17:37:26 -07:00
2017-08-15 20:23:23 -07:00
2017-10-16 21:02:54 +01:00
2017-08-28 17:44:00 +02:00
2017-08-28 17:44:00 +02:00
2017-09-06 12:32:37 -04:00
2017-08-20 13:04:12 -04:00
2017-08-15 11:54:48 -04:00
2017-10-04 10:53:54 +02:00
2017-09-25 12:42:11 -06:00
2017-09-25 08:56:05 -06:00
2017-08-28 17:33:23 +02:00
2017-08-21 12:19:57 -05:00
2017-09-19 12:20:44 -05:00
2017-10-13 16:18:32 -07:00
2017-08-18 15:32:01 -07:00
2017-09-06 17:27:28 -07:00
2017-09-06 17:27:26 -07:00
2017-09-06 17:27:27 -07:00
2017-08-11 10:35:07 -07:00
2017-08-29 16:00:37 -05:00
2017-09-07 13:24:11 -05:00
2017-09-25 11:08:20 -05:00
2017-09-07 13:24:20 -05:00
2017-09-04 13:56:37 -07:00
2017-08-06 20:55:29 -07:00
2017-08-06 20:55:29 -07:00
2017-08-21 12:47:31 -07:00
2017-10-24 15:20:45 +02:00
2017-08-29 12:24:52 +02:00
2017-09-08 18:26:51 -07:00
2017-09-08 18:26:51 -07:00
2017-09-08 18:26:47 -07:00
2017-08-01 15:22:55 -07:00
2017-08-16 16:28:47 -07:00
2017-08-21 14:06:46 +02:00
2017-08-17 22:00:59 +02:00
2017-08-30 14:36:44 -07:00
2017-09-08 18:26:48 -07:00
2017-09-08 18:26:48 -07:00
2017-10-19 22:26:11 -04:00
2017-10-19 22:26:11 -04:00
2017-08-17 10:40:26 +02:00
2017-10-04 11:46:32 +01:00
2017-09-01 15:49:13 -07:00
2017-11-13 14:50:49 -05:00
2017-09-08 18:26:49 -07:00
2017-09-08 18:26:49 -07:00
2017-08-24 16:34:51 +02:00
2017-09-08 18:26:49 -07:00
2017-08-10 12:28:55 +02:00
2017-08-10 12:28:55 +02:00
2017-09-07 10:48:29 +01:00
2017-09-29 11:02:57 +02:00
2017-10-29 18:03:24 +09:00
2017-08-14 13:46:46 -07:00
2017-09-12 13:21:00 -07:00
2017-08-07 14:16:22 -07:00
2017-09-14 17:37:26 -07:00
2017-08-28 20:51:20 +02:00
2017-08-28 20:51:20 +02:00
2017-08-06 20:55:29 -07:00
2017-09-14 17:37:26 -07:00
2017-10-07 10:11:40 +01:00
2017-09-06 17:27:24 -07:00
2017-08-16 16:28:47 -07:00
2017-09-07 20:02:39 -07:00
2017-09-06 17:27:24 -07:00
2017-08-29 15:14:38 +02:00
2017-09-14 11:41:06 +02:00
2017-08-03 21:37:29 -07:00
2017-08-17 08:08:58 -07:00
2017-09-04 11:52:29 -07:00
2017-10-19 22:26:11 -04:00
2017-08-17 08:10:04 -07:00
2017-09-11 12:29:41 -04:00
2017-08-18 01:54:22 +02:00
2017-10-23 13:59:21 +02:00
2017-09-08 18:26:46 -07:00
2017-09-08 18:26:46 -07:00
2017-08-18 14:07:26 -03:00
2017-09-17 19:45:32 +02:00
2017-08-17 16:29:19 -07:00
2017-08-30 11:20:09 -07:00
2017-08-04 10:30:27 +02:00
2017-08-11 10:51:22 +08:00
2017-10-13 16:18:33 -07:00
2017-09-14 17:37:26 -07:00
2017-09-28 16:30:36 +02:00
2017-08-08 17:51:34 -07:00
2017-09-20 14:10:29 -07:00
2017-08-28 20:51:23 +02:00
2017-08-28 16:15:42 +02:00
2017-08-31 17:32:39 -04:00
2017-09-08 18:26:51 -07:00
2017-09-11 18:34:47 -07:00
2017-09-06 17:27:29 -07:00
2017-09-08 18:26:47 -07:00
2017-09-08 18:26:48 -07:00
2017-08-31 18:50:14 +02:00
2017-09-14 09:56:18 -07:00
2017-09-05 06:34:17 -07:00
2017-08-15 09:02:07 -07:00
2017-08-15 09:02:08 -07:00