Vincent Huang
996d585b07
Input: trackpoint - enable Synaptics trackpoints
...
Add Synaptics IDs in trackpoint_start_protocol() to mark them as valid.
Signed-off-by: Vincent Huang <vincent.huang@tw.synaptics.com >
Fixes: 6c77545af1 ("Input: trackpoint - add new trackpoint variant IDs")
Reviewed-by: Harry Cutts <hcutts@chromium.org >
Tested-by: Harry Cutts <hcutts@chromium.org >
Link: https://lore.kernel.org/r/20200924053013.1056953-1-vincent.huang@tw.synaptics.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-09-28 16:23:41 -07:00
Vincent Huang
6c77545af1
Input: trackpoint - add new trackpoint variant IDs
...
Add trackpoint variant IDs to allow supported control on Synaptics
trackpoints.
Signed-off-by: Vincent Huang <vincent.huang@tw.synaptics.com >
Link: https://lore.kernel.org/r/20200914120327.2592-1-vincent.huang@tw.synaptics.com
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-09-14 12:24:46 -07:00
Colin Ian King
ea38f06e02
Input: sentelic - fix error return when fsp_reg_write fails
...
Currently when the call to fsp_reg_write fails -EIO is not being returned
because the count is being returned instead of the return value in retval.
Fix this by returning the value in retval instead of count.
Addresses-Coverity: ("Unused value")
Fixes: fc69f4a6af ("Input: add new driver for Sentelic Finger Sensing Pad")
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Link: https://lore.kernel.org/r/20200603141218.131663-1-colin.king@canonical.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-08-06 17:33:43 -07:00
Colin Ian King
47fcd0f969
Input: alps - remove redundant assignment to variable ret
...
The variable ret is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Link: https://lore.kernel.org/r/20200603135742.130852-1-colin.king@canonical.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-08-06 17:33:41 -07:00
Jingle Wu
873a3a14a4
Input: elan_i2c - add ic type 0x15
...
The update firmware flow of ic type 0x15 is same with ic type 0x14.
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw >
Link: https://lore.kernel.org/r/20200730060526.12439-1-jingle.wu@emc.com.tw
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-29 23:34:36 -07:00
Xiongfeng Wang
4aec14de3a
Input: psmouse - add a newline when printing 'proto' by sysfs
...
When I cat parameter 'proto' by sysfs, it displays as follows. It's
better to add a newline for easy reading.
root@syzkaller:~# cat /sys/module/psmouse/parameters/proto
autoroot@syzkaller:~#
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com >
Link: https://lore.kernel.org/r/20200720073846.120724-1-wangxiongfeng2@huawei.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-21 22:33:27 -07:00
Dmitry Torokhov
a5c33d5f74
Merge branch 'for-linus' into next
...
Sync up with 'for-linus' branch to resolve conflict in Elan touchpad
driver.
2020-07-21 22:17:27 -07:00
Dmitry Torokhov
9b031c8650
Merge branch 'elan-i2c' into next
...
Bring in update to Elan touchpad driver to support newer touchpads with
higher resolution.
2020-07-21 19:02:33 -07:00
Jingle Wu
04d5ce620f
Input: elan_i2c - add support for high resolution reports
...
Newer controllers (identified as "pattern" version 2) send higher
resolution reports, with 16-bit X and Y coordinates (previous generations
used 12-bit values). These new high resolution reports use report ID of
0x60.
SMbus controllers use the same buffer size for both the new and old
reports, and because of that high resolution reports no longer carry
area of contact data with SMbus.
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw >
Link: https://lore.kernel.org/r/20200710054116.5529-1-jingle.wu@emc.com.tw
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-21 10:11:18 -07:00
Dmitry Torokhov
3d712af637
Input: elan_i2c - do not constantly re-query pattern ID
...
We do not need to constantly re-query pattern ID, we can instead query it
once and then pass to methods that need it.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-20 17:35:31 -07:00
Jingle Wu
8d73ec7411
Input: elan_i2c - add firmware update info for ICs 0x11, 0x13, 0x14
...
This adds firmware size and page sizes for ic types 0x11, 0x13 and 0x14.
IC 0x14 uses 512-byte firmware page size.
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw >.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-17 17:36:02 -07:00
Jingle Wu
bfd9b92bc8
Input: elan_i2c - handle firmware updated on newer ICs
...
Newer ICs with IC type value starting with 0x0D and newer bootloader code
use 128-byte firmware pages. Their bootloader also needs to be switched to
proper mode before executing firmware update.
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-17 17:36:01 -07:00
Jingle Wu
059d6c2de6
Input: elan_i2c - add support for different firmware page sizes
...
Prepare driver for devices that use different sizes of firmware pages.
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-17 17:36:00 -07:00
Jingle Wu
df10cc8db1
Input: elan_i2c - fix detecting IAP version on older controllers
...
Older controllers in bootloader mode need a different command to retrieve
the IAP version.
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw >
Link: https://lore.kernel.org/r/20200714105641.15151-1-jingle.wu@emc.com.tw
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-17 17:36:00 -07:00
Jingle Wu
40d8aa9713
Input: elan_i2c - handle devices with patterns above 1
...
Extend fetching and parsing parameters of the controllers to devices with
"patterns" above 1 (which currently should be handled in the same fashion
as devices with pattern 1).
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-17 17:35:59 -07:00
Jingle Wu
fc7c882aa9
Input: elan_i2c - make fetching IC type of older controllers more robust
...
On older controllers IC type is reported in the 2nd byte of
ETP_I2C_OSM_VERSION_CMD, however if controller's firmware is not flashed
correctly it may return incorrect data. Fortunately there is also
ETP_I2C_IAP_VERSION_P0_CMD command that can be used when controller in
either normal or IAP mode, and which is guaranteed to return accurate data,
so let's use it.
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-17 17:35:58 -07:00
Jingle Wu
77da21c5d3
Input: elan_i2c - handle firmware not implementing "get pattern" command
...
Not all versions of firmware implement "get pattern" command. When
encountering those assume that the controllers use older pattern.
Signed-off-by: Jingle Wu <jingle.wu@emc.com.tw >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-17 17:35:58 -07:00
Gustavo A. R. Silva
6f49c4f5b9
Input: Use fallthrough pseudo-keyword
...
Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org >
Link: https://lore.kernel.org/r/20200707180857.GA30600@embeddedor
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-07 11:25:54 -07:00
Colin Ian King
05b8465025
Input: elantech - remove redundant assignments to variable error
...
The variable error is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com >
Link: https://lore.kernel.org/r/20200603140431.131347-1-colin.king@canonical.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-06 17:53:33 -07:00
Derek Basehore
966334dfc4
Input: elan_i2c - only increment wakeup count on touch
...
This moves the wakeup increment for elan devices to the touch report.
This prevents the drivers from incorrectly reporting a wakeup when the
resume callback resets then device, which causes an interrupt to
occur.
Signed-off-by: Derek Basehore <dbasehore@chromium.org >
Link: https://lore.kernel.org/r/20200706235046.1984283-1-dbasehore@chromium.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-06 17:41:41 -07:00
Ilya Katsnelson
dcb00fc799
Input: synaptics - enable InterTouch for ThinkPad X1E 1st gen
...
Tested on my own laptop, touchpad feels slightly more responsive with
this on, though it might just be placebo.
Signed-off-by: Ilya Katsnelson <me@0upti.me >
Reviewed-by: Lyude Paul <lyude@redhat.com >
Link: https://lore.kernel.org/r/20200703143457.132373-1-me@0upti.me
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-06 17:41:40 -07:00
Dmitry Torokhov
8dd06ef34b
Merge branch 'next' into for-linus
...
Prepare input updates for 5.8 merge window.
2020-06-06 10:45:37 -07:00
Linus Torvalds
d16eea2fa5
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
...
Pull input fixes from Dmitry Torokhov:
"Just a few random driver fixups"
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input:
Input: synaptics - add a second working PNP_ID for Lenovo T470s
Input: applespi - replace zero-length array with flexible-array
Input: axp20x-pek - always register interrupt handlers
Input: lm8333 - update contact email
Input: synaptics-rmi4 - fix error return code in rmi_driver_probe()
Input: synaptics-rmi4 - really fix attn_data use-after-free
Input: i8042 - add ThinkPad S230u to i8042 reset list
Revert "Input: i8042 - add ThinkPad S230u to i8042 nomux list"
Input: dlink-dir685-touchkeys - fix a typo in driver name
Input: xpad - add custom init packet for Xbox One S controllers
Input: evdev - call input_flush_device() on release(), not flush()
Input: i8042 - add ThinkPad S230u to i8042 nomux list
Input: usbtouchscreen - add support for BonXeon TP
Input: cros_ec_keyb - use cros_ec_cmd_xfer_status helper
Input: mms114 - fix handling of mms345l
Input: elants_i2c - support palm detection
2020-05-28 12:41:11 -07:00
Dennis Kadioglu
642aa86eaf
Input: synaptics - add a second working PNP_ID for Lenovo T470s
...
The Lenovo Thinkpad T470s I own has a different touchpad with "LEN007a"
instead of the already included PNP ID "LEN006c". However, my touchpad
seems to work well without any problems using RMI. So this patch adds the
other PNP ID.
Signed-off-by: Dennis Kadioglu <denk@eclipso.email >
Link: https://lore.kernel.org/r/ff770543cd53ae818363c0fe86477965@mail.eclipso.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-05-26 23:11:28 -07:00
Jiada Wang
5fc70e350e
Input: introduce input_mt_report_slot_inactive()
...
input_mt_report_slot_state() ignores "tool" argument when the slot is
closed, which has caused a bit of confusion. Let's introduce
input_mt_report_slot_inactive() to report inactive slot state.
Suggested-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
Signed-off-by: Jiada Wang <jiada_wang@mentor.com >
Link: https://lore.kernel.org/r/20200508055656.96389-2-jiada_wang@mentor.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-05-12 13:18:26 -07:00