Arnaud Pouliquen
9955548919
remoteproc: Remove vdev_to_rvdev and vdev_to_rproc from remoteproc API
...
These both functions are only used by the remoteproc_virtio.
There is no reason to expose them in the API.
Move the functions in remoteproc_virtio.c
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com >
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Link: https://lore.kernel.org/r/20211001101234.4247-4-arnaud.pouliquen@foss.st.com
2021-10-15 09:49:55 -05:00
Dong Aisheng
147b589c5f
remoteproc: fix kernel doc for struct rproc_ops
...
The load_rsc_table was removed since the
commit c1d35c1ab4b1a17513a2b1a17513a2aisheng.dong@nxp.com >
Link: https://lore.kernel.org/r/20210706142156.952794-2-aisheng.dong@nxp.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2021-07-28 14:57:31 -05:00
Suman Anna
f286743400
remoteproc: Fix various kernel-doc warnings
...
Fix all the kernel-doc warnings in various remoteproc core files.
Some of them just needed a formatting cleanup change, while others
needed the Return statement to be added, or documenting the missed
structure elements.
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Signed-off-by: Suman Anna <s-anna@ti.com >
Link: https://lore.kernel.org/r/20210519180304.23563-3-s-anna@ti.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2021-05-27 22:07:43 -05:00
Mathieu Poirier
9dc9507f18
remoteproc: Properly deal with the resource table when detaching
...
If it is possible to detach the remote processor, keep an untouched
copy of the resource table. That way we can start from the same
resource table without having to worry about original values or what
elements the startup code has changed when re-attaching to the remote
processor.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Link: https://lore.kernel.org/r/20210312162453.1234145-12-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2021-03-18 08:00:51 -05:00
Mathieu Poirier
d3962a3978
remoteproc: Introduce function rproc_detach()
...
Introduce function rproc_detach() to enable the remoteproc
core to release the resources associated with a remote processor
without stopping its operation.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Link: https://lore.kernel.org/r/20210312162453.1234145-11-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2021-03-18 07:55:47 -05:00
Mathieu Poirier
7f3bd0c019
remoteproc: Add new detach() remoteproc operation
...
Add an new detach() operation in order to support scenarios where
the remoteproc core is going away but the remote processor is
kept operating. This could be the case when the system is
rebooted or when the platform driver is removed.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Reviewed-by: Peng Fan <peng.fan@nxp.com >
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Link: https://lore.kernel.org/r/20210312162453.1234145-9-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2021-03-18 07:55:46 -05:00
Mathieu Poirier
1a631382be
remoteproc: Add new get_loaded_rsc_table() to rproc_ops
...
Add a new get_loaded_rsc_table() operation in order to support
scenarios where the remoteproc core has booted a remote processor
and detaches from it. When re-attaching to the remote processor,
the core needs to know where the resource table has been placed
in memory.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Link: https://lore.kernel.org/r/20210312162453.1234145-6-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2021-03-18 07:54:53 -05:00
Mathieu Poirier
76f4c87587
remoteproc: Properly represent the attached state
...
There is a need to know when a remote processor has been attached
to rather than booted by the remoteproc core. In order to avoid
manipulating two variables, i.e rproc::autonomous and
rproc::state, get rid of the former and simply use the newly
introduced RPROC_ATTACHED state.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Reviewed-by: Peng Fan <peng.fan@nxp.com >
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Link: https://lore.kernel.org/r/20210312162453.1234145-5-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2021-03-18 07:54:52 -05:00
Mathieu Poirier
4196d18903
remoteproc: Add new RPROC_ATTACHED state
...
Add a new RPROC_ATTACHED state to take into account scenarios
where the remoteproc core needs to attach to a remote processor
that is booted by another entity.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Reviewed-by: Peng Fan <peng.fan@nxp.com >
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Link: https://lore.kernel.org/r/20210312162453.1234145-4-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2021-03-18 07:54:52 -05:00
Peng Fan
40df0a91b2
remoteproc: add is_iomem to da_to_va
...
Introduce an extra parameter is_iomem to da_to_va, then the caller
could take the memory as normal memory or io mapped memory.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Reported-by: kernel test robot <lkp@intel.com >
Signed-off-by: Peng Fan <peng.fan@nxp.com >
Link: https://lore.kernel.org/r/1615029865-23312-5-git-send-email-peng.fan@oss.nxp.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2021-03-11 12:02:41 -06:00
Peng Fan
2cfc056ef2
remoteproc: introduce is_iomem to rproc_mem_entry
...
Introduce is_iomem to indicate this piece memory is iomem or not.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Signed-off-by: Peng Fan <peng.fan@nxp.com >
Link: https://lore.kernel.org/r/1615029865-23312-4-git-send-email-peng.fan@oss.nxp.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2021-03-11 12:02:40 -06:00
Siddharth Gupta
abc72b6460
remoteproc: coredump: Add minidump functionality
...
This change adds a new kind of core dump mechanism which instead of dumping
entire program segments of the firmware, dumps sections of the remoteproc
memory which are sufficient to allow debugging the firmware. This function
thus uses section headers instead of program headers during creation of the
core dump elf.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Co-developed-by: Rishabh Bhatnagar <rishabhb@codeaurora.org >
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org >
Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org >
Link: https://lore.kernel.org/r/1605819935-10726-3-git-send-email-sidgup@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-12-10 13:14:37 -06:00
Siddharth Gupta
adf60a870e
remoteproc: core: Add ops to enable custom coredump functionality
...
Each remoteproc might have different requirements for coredumps and might
want to choose the type of dumps it wants to collect. This change allows
remoteproc drivers to specify their own custom dump function to be executed
in place of rproc_coredump. If the coredump op is not specified by the
remoteproc driver it will be set to rproc_coredump by default.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org >
Link: https://lore.kernel.org/r/1605819935-10726-2-git-send-email-sidgup@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-12-10 13:14:04 -06:00
Suman Anna
4c1ad562d3
remoteproc: Add a rproc_set_firmware() API
...
A new API, rproc_set_firmware() is added to allow the remoteproc platform
drivers and remoteproc client drivers to be able to configure a custom
firmware name that is different from the default name used during
remoteproc registration. This function is being introduced to provide
a kernel-level equivalent of the current sysfs interface to remoteproc
client drivers, and can only change firmwares when the remoteproc is
offline. This allows some remoteproc drivers to choose different firmwares
at runtime based on the functionality the remote processor is providing.
The TI PRU Ethernet driver will be an example of such usage as it
requires to use different firmwares for different supported protocols.
Also, update the firmware_store() function used by the sysfs interface
to reuse this function to avoid code duplication.
Reviewed-by: Rishabh Bhatnagar <rishabhb@codeaurora.org >
Signed-off-by: Suman Anna <s-anna@ti.com >
Link: https://lore.kernel.org/r/20201121032042.6195-1-s-anna@ti.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-11-25 23:05:24 -06:00
Rishabh Bhatnagar
bf41a0910c
remoteproc: Change default dump configuration to "disabled"
...
Currently "default" configuration option means coredumps are
enabled. To avoid confusion rename the "default" configuration
option to "enabled" and disable collection of dumps by default
as doing so makes sense for production devices.
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org >
Link: https://lore.kernel.org/r/1601662144-5964-2-git-send-email-rishabhb@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-10-13 19:20:54 -05:00
Siddharth Gupta
4476770881
remoteproc: Add remoteproc character device interface
...
Add the character device interface into remoteproc framework.
This interface can be used in order to boot/shutdown remote
subsystems and provides a basic ioctl based interface to implement
supplementary functionality. An ioctl call is implemented to enable
the shutdown on release feature which will allow remote processors to
be shutdown when the controlling userspace application crashes or hangs.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org >
Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org >
Link: https://lore.kernel.org/r/1596044401-22083-2-git-send-email-sidgup@codeaurora.org
[bjorn: s/int32_t/s32/ per checkpatch]
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-08-04 20:16:37 -07:00
Rishabh Bhatnagar
c97319881c
remoteproc: Add inline coredump functionality
...
The current coredump implementation uses vmalloc area to copy
all the segments. But this might put strain on low memory targets
as the firmware size sometimes is in tens of MBs. The situation
becomes worse if there are multiple remote processors undergoing
recovery at the same time. This patch adds inline coredump
functionality that avoids extra memory usage. This requires
recovery to be halted until data is read by userspace and free
function is called.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Reviewed-by: Sibi Sankar <sibis@codeaurora.org >
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org >
Tested-by: Sibi Sankar <sibis@codeaurora.org >
Link: https://lore.kernel.org/r/1594938035-7327-5-git-send-email-rishabhb@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-07-21 14:03:57 -07:00
Rishabh Bhatnagar
76abf9cea6
remoteproc: Pass size and offset as arguments to segment dump function
...
Change the segment dump API signature to include size and offset
arguments. Refactor the qcom_q6v5_mss driver to use these
arguments while copying the segment. Doing this lays the ground
work for "inline" coredump functionality being added in the next
patch.
Tested-by: Sibi Sankar <sibis@codeaurora.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Reviewed-by: Sibi Sankar <sibis@codeaurora.org >
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org >
Link: https://lore.kernel.org/r/1594938035-7327-4-git-send-email-rishabhb@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-07-21 14:03:37 -07:00
Mathieu Poirier
d9473cbfb0
remoteproc: Make function rproc_resource_cleanup() public
...
Make function rproc_resource_cleanup() public so that it can be
used by platform drivers when allocating resources to be used by
a detached remote processor.
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Link: https://lore.kernel.org/r/20200714200445.1427257-8-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-07-17 17:34:43 -07:00
Mathieu Poirier
4a4dca1941
remoteproc: Properly handle firmware name when attaching
...
This patch prevents the firmware image name from being displayed when
the remoteproc core is attaching to a remote processor. This is needed
needed since there is no guarantee about the nature of the firmware
image that is loaded by the external entity.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Tested-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Link: https://lore.kernel.org/r/20200714195035.1426873-10-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-07-16 23:06:15 -07:00
Mathieu Poirier
a6a4f28575
remoteproc: Add new attach() remoteproc operation
...
Add an new attach() operation in order to properly deal with
scenarios where the remoteproc core needs to attach to a
remote processor that has been booted by another entity.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Tested-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Link: https://lore.kernel.org/r/20200714195035.1426873-3-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-07-16 23:06:07 -07:00
Mathieu Poirier
e2e5c55eed
remoteproc: Add new RPROC_DETACHED state
...
Add a new RPROC_DETACHED state to take into account scenarios
where the remoteproc core needs to attach to a remote processor
that is booted by another entity.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Tested-by: Arnaud Pouliquen <arnaud.pouliquen@st.com >
Link: https://lore.kernel.org/r/20200714195035.1426873-2-mathieu.poirier@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-07-16 23:06:06 -07:00
Gustavo A. R. Silva
529798bae7
remoteproc: Replace zero-length array with flexible-array
...
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293gustavoars@kernel.org >
Link: https://lore.kernel.org/r/20200507191943.GA16033@embeddedor
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-05-12 15:00:37 -07:00
Loic Pallardy
33467ac3c8
remoteproc: Add prepare and unprepare ops
...
On some SoC architecture, it is needed to enable HW like
clock, bus, regulator, memory region... before loading
co-processor firmware.
This patch introduces prepare and unprepare ops to execute
platform specific function before firmware loading and after
stop execution.
Signed-off-by: Loic Pallardy <loic.pallardy@st.com >
Signed-off-by: Suman Anna <s-anna@ti.com >
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org >
Link: https://lore.kernel.org/r/20200417002036.24359-2-s-anna@ti.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-04-22 22:18:06 -07:00
Paul Cercueil
305ac5a766
remoteproc: Add device-managed variants of rproc_alloc/rproc_add
...
Add API functions devm_rproc_alloc() and devm_rproc_add(), which behave
like rproc_alloc() and rproc_add() respectively, but register their
respective cleanup function to be called on driver detach.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org >
Signed-off-by: Paul Cercueil <paul@crapouillou.net >
Link: https://lore.kernel.org/r/20200417170040.174319-2-paul@crapouillou.net
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org >
2020-04-20 19:54:29 -07:00
