Dmitry Torokhov
5f8f8574c7
Merge branch 'next' into for-linus
...
Prepare input updates for 6.1 merge window.
2022-10-09 22:30:23 -07:00
Mark Pearson
2fd003ee8a
Input: synaptics - disable Intertouch for Lenovo T14 and P14s AMD G1
...
Since intertouch was enabled for the T14 and P14s AMD G1 laptops there
have been a number of reports of touchpads not working well.
Debugging this with Synaptics they noted that intertouch should not be
enabled as SMBUS host notify is not available on these laptops.
Reverting the previous commit (e4ce4d3a93 )
to restore functionality back to what it was.
Note - we are working with Synaptics to see if there is a better
solution, but nothing is confirmed as yet.
Signed-off-by: Mark Pearson <markpearson@lenovo.com >
Link: https://lore.kernel.org/r/20220920193936.8709-1-markpearson@lenovo.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2022-09-24 22:18:13 -07:00
Lyude Paul
7984b43542
Input: synaptics - enable InterTouch for the ThinkPad P1 G3
...
Noticed this while trying to debug some unrelated issues: this laptop has
the ability to use rmi4 but doesn't by default. So let's fix that.
Tested locally, including mouse buttons, on my ThinkPad P1 G3. This might
also enable the X1 Extreme G3, but I don't have such a system to test
locally (presumably Mark can chime in if that's the case).
Signed-off-by: Lyude Paul <lyude@redhat.com >
Link: https://lore.kernel.org/r/20220909202127.141761-1-lyude@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2022-09-14 05:35:16 -07:00
Wolfram Sang
a9f08ad7ad
Input: move from strlcpy with unused retval to strscpy
...
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com >
Link: https://lore.kernel.org/r/20220818210022.6865-1-wsa+renesas@sang-engineering.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2022-08-18 15:44:08 -07:00
Matthew Haughton
e4ce4d3a93
Input: synaptics - enable InterTouch on ThinkPad T14/P14s Gen 1 AMD
...
Confirmed LEN2064 on my P14s works with psmouse.synaptics_intertouch=1
By all accounts T14 and P14s are the same hardware which only differ by
model identifier.
Signed-off-by: Matthew Haughton <snafu109@gmail.com >
Link: https://lore.kernel.org/r/20220318113949.32722-1-snafu109@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2022-03-20 21:59:45 -07:00
Lee Jones
a1ba9c2986
Input: synaptics - replace NOOP with suitable commentary
...
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Signed-off-by: Lee Jones <lee.jones@linaro.org >
Link: https://lore.kernel.org/r/20210114152323.2382283-2-lee.jones@linaro.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2021-01-19 19:03:11 -08:00
Lee Jones
58e5183ac8
Input: synaptics - demote non-conformant kernel-doc header
...
Fixes the following W=1 kernel build warning(s):
drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'psmouse' not described in 'synaptics_setup_intertouch'
drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'info' not described in 'synaptics_setup_intertouch'
drivers/input/mouse/synaptics.c:1781: warning: Function parameter or member 'leave_breadcrumbs' not described in 'synaptics_setup_intertouch'
Signed-off-by: Lee Jones <lee.jones@linaro.org >
Link: https://lore.kernel.org/r/20201112110204.2083435-13-lee.jones@linaro.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-11-19 19:18:48 -08:00
Hans de Goede
470d154a62
Input: synaptics - enable InterTouch for ThinkPad T14 Gen 1
...
With the new RMI4 F3A support, we're now able to enable full RMI4
support for this model.
Signed-off-by: Hans de Goede <hdegoede@redhat.com >
Link: https://lore.kernel.org/r/20201005114919.371592-1-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-10-05 10:13:55 -07:00
Jason A. Donenfeld
127e4a1bc1
Input: synaptics - enable InterTouch for ThinkPad P1/X1E gen 2
...
With the new RMI4 F3A support, we're now able to enable full RMI4
support for this model. We also tidy up the comments a bit, as the X1E
is essentially the same computer as the P1.
Acked-by: Lyude Paul <lyude@redhat.com >
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com >
Link: https://lore.kernel.org/r/20200930225046.173190-3-Jason@zx2c4.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-10-04 19:51:46 -07:00
Vincent Huang
261bfb3328
Input: synaptics-rmi4 - rename f30_data to gpio_data
...
f30_data in rmi_device_platform_data could be also referenced by RMI
function 3A, so rename it and the structure name to avoid confusion.
Signed-off-by: Vincent Huang <vincent.huang@tw.synaptics.com >
Reviewed-by: Hans de Goede <hdegoede@redhat.com >
Tested-by: Hans de Goede <hdegoede@redhat.com >
Reviewed-by: Andrew Duggan <aduggan@synaptics.com >
Link: https://lore.kernel.org/r/20200930094147.635556-2-vincent.huang@tw.synaptics.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-10-04 19:51:43 -07:00
Ilya Katsnelson
dcb00fc799
Input: synaptics - enable InterTouch for ThinkPad X1E 1st gen
...
Tested on my own laptop, touchpad feels slightly more responsive with
this on, though it might just be placebo.
Signed-off-by: Ilya Katsnelson <me@0upti.me >
Reviewed-by: Lyude Paul <lyude@redhat.com >
Link: https://lore.kernel.org/r/20200703143457.132373-1-me@0upti.me
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-07-06 17:41:40 -07:00
Dennis Kadioglu
642aa86eaf
Input: synaptics - add a second working PNP_ID for Lenovo T470s
...
The Lenovo Thinkpad T470s I own has a different touchpad with "LEN007a"
instead of the already included PNP ID "LEN006c". However, my touchpad
seems to work well without any problems using RMI. So this patch adds the
other PNP ID.
Signed-off-by: Dennis Kadioglu <denk@eclipso.email >
Link: https://lore.kernel.org/r/ff770543cd53ae818363c0fe86477965@mail.eclipso.de
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-05-26 23:11:28 -07:00
Yussuf Khalil
1369d0abe4
Input: synaptics - enable RMI on HP Envy 13-ad105ng
...
This laptop (and perhaps other variants of the same model) reports an
SMBus-capable Synaptics touchpad. Everything (including suspend and
resume) works fine when RMI is enabled via the kernel command line, so
let's add it to the whitelist.
Signed-off-by: Yussuf Khalil <dev@pp3345.net >
Link: https://lore.kernel.org/r/20200307213508.267187-1-dev@pp3345.net
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-03-24 15:23:52 -07:00
Benjamin Tissoires
5179a9dfa9
Input: synaptics - remove the LEN0049 dmi id from topbuttonpad list
...
The Yoga 11e is using LEN0049, but it doesn't have a trackstick.
Thus, there is no need to create a software top buttons row.
However, it seems that the device works under SMBus, so keep it as part
of the smbus_pnp_ids.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com >
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20200115013023.9710-1-benjamin.tissoires@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-02-13 17:09:49 -08:00
Gaurav Agrawal
b8a3d819f8
Input: synaptics - enable SMBus on ThinkPad L470
...
Add touchpad LEN2044 to the list, as it is capable of working with
psmouse.synaptics_intertouch=1
Signed-off-by: Gaurav Agrawal <agrawalgaurav@gnome.org >
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/CADdtggVzVJq5gGNmFhKSz2MBwjTpdN5YVOdr4D3Hkkv=KZRc9g@mail.gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-02-13 17:09:49 -08:00
Lyude Paul
bf50239135
Input: synaptics - switch T470s to RMI4 by default
...
This supports RMI4 and everything seems to work, including the touchpad
buttons. So, let's enable this by default.
Signed-off-by: Lyude Paul <lyude@redhat.com >
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20200204194322.112638-1-lyude@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2020-02-13 17:09:48 -08:00
Hans Verkuil
fc1156f373
Input: synaptics - switch another X1 Carbon 6 to RMI/SMbus
...
Some Lenovo X1 Carbon Gen 6 laptops report LEN0091. Add this
to the smbus_pnp_ids list.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl >
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20191119105118.54285-2-hverkuil-cisco@xs4all.nl
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2019-11-22 16:21:51 -08:00
Dmitry Torokhov
4aa31b4b61
Merge tag 'v5.3-rc4' into next
...
Sync up with mainline to bring in device_property_count_u32 andother
newer APIs.
2019-08-11 23:24:46 -07:00
Christophe JAILLET
26332247fb
Input: synaptics - fix a typo
...
This should be 'synaptics', not 'synpatics'
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2019-08-09 09:46:30 -07:00
Dmitry Torokhov
25f8c834e2
Input: synaptics - enable RMI mode for HP Spectre X360
...
The 2016 kabylake HP Spectre X360 (model number 13-w013dx) works much better
with psmouse.synaptics_intertouch=1 kernel parameter, so let's enable RMI4
mode automatically.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204115
Reported-by: Nate Graham <pointedstick@zoho.com >
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2019-07-25 11:24:06 +03:00
Dmitry Torokhov
c39f2d9db0
Merge branch 'next' into for-linus
...
Prepare second round of input updates for 5.3 merge window.
2019-07-20 07:07:56 +03:00
Dmitry Torokhov
ecb41832bd
Merge tag 'v5.2' into next
...
Sync up with mainline to resolve conflicts in iforce driver.
2019-07-15 09:42:32 -07:00
Joe Perches
d38b6cf50a
Input: synaptics - fix misuse of strlcpy
...
Probable cut&paste typo - use the correct field size.
Signed-off-by: Joe Perches <joe@perches.com >
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2019-07-15 09:40:53 -07:00
Nick Black
1976d7d200
Input: synaptics - whitelist Lenovo T580 SMBus intertouch
...
Adds the Lenovo T580 to the SMBus intertouch list for Synaptics
touchpads. I've tested with this for a week now, and it seems a great
improvement. It's also nice to have the complaint gone from dmesg.
Signed-off-by: Nick Black <dankamongmen@gmail.com >
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2019-07-11 23:56:01 -07:00
Cole Rogers
abbe3acd7d
Input: synaptics - enable SMBUS on T480 thinkpad trackpad
...
Thinkpad t480 laptops had some touchpad features disabled, resulting in the
loss of pinch to activities in GNOME, on wayland, and other touch gestures
being slower. This patch adds the touchpad of the t480 to the smbus_pnp_ids
whitelist to enable the extra features. In my testing this does not break
suspend (on fedora, with wayland, and GNOME, using the rc-6 kernel), while
also fixing the feature on a T480.
Signed-off-by: Cole Rogers <colerogers@disroot.org >
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com >
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com >
2019-07-01 01:22:21 -07:00