From ac7067b4d9e4ca8a9b58d6de277f28a85c7e83f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sosth=C3=A8ne=20Gu=C3=A9don?= <sosthene@nitrokey.com>
Date: Tue, 11 Feb 2025 10:02:03 +0100
Subject: [PATCH] Remove default false for mutual authenticate management
 config

---
 tests/command_response.ron | 34 ++++++++++++++++++++++++----------
 tests/command_response.rs  |  1 -
 2 files changed, 24 insertions(+), 11 deletions(-)

diff --git a/tests/command_response.ron b/tests/command_response.ron
index c75b11f..8bc116f 100644
--- a/tests/command_response.ron
+++ b/tests/command_response.ron
@@ -21,6 +21,7 @@
                     algorithm: Tdes,
                     key: "0102030405060708 0102030405060708 FFFFFFFFFFFFFFFF"
                 ),
+                mutual: false,
                 expected_status_response: IncorrectDataParameter,
             ),
             AuthenticateManagement(
@@ -28,6 +29,7 @@
                     algorithm: Aes256,
                     key: "0102030405060708 0102030405060708 0102030405060708 0102030405060708"
                 ),
+                mutual: false,
                 expected_status_challenge: IncorrectP1OrP2Parameter,
             ),
             // Admin commands then must fail
@@ -47,7 +49,8 @@
                 key: (
                     algorithm: Tdes,
                     key: "0102030405060708 0102030405060708 0102030405060708"
-                )
+                ),
+                mutual: false,
             )
         ]
     ),
@@ -58,7 +61,8 @@
                 key: (
                     algorithm: Tdes,
                     key: "0102030405060708 0102030405060708 0102030405060708"
-                )
+                ),
+                mutual: false,
             ),
             SetManagementKey(
                 key: (
@@ -70,7 +74,8 @@
                 key: (
                     algorithm: Aes256,
                     key: "0102030405060708 0102030405060708 0102030405060708 0102030405060708"
-                )
+                ),
+                mutual: false,
             )
         ]
     ),
@@ -81,7 +86,8 @@
                 key: (
                     algorithm: Tdes,
                     key: "0102030405060708 0102030405060708 0102030405060708"
-                )
+                ),
+                mutual: false,
             ),
             SetManagementKey(
                 key: (
@@ -94,6 +100,7 @@
                     algorithm: Aes256,
                     key: "0102030405060708 0102030405060708 0102030405060708 FFFFFFFFFFFFFFFF"
                 ),
+                mutual: false,
                 expected_status_response: IncorrectDataParameter,
             )
         ]
@@ -113,6 +120,7 @@
                     algorithm: Aes256,
                     key: "0102030405060708 0102030405060708 0102030405060708 0102030405060708"
                 ),
+                mutual: false,
                 expected_status_challenge: IncorrectP1OrP2Parameter,
             )
         ]
@@ -236,7 +244,8 @@
                 key: (
                     algorithm: Tdes,
                     key: "0102030405060708 0102030405060708 0102030405060708"
-                )
+                ),
+                mutual: false,
             ),
             IoData(
                 input: "00 47 009A 05
@@ -269,7 +278,8 @@
                 key: (
                     algorithm: Tdes,
                     key: "0102030405060708 0102030405060708 0102030405060708"
-                )
+                ),
+                mutual: false,
             ),
             PutData(
                 input: "5C 03 5FC102 53 10 000102030405060708090A0B0C0D0E0F",
@@ -311,7 +321,8 @@
                 key: (
                     algorithm: Tdes,
                     key: "0102030405060708 0102030405060708 0102030405060708"
-                )
+                ),
+                mutual: false,
             ),
             PutData(
                 input: "5C 03 5FC102 53 3b 3019d4e739d821086c1084210d8360d8210842108421804210c3f3341000112233445566778899aabbccddeeff350839393939313233313e00fe00",
@@ -334,7 +345,8 @@
                 key: (
                     algorithm: Tdes,
                     key: "0102030405060708 0102030405060708 0102030405060708"
-                )
+                ),
+                mutual: false,
             ),
             PutData(
                 input: "5C 03 5FC102 53 3b 3019d4e739d821086c1084210d8360d8210842108421804210c3f33410B0BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB30839393939313233313e00fe00",
@@ -389,7 +401,8 @@
                 key: (
                     algorithm: Tdes,
                     key: "0102030405060708 0102030405060708 0102030405060708"
-                )
+                ),
+                mutual: false,
             ),
             ImportRsaKey(
                 p: "f39c20ab767b26d5a086b6b4d3bf354d1e08fed0d6d473f70ca89240ddd6f4727c16d0085879d24474d200858a13d17fe388237a5c0477ceb43b0a38111d062378fdec70acb10d0c1970b23ed14f920e8d235d67df7d09006b1d38c58d6ee68df046a00f67e190c466660a27775bc595c914d82959a0d327725311e9291f7829",
@@ -424,7 +437,8 @@
                 key: (
                     algorithm: Tdes,
                     key: "0102030405060708 0102030405060708 0102030405060708"
-                )
+                ),
+                mutual: false,
             ),
             GetData(
                 input: "5C 03 5FC108",
diff --git a/tests/command_response.rs b/tests/command_response.rs
index de45f8b..cd7abb4 100644
--- a/tests/command_response.rs
+++ b/tests/command_response.rs
@@ -294,7 +294,6 @@ enum IoCmd {
     },
     AuthenticateManagement {
         key: ManagementKey,
-        #[serde(default)]
         mutual: bool,
         #[serde(default)]
         expected_status_challenge: Status,