From cc35c79ac583e2f2bee85885397d46bfb05f2e93 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sosth=C3=A8ne=20Gu=C3=A9don?= <sosthene@nitrokey.com>
Date: Thu, 22 Jun 2023 17:31:27 +0200
Subject: [PATCH] Make parameters public again

---
 src/command.rs | 28 ++++++----------------------
 1 file changed, 6 insertions(+), 22 deletions(-)

diff --git a/src/command.rs b/src/command.rs
index af1b1d9..ee9342a 100644
--- a/src/command.rs
+++ b/src/command.rs
@@ -15,8 +15,8 @@ pub struct Command<const S: usize> {
     class: class::Class,
     instruction: Instruction,
 
-    p1: u8,
-    p2: u8,
+    pub p1: u8,
+    pub p2: u8,
 
     /// The main reason this is modeled as Bytes and not
     /// a fixed array is for serde purposes.
@@ -63,14 +63,6 @@ impl<const S: usize> Command<S> {
         }
     }
 
-    pub fn p1(&self) -> u8 {
-        self.p1
-    }
-
-    pub fn p2(&self) -> u8 {
-        self.p2
-    }
-
     pub fn extended(&self) -> bool {
         self.extended
     }
@@ -113,8 +105,8 @@ pub struct CommandView<'a> {
     class: class::Class,
     instruction: Instruction,
 
-    p1: u8,
-    p2: u8,
+    pub p1: u8,
+    pub p2: u8,
 
     data: &'a [u8],
 
@@ -139,14 +131,6 @@ impl<'a> CommandView<'a> {
         self.le
     }
 
-    pub fn p1(&self) -> u8 {
-        self.p1
-    }
-
-    pub fn p2(&self) -> u8 {
-        self.p2
-    }
-
     pub fn extended(&self) -> bool {
         self.extended
     }
@@ -157,8 +141,8 @@ pub struct CommandBuilder<'a> {
     class: class::Class,
     instruction: Instruction,
 
-    p1: u8,
-    p2: u8,
+    pub p1: u8,
+    pub p2: u8,
 
     data: &'a [u8],