mirror of
https://github.com/trussed-dev/fido-authenticator.git
synced 2026-10-28 01:05:18 -07:00
The PIN retry counter should only be decremented for bad PIN entries, not for bad pinAuth values. Most commands that accept pinAuth input handle this correctly, but credential_management mistakenly decremented the retry counter. Also it is not necessary to check whether PIN authentication is blocked. The command should just return CTAP2_ERR_PIN_AUTH_INVALID if verification fails. See § 6.5.2.3 of the spec: > Each incorrect PIN entry decrements the pinRetries by 1. https://fidoalliance.org/specs/fido-v2.3-ps-20260226/fido-client-to-authenticator-protocol-v2.3-ps-20260226.html#pinretries