Ryuta Kamizono 59ce62b703 Fix Ruby 2.7 warnings (#63) ...

Ruby 2.7 introduced warnings around implicit conversions between
kwargs and hashes, so we fix the warnings.

If we have the following method:

  def foo(a, b, **c)
  end

And we pass arguments like this:

  args = [1, 2, { x: :y }]

  foo(*args)

This will trigger a kwarg warning on Ruby 2.7. So, we need to explicitly
pass the last argument as kwargs if it is a hash.

Surprisingly, the warning was only triggered when using #apply:

  # would trigger the kwargs warning
  ImageProcessing::Vips
    .source("/path/to/image")
    .apply!(resize_to_limit: [400, 400, sharpen: false])

And not when calling operation directly:

  # wouldn't trigger the kwargs warning
  ImageProcessing::Vips
    .source("/path/to/image")
    .resize_to_limit!(400, 400, sharpen: false)

Even though final options are exactly the same, so the code that's then
executed on processing should be the same.

  options1 = ImageProcessing::Vips
    .apply(resize_to_limit: [400, 400, sharpen: false])

  options2 = ImageProcessing::Vips
    .resize_to_limit(400, 400, sharpen: false)

  options1 == options2 #=> true

The warning was coming from Processor.apply_operation when we would call
an underlying macro. It's probably a bug in Ruby, both examples should have
triggered the same warning. But I couldn't isolate it, so instead we
add an additional test case for #apply.

Co-authored-by: Janko Marohnić <janko.marohnic@gmail.com>

2020-01-11 15:54:11 +01:00

..

image_processing

Fix Ruby 2.7 warnings (#63)

2020-01-11 15:54:11 +01:00

image_processing.rb

Make the pipeline object accessible to processors

2018-03-28 13:13:56 +02:00