From 83dbc2c8d1fd22738eb3816bebb0570a2bdaeac0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janko=20Marohni=C4=87?= Date: Thu, 28 Sep 2017 22:22:03 +0200 Subject: [PATCH 1/6] Add gem name to tempfile basename for better introspection --- lib/image_processing/mini_magick.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/image_processing/mini_magick.rb b/lib/image_processing/mini_magick.rb index 726b8dc..e84b14e 100644 --- a/lib/image_processing/mini_magick.rb +++ b/lib/image_processing/mini_magick.rb @@ -227,7 +227,7 @@ module ImageProcessing # IO object that responds to `#read(length = nil, outbuf = nil)`. def _copy_to_tempfile(file) extension = File.extname(file.path) if file.respond_to?(:path) - tempfile = Tempfile.new(["mini_magick", extension.to_s], binmode: true) + tempfile = Tempfile.new(["image_processing-mini_magick", extension.to_s], binmode: true) IO.copy_stream(file, tempfile.path) file.rewind tempfile From 56f4de2a1833b7a38338e9d196abe1a971cbc3a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janko=20Marohni=C4=87?= Date: Mon, 11 Jul 2016 19:57:31 +0800 Subject: [PATCH 2/6] Use latest ImageMagick/GraphicsMagick on Travis CI --- .travis.yml | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index da1ce14..622241f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,6 +1,11 @@ language: ruby -sudo: false +sudo: required + +before_install: + - sudo apt-get update + - sudo apt-get install imagemagick libmagickcore-dev libmagickwand-dev + - sudo apt-get install -qq graphicsmagick rvm: - "2.0" @@ -13,11 +18,3 @@ rvm: script: rake test cache: bundler - -addons: - apt: - packages: - - imagemagick - - libmagickcore-dev - - libmagickwand-dev - - graphicsmagick From 42b9772e4d923deb582e1cdac31c4455bdf83064 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janko=20Marohni=C4=87?= Date: Wed, 4 Oct 2017 09:06:52 +0200 Subject: [PATCH 3/6] Use latest Rubies on Travis CI --- .travis.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index 622241f..a262089 100644 --- a/.travis.yml +++ b/.travis.yml @@ -9,11 +9,11 @@ before_install: rvm: - "2.0" - - "2.1.10" - - "2.2.7" - - "2.3.4" - - "2.4.1" - - "jruby-9.0.4.0" + - "2.1" + - "2.2" + - "2.3" + - "2.4" + - "jruby-9.1.9.0" script: rake test From 89bd611e58ac03dd229912ac1658ce11f86b631e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janko=20Marohni=C4=87?= Date: Wed, 4 Oct 2017 09:23:01 +0200 Subject: [PATCH 4/6] Compile ImageMagick 7 from source That's apparently the only way to install ImageMagick 7 on Ubuntu. --- .travis.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index a262089..e60d9be 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,8 +3,13 @@ language: ruby sudo: required before_install: - - sudo apt-get update - - sudo apt-get install imagemagick libmagickcore-dev libmagickwand-dev + - wget http://www.imagemagick.org/download/ImageMagick.tar.gz + - tar -xvf ImageMagick.tar.gz + - cd ImageMagick-7.* + - ./configure + - make + - sudo make install + - sudo ldconfig /usr/local/lib - sudo apt-get install -qq graphicsmagick rvm: From 7043acde0d58b8824935bd1ddec8de5576fe7b0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janko=20Marohni=C4=87?= Date: Wed, 4 Oct 2017 09:54:59 +0200 Subject: [PATCH 5/6] Update minitest-hooks to fix an error --- image_processing.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/image_processing.gemspec b/image_processing.gemspec index 09ad40f..dba497a 100644 --- a/image_processing.gemspec +++ b/image_processing.gemspec @@ -17,7 +17,7 @@ Gem::Specification.new do |spec| spec.require_paths = ["lib"] spec.add_development_dependency "minitest", "~> 5.8" - spec.add_development_dependency "minitest-hooks" + spec.add_development_dependency "minitest-hooks", ">= 1.4.2" spec.add_development_dependency "minispec-metadata" spec.add_development_dependency "mini_magick", ">= 4.3.5" spec.add_development_dependency "phashion" unless RUBY_ENGINE == "jruby" From 427774b707b6014d05fadfdbd948a994610fec77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janko=20Marohni=C4=87?= Date: Sun, 8 Oct 2017 14:40:12 +0200 Subject: [PATCH 6/6] Drop official support for MRI 2.0 & 2.1 Minitest-hooks doesn't work with those versions, and I don't know why. --- .travis.yml | 2 -- README.md | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index e60d9be..7c09252 100644 --- a/.travis.yml +++ b/.travis.yml @@ -13,8 +13,6 @@ before_install: - sudo apt-get install -qq graphicsmagick rvm: - - "2.0" - - "2.1" - "2.2" - "2.3" - "2.4" diff --git a/README.md b/README.md index 0080a4b..9bf336e 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,7 @@ that they can be used in any project. The goal of image_processing is to have a centralized place where helper methods for image processing are maintained, instead of CarrierWave, Dragonfly and Refile each implementing their own. -It's been tested with MRI 2.x and JRuby. +It's been tested with MRI 2.2+ and JRuby. ## Installation