Files
snapd/features/features.go
Michael Vogt 06df81c76e many: revert "features: disable refresh-app-awarness by default again"
This reverts commit db339ccd37.

The desktop team is very nervous about disabling
refresh-app-awareness, especially this close to the release of
22.04.1. The worry is that unknown bugs during a refresh may
cause firefox to crash. Given the really good progress we had
with the startup performance and other improvements this would
be very unfortunate. Fwiw, there are no refresh bugs known right
now but the risk is there. The desktop team feels that the
shortcoming in the UX are a better tradeoff than to risk crashes.

We fixed the known issues around refresh-app-awareness:
https://bugs.launchpad.net/snapd/+bug/1975714
https://bugs.launchpad.net/snapd/+bug/1978834
https://github.com/snapcore/snapd/pull/11834
https://github.com/snapcore/snapd/pull/11976
https://github.com/snapcore/snapd/pull/11855

so hopefully this does not hit the other side of this too
hard. Sorry to everyone for yet another flip-flop on this,
it's really hard to find the right trade-off here.

This reverts https://github.com/snapcore/snapd/pull/11912
2022-07-26 12:36:24 +02:00

211 lines
7.2 KiB
Go

// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2018 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package features
import (
"fmt"
"path/filepath"
"github.com/snapcore/snapd/dirs"
"github.com/snapcore/snapd/osutil"
)
// SnapdFeature is a named feature that may be on or off.
type SnapdFeature int
const (
// Layouts controls availability of snap layouts.
Layouts SnapdFeature = iota
// ParallelInstances controls availability installing a snap multiple times.
ParallelInstances
// Hotplug controls availability of dynamically creating slots based on system hardware.
Hotplug
// SnapdSnap controls possibility of installing the snapd snap.
SnapdSnap
// PerUserMountNamespace controls the persistence of per-user mount namespaces.
PerUserMountNamespace
// RefreshAppAwareness controls refresh being aware of running applications.
RefreshAppAwareness
// ClassicPreservesXdgRuntimeDir controls $XDG_RUNTIME_DIR in snaps with classic confinement.
ClassicPreservesXdgRuntimeDir
// RobustMountNamespaceUpdates controls how snap-update-ns updates existing mount namespaces.
RobustMountNamespaceUpdates
// UserDaemons controls availability of user mode service support.
UserDaemons
// DbusActivation controls whether snaps daemons can be activated via D-Bus
DbusActivation
// HiddenSnapDataHomeDir controls if the snaps' data dir is ~/.snap/data instead of ~/snap
HiddenSnapDataHomeDir
// MoveSnapHomeDir controls whether snap user data under ~/snap (or ~/.snap/data) can be moved to ~/Snap.
MoveSnapHomeDir
// CheckDiskSpaceRemove controls free disk space check on remove whenever automatic snapshot needs to be created.
CheckDiskSpaceRemove
// CheckDiskSpaceInstall controls free disk space check on snap install.
CheckDiskSpaceInstall
// CheckDiskSpaceRefresh controls free disk space check on snap refresh.
CheckDiskSpaceRefresh
// GateAutoRefreshHook enables refresh control from snaps via gate-auto-refresh hook.
GateAutoRefreshHook
// QuotaGroups enable creating resource quota groups for snaps via the rest API and cli.
QuotaGroups
// lastFeature is the final known feature, it is only used for testing.
lastFeature
)
// KnownFeatures returns the list of all known features.
func KnownFeatures() []SnapdFeature {
features := make([]SnapdFeature, int(lastFeature))
for i := range features {
features[i] = SnapdFeature(i)
}
return features
}
// featureNames maps feature constant to stable string representation.
// The constants here must be synchronized with cmd/libsnap-confine-private/feature.c
var featureNames = map[SnapdFeature]string{
Layouts: "layouts",
ParallelInstances: "parallel-instances",
Hotplug: "hotplug",
SnapdSnap: "snapd-snap",
PerUserMountNamespace: "per-user-mount-namespace",
RefreshAppAwareness: "refresh-app-awareness",
ClassicPreservesXdgRuntimeDir: "classic-preserves-xdg-runtime-dir",
RobustMountNamespaceUpdates: "robust-mount-namespace-updates",
UserDaemons: "user-daemons",
DbusActivation: "dbus-activation",
HiddenSnapDataHomeDir: "hidden-snap-folder",
MoveSnapHomeDir: "move-snap-home-dir",
CheckDiskSpaceInstall: "check-disk-space-install",
CheckDiskSpaceRefresh: "check-disk-space-refresh",
CheckDiskSpaceRemove: "check-disk-space-remove",
GateAutoRefreshHook: "gate-auto-refresh-hook",
QuotaGroups: "quota-groups",
}
// featuresEnabledWhenUnset contains a set of features that are enabled when not explicitly configured.
var featuresEnabledWhenUnset = map[SnapdFeature]bool{
Layouts: true,
RefreshAppAwareness: true,
RobustMountNamespaceUpdates: true,
ClassicPreservesXdgRuntimeDir: true,
DbusActivation: true,
}
// featuresExported contains a set of features that are exported outside of snapd.
var featuresExported = map[SnapdFeature]bool{
PerUserMountNamespace: true,
RefreshAppAwareness: true,
ParallelInstances: true,
ClassicPreservesXdgRuntimeDir: true,
RobustMountNamespaceUpdates: true,
HiddenSnapDataHomeDir: true,
MoveSnapHomeDir: true,
}
// String returns the name of a snapd feature.
// The function panics for bogus feature values.
func (f SnapdFeature) String() string {
if name, ok := featureNames[f]; ok {
return name
}
panic(fmt.Sprintf("unknown feature flag code %d", f))
}
// IsEnabledWhenUnset returns true if a feature is enabled when not set.
//
// A feature may be enabled or disabled with explicit state in snapd. If
// explicit state is absent the effective value is the implicit default
// computed by this function.
func (f SnapdFeature) IsEnabledWhenUnset() bool {
return featuresEnabledWhenUnset[f]
}
// IsExported returns true if a feature is copied from snapd state to a feature file.
//
// Certain features are available outside of snapd internal state and visible as control
// files in a dedicated directory. Such features can be queried for, via IsEnabled, outside
// of snapd.
func (f SnapdFeature) IsExported() bool {
return featuresExported[f]
}
// ControlFile returns the path of the file controlling the exported feature.
//
// Snapd considers the feature enabled if the file is present.
// The contents of the file are not important.
//
// The function panics for features that are not exported.
func (f SnapdFeature) ControlFile() string {
if !f.IsExported() {
panic(fmt.Sprintf("cannot compute the control file of feature %q because that feature is not exported", f))
}
return filepath.Join(dirs.FeaturesDir, f.String())
}
// ConfigOption returns the snap name and configuration option associated with this feature.
func (f SnapdFeature) ConfigOption() (snapName, confName string) {
return "core", "experimental." + f.String()
}
// IsEnabled checks if a given exported snapd feature is enabled.
//
// The function panics for features that are not exported.
func (f SnapdFeature) IsEnabled() bool {
if !f.IsExported() {
panic(fmt.Sprintf("cannot check if feature %q is enabled because that feature is not exported", f))
}
// TODO: this returns false on errors != ErrNotExist.
// Consider using os.Stat and handling other errors
return osutil.FileExists(f.ControlFile())
}
type confGetter interface {
GetMaybe(snapName, key string, result interface{}) error
}
// Flag returns whether the given feature flag is enabled.
func Flag(tr confGetter, feature SnapdFeature) (bool, error) {
var isEnabled interface{}
snapName, confName := feature.ConfigOption()
if err := tr.GetMaybe(snapName, confName, &isEnabled); err != nil {
return false, err
}
switch isEnabled {
case true, "true":
return true, nil
case false, "false":
return false, nil
case nil, "":
return feature.IsEnabledWhenUnset(), nil
}
return false, fmt.Errorf("%s can only be set to 'true' or 'false', got %q", feature, isEnabled)
}