Files
snapd/seed/validate.go
Maciej Borzecki 75c64f7d0e seed: make a shared seed system label validation helper (#9649)
* seed: make a shared seed system label validation helper

Address a UC20 TODO and move the seed system validation helper into a shared
package.

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>

* seed/internal: tweak the valid system label regex, test more cases

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>

* seed/internal: tweak valid system label to disallow uppercase letters

This will help us avoid troubles should the system seed be stored in a FAT
filesystem.

Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
2020-11-18 08:43:18 +01:00

138 lines
3.5 KiB
Go

// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2014-2020 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package seed
import (
"bytes"
"fmt"
"path/filepath"
"sort"
"github.com/snapcore/snapd/snap"
"github.com/snapcore/snapd/snap/snapfile"
"github.com/snapcore/snapd/timings"
)
type ValidationError struct {
// SystemErrors maps system labels ("" for UC16/18) to their validation errors.
SystemErrors map[string][]error
}
func newValidationError(label string, err error) *ValidationError {
return &ValidationError{SystemErrors: map[string][]error{
label: {err},
}}
}
func (e *ValidationError) addErr(label string, errs ...error) {
if e.SystemErrors == nil {
e.SystemErrors = make(map[string][]error)
}
for _, err := range errs {
e.SystemErrors[label] = append(e.SystemErrors[label], err)
}
}
func (e ValidationError) hasErrors() bool {
return len(e.SystemErrors) != 0
}
func (e *ValidationError) Error() string {
systems := make([]string, 0, len(e.SystemErrors))
for s := range e.SystemErrors {
systems = append(systems, s)
}
sort.Strings(systems)
var buf bytes.Buffer
first := true
for _, s := range systems {
if first {
if s == "" {
fmt.Fprintf(&buf, "cannot validate seed:")
} else {
fmt.Fprintf(&buf, "cannot validate seed system %q:", s)
}
} else {
fmt.Fprintf(&buf, "\nand seed system %q:", s)
}
for _, err := range e.SystemErrors[s] {
fmt.Fprintf(&buf, "\n - %s", err)
}
}
return buf.String()
}
// ValidateFromYaml validates the given seed.yaml file and surrounding seed.
func ValidateFromYaml(seedYamlFile string) error {
// TODO:UC20: support validating also one or multiple UC20 seed systems
// introduce ListSystems ?
// What about full empty seed dir?
seedDir := filepath.Dir(seedYamlFile)
seed, err := Open(seedDir, "")
if err != nil {
return newValidationError("", err)
}
if err := seed.LoadAssertions(nil, nil); err != nil {
return newValidationError("", err)
}
tm := timings.New(nil)
if err := seed.LoadMeta(tm); err != nil {
if missingErr, ok := err.(*essentialSnapMissingError); ok {
if seed.Model().Classic() && missingErr.SnapName == "core" {
err = fmt.Errorf("essential snap core or snapd must be part of the seed")
}
}
return newValidationError("", err)
}
// TODO:UC20: make the NumSnaps/Iter part of Seed
seed16 := seed.(*seed16)
ve := &ValidationError{}
// read the snap infos
snapInfos := make([]*snap.Info, 0, seed16.NumSnaps())
seed16.Iter(func(sn *Snap) error {
snapf, err := snapfile.Open(sn.Path)
if err != nil {
ve.addErr("", err)
} else {
info, err := snap.ReadInfoFromSnapFile(snapf, sn.SideInfo)
if err != nil {
ve.addErr("", fmt.Errorf("cannot use snap %q: %v", sn.Path, err))
} else {
snapInfos = append(snapInfos, info)
}
}
return nil
})
if errs2 := snap.ValidateBasesAndProviders(snapInfos); errs2 != nil {
ve.addErr("", errs2...)
}
if ve.hasErrors() {
return ve
}
return nil
}