mirror of
https://github.com/token2/snapd.git
synced 2026-03-13 11:15:47 -07:00
406 lines
15 KiB
Go
406 lines
15 KiB
Go
// -*- Mode: Go; indent-tabs-mode: t -*-
|
|
|
|
/*
|
|
* Copyright (C) 2020 Canonical Ltd
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 3 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
package sysconfig
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"regexp"
|
|
|
|
"github.com/snapcore/snapd/dirs"
|
|
"github.com/snapcore/snapd/logger"
|
|
"github.com/snapcore/snapd/osutil"
|
|
"github.com/snapcore/snapd/strutil"
|
|
)
|
|
|
|
// HasGadgetCloudConf takes a gadget directory and returns whether there is
|
|
// cloud-init config in the form of a cloud.conf file in the gadget.
|
|
func HasGadgetCloudConf(gadgetDir string) bool {
|
|
return osutil.FileExists(filepath.Join(gadgetDir, "cloud.conf"))
|
|
}
|
|
|
|
func ubuntuDataCloudDir(rootdir string) string {
|
|
return filepath.Join(rootdir, "etc/cloud/")
|
|
}
|
|
|
|
// DisableCloudInit will disable cloud-init permanently by writing a
|
|
// cloud-init.disabled config file in etc/cloud under the target dir, which
|
|
// instructs cloud-init-generator to not trigger new cloud-init invocations.
|
|
// Note that even with this disabled file, a root user could still manually run
|
|
// cloud-init, but this capability is not provided to any strictly confined
|
|
// snap.
|
|
func DisableCloudInit(rootDir string) error {
|
|
ubuntuDataCloud := ubuntuDataCloudDir(rootDir)
|
|
if err := os.MkdirAll(ubuntuDataCloud, 0755); err != nil {
|
|
return fmt.Errorf("cannot make cloud config dir: %v", err)
|
|
}
|
|
if err := ioutil.WriteFile(filepath.Join(ubuntuDataCloud, "cloud-init.disabled"), nil, 0644); err != nil {
|
|
return fmt.Errorf("cannot disable cloud-init: %v", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// installCloudInitCfgDir installs glob cfg files from the source directory to
|
|
// the cloud config dir.
|
|
func installCloudInitCfgDir(src, targetdir, prefix string) error {
|
|
// TODO:UC20: enforce patterns on the glob files and their suffix ranges
|
|
ccl, err := filepath.Glob(filepath.Join(src, "*.cfg"))
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if len(ccl) == 0 {
|
|
return nil
|
|
}
|
|
|
|
ubuntuDataCloudCfgDir := filepath.Join(ubuntuDataCloudDir(targetdir), "cloud.cfg.d/")
|
|
if err := os.MkdirAll(ubuntuDataCloudCfgDir, 0755); err != nil {
|
|
return fmt.Errorf("cannot make cloud config dir: %v", err)
|
|
}
|
|
|
|
for _, cc := range ccl {
|
|
if err := osutil.CopyFile(cc, filepath.Join(ubuntuDataCloudCfgDir, prefix+filepath.Base(cc)), 0); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// installGadgetCloudInitCfg installs a single cloud-init config file from the
|
|
// gadget snap to the /etc/cloud config dir as "80_device_gadget.cfg".
|
|
func installGadgetCloudInitCfg(src, targetdir string) error {
|
|
ubuntuDataCloudCfgDir := filepath.Join(ubuntuDataCloudDir(targetdir), "cloud.cfg.d/")
|
|
if err := os.MkdirAll(ubuntuDataCloudCfgDir, 0755); err != nil {
|
|
return fmt.Errorf("cannot make cloud config dir: %v", err)
|
|
}
|
|
|
|
configFile := filepath.Join(ubuntuDataCloudCfgDir, "80_device_gadget.cfg")
|
|
return osutil.CopyFile(src, configFile, 0)
|
|
}
|
|
|
|
func configureCloudInit(opts *Options) (err error) {
|
|
if opts.TargetRootDir == "" {
|
|
return fmt.Errorf("unable to configure cloud-init, missing target dir")
|
|
}
|
|
|
|
// first check if cloud-init should be disallowed entirely
|
|
if !opts.AllowCloudInit {
|
|
return DisableCloudInit(WritableDefaultsDir(opts.TargetRootDir))
|
|
}
|
|
|
|
// next check if there is a gadget cloud.conf to install
|
|
if HasGadgetCloudConf(opts.GadgetDir) {
|
|
// then copy / install the gadget config first
|
|
gadgetCloudConf := filepath.Join(opts.GadgetDir, "cloud.conf")
|
|
if err := installGadgetCloudInitCfg(gadgetCloudConf, WritableDefaultsDir(opts.TargetRootDir)); err != nil {
|
|
return err
|
|
}
|
|
|
|
// we don't return here to enable also copying any cloud-init config
|
|
// from ubuntu-seed in order for both to be used simultaneously for
|
|
// example on test devices where the gadget has a gadget.yaml, but for
|
|
// testing purposes you also want to provision another user with
|
|
// ubuntu-seed cloud-init config
|
|
|
|
}
|
|
|
|
// TODO:UC20: implement filtering of files from src when specified via a
|
|
// specific Options for i.e. signed grade and MAAS, etc.
|
|
|
|
// finally check if there is a cloud-init src dir we should copy config
|
|
// files from
|
|
|
|
if opts.CloudInitSrcDir != "" {
|
|
// set the prefix such that any ubuntu-seed config that ends up getting
|
|
// installed takes precedence over the gadget config
|
|
return installCloudInitCfgDir(opts.CloudInitSrcDir, WritableDefaultsDir(opts.TargetRootDir), "90_")
|
|
}
|
|
|
|
// it's valid to allow cloud-init, but not set CloudInitSrcDir and not have
|
|
// a gadget cloud.conf, in this case cloud-init may pick up dynamic metadata
|
|
// and userdata from NoCloud sources such as a CD-ROM drive with label
|
|
// CIDATA, etc. during first-boot
|
|
|
|
return nil
|
|
}
|
|
|
|
// CloudInitState represents the various cloud-init states
|
|
type CloudInitState int
|
|
|
|
var (
|
|
// the (?m) is needed since cloud-init output will have newlines
|
|
cloudInitStatusRe = regexp.MustCompile(`(?m)^status: (.*)$`)
|
|
datasourceRe = regexp.MustCompile(`DataSource([a-zA-Z0-9]+).*`)
|
|
|
|
cloudInitSnapdRestrictFile = "/etc/cloud/cloud.cfg.d/zzzz_snapd.cfg"
|
|
cloudInitDisabledFile = "/etc/cloud/cloud-init.disabled"
|
|
|
|
// for NoCloud datasource, we need to specify "manual_cache_clean: true"
|
|
// because the default is false, and this key being true essentially informs
|
|
// cloud-init that it should always trust the instance-id it has cached in
|
|
// the image, and shouldn't assume that there is a new one on every boot, as
|
|
// otherwise we have bugs like https://bugs.launchpad.net/snapd/+bug/1905983
|
|
// where subsequent boots after cloud-init runs and gets restricted it will
|
|
// try to detect the instance_id by reading from the NoCloud datasource
|
|
// fs_label, but we set that to "null" so it fails to read anything and thus
|
|
// can't detect the effective instance_id and assumes it is different and
|
|
// applies default config which can overwrite valid config from the initial
|
|
// boot if that is not the default config
|
|
// see also https://cloudinit.readthedocs.io/en/latest/topics/boot.html?highlight=manual_cache_clean#first-boot-determination
|
|
nocloudRestrictYaml = []byte(`datasource_list: [NoCloud]
|
|
datasource:
|
|
NoCloud:
|
|
fs_label: null
|
|
manual_cache_clean: true
|
|
`)
|
|
|
|
// don't use manual_cache_clean for real cloud datasources, the setting is
|
|
// used with ubuntu core only for sources where we can only get the
|
|
// instance_id through the fs_label for NoCloud and None (since we disable
|
|
// importing using the fs_label after the initial run).
|
|
genericCloudRestrictYamlPattern = `datasource_list: [%s]
|
|
`
|
|
|
|
localDatasources = []string{"NoCloud", "None"}
|
|
)
|
|
|
|
const (
|
|
// CloudInitDisabledPermanently is when cloud-init is disabled as per the
|
|
// cloud-init.disabled file.
|
|
CloudInitDisabledPermanently CloudInitState = iota
|
|
// CloudInitRestrictedBySnapd is when cloud-init has been restricted by
|
|
// snapd with a specific config file.
|
|
CloudInitRestrictedBySnapd
|
|
// CloudInitUntriggered is when cloud-init is disabled because nothing has
|
|
// triggered it to run, but it could still be run.
|
|
CloudInitUntriggered
|
|
// CloudInitDone is when cloud-init has been run on this boot.
|
|
CloudInitDone
|
|
// CloudInitEnabled is when cloud-init is active, but not necessarily
|
|
// finished. This matches the "running" and "not run" states from cloud-init
|
|
// as well as any other state that does not match any of the other defined
|
|
// states, as we are conservative in assuming that cloud-init is doing
|
|
// something.
|
|
CloudInitEnabled
|
|
// CloudInitNotFound is when there is no cloud-init executable on the
|
|
// device.
|
|
CloudInitNotFound
|
|
// CloudInitErrored is when cloud-init tried to run, but failed or had invalid
|
|
// configuration.
|
|
CloudInitErrored
|
|
)
|
|
|
|
// CloudInitStatus returns the current status of cloud-init. Note that it will
|
|
// first check for static file-based statuses first through the snapd
|
|
// restriction file and the disabled file before consulting
|
|
// cloud-init directly through the status command.
|
|
// Also note that in unknown situations we are conservative in assuming that
|
|
// cloud-init may be doing something and will return CloudInitEnabled when we
|
|
// do not recognize the state returned by the cloud-init status command.
|
|
func CloudInitStatus() (CloudInitState, error) {
|
|
// if cloud-init has been restricted by snapd, check that first
|
|
snapdRestrictingFile := filepath.Join(dirs.GlobalRootDir, cloudInitSnapdRestrictFile)
|
|
if osutil.FileExists(snapdRestrictingFile) {
|
|
return CloudInitRestrictedBySnapd, nil
|
|
}
|
|
|
|
// if it was explicitly disabled via the cloud-init disable file, then
|
|
// return special status for that
|
|
disabledFile := filepath.Join(dirs.GlobalRootDir, cloudInitDisabledFile)
|
|
if osutil.FileExists(disabledFile) {
|
|
return CloudInitDisabledPermanently, nil
|
|
}
|
|
|
|
ciBinary, err := exec.LookPath("cloud-init")
|
|
if err != nil {
|
|
logger.Noticef("cannot locate cloud-init executable: %v", err)
|
|
return CloudInitNotFound, nil
|
|
}
|
|
|
|
out, err := exec.Command(ciBinary, "status").CombinedOutput()
|
|
if err != nil {
|
|
return CloudInitErrored, osutil.OutputErr(out, err)
|
|
}
|
|
// output should just be "status: <state>"
|
|
match := cloudInitStatusRe.FindSubmatch(out)
|
|
if len(match) != 2 {
|
|
return CloudInitErrored, fmt.Errorf("invalid cloud-init output: %v", osutil.OutputErr(out, err))
|
|
}
|
|
switch string(match[1]) {
|
|
case "disabled":
|
|
// here since we weren't disabled by the file, we are in "disabled but
|
|
// could be enabled" state - arguably this should be a different state
|
|
// than "disabled", see
|
|
// https://bugs.launchpad.net/cloud-init/+bug/1883124 and
|
|
// https://bugs.launchpad.net/cloud-init/+bug/1883122
|
|
return CloudInitUntriggered, nil
|
|
case "error":
|
|
return CloudInitErrored, nil
|
|
case "done":
|
|
return CloudInitDone, nil
|
|
// "running" and "not run" are considered Enabled, see doc-comment
|
|
case "running", "not run":
|
|
fallthrough
|
|
default:
|
|
// these states are all
|
|
return CloudInitEnabled, nil
|
|
}
|
|
}
|
|
|
|
// these structs are externally defined by cloud-init
|
|
type v1Data struct {
|
|
DataSource string `json:"datasource"`
|
|
}
|
|
|
|
type cloudInitStatus struct {
|
|
V1 v1Data `json:"v1"`
|
|
}
|
|
|
|
// CloudInitRestrictionResult is the result of calling RestrictCloudInit. The
|
|
// values for Action are "disable" or "restrict", and the Datasource will be set
|
|
// to the restricted datasource if Action is "restrict".
|
|
type CloudInitRestrictionResult struct {
|
|
Action string
|
|
DataSource string
|
|
}
|
|
|
|
// CloudInitRestrictOptions are options for how to restrict cloud-init with
|
|
// RestrictCloudInit.
|
|
type CloudInitRestrictOptions struct {
|
|
// ForceDisable will force disabling cloud-init even if it is
|
|
// in an active/running or errored state.
|
|
ForceDisable bool
|
|
|
|
// DisableAfterLocalDatasourcesRun modifies RestrictCloudInit to disable
|
|
// cloud-init after it has run on first-boot if the datasource detected is
|
|
// a local source such as NoCloud or None. If the datasource detected is not
|
|
// a local source, such as GCE or AWS EC2 it is merely restricted as
|
|
// described in the doc-comment on RestrictCloudInit.
|
|
DisableAfterLocalDatasourcesRun bool
|
|
}
|
|
|
|
// RestrictCloudInit will limit the operations of cloud-init on subsequent boots
|
|
// by either disabling cloud-init in the untriggered state, or restrict
|
|
// cloud-init to only use a specific datasource (additionally if the currently
|
|
// detected datasource for this boot was NoCloud, it will disable the automatic
|
|
// import of filesystems with labels such as CIDATA (or cidata) as datasources).
|
|
// This is expected to be run when cloud-init is in a "steady" state such as
|
|
// done or disabled (untriggered). If called in other states such as errored, it
|
|
// will return an error, but it can be forced to disable cloud-init anyways in
|
|
// these states with the opts parameter and the ForceDisable field.
|
|
// This function is meant to protect against CVE-2020-11933.
|
|
func RestrictCloudInit(state CloudInitState, opts *CloudInitRestrictOptions) (CloudInitRestrictionResult, error) {
|
|
res := CloudInitRestrictionResult{}
|
|
|
|
if opts == nil {
|
|
opts = &CloudInitRestrictOptions{}
|
|
}
|
|
|
|
switch state {
|
|
case CloudInitDone:
|
|
// handled below
|
|
break
|
|
case CloudInitRestrictedBySnapd:
|
|
return res, fmt.Errorf("cannot restrict cloud-init: already restricted")
|
|
case CloudInitDisabledPermanently:
|
|
return res, fmt.Errorf("cannot restrict cloud-init: already disabled")
|
|
case CloudInitErrored, CloudInitEnabled:
|
|
// if we are not forcing a disable, return error as these states are
|
|
// where cloud-init could still be running doing things
|
|
if !opts.ForceDisable {
|
|
return res, fmt.Errorf("cannot restrict cloud-init in error or enabled state")
|
|
}
|
|
fallthrough
|
|
case CloudInitUntriggered, CloudInitNotFound:
|
|
fallthrough
|
|
default:
|
|
res.Action = "disable"
|
|
return res, DisableCloudInit(dirs.GlobalRootDir)
|
|
}
|
|
|
|
// from here on out, we are taking the "restrict" action
|
|
res.Action = "restrict"
|
|
|
|
// first get the cloud-init data-source that was used from /
|
|
resultsFile := filepath.Join(dirs.GlobalRootDir, "/run/cloud-init/status.json")
|
|
|
|
f, err := os.Open(resultsFile)
|
|
if err != nil {
|
|
return res, err
|
|
}
|
|
defer f.Close()
|
|
|
|
var stat cloudInitStatus
|
|
err = json.NewDecoder(f).Decode(&stat)
|
|
if err != nil {
|
|
return res, err
|
|
}
|
|
|
|
// if the datasource was empty then cloud-init did something wrong or
|
|
// perhaps it incorrectly reported that it ran but something else deleted
|
|
// the file
|
|
datasourceRaw := stat.V1.DataSource
|
|
if datasourceRaw == "" {
|
|
return res, fmt.Errorf("cloud-init error: missing datasource from status.json")
|
|
}
|
|
|
|
// for some datasources there is additional data in this item, i.e. for
|
|
// NoCloud we will also see:
|
|
// "DataSourceNoCloud [seed=/dev/sr0][dsmode=net]"
|
|
// so hence we use a regexp to parse out just the name of the datasource
|
|
datasourceMatches := datasourceRe.FindStringSubmatch(datasourceRaw)
|
|
if len(datasourceMatches) != 2 {
|
|
return res, fmt.Errorf("cloud-init error: unexpected datasource format %q", datasourceRaw)
|
|
}
|
|
res.DataSource = datasourceMatches[1]
|
|
|
|
cloudInitRestrictFile := filepath.Join(dirs.GlobalRootDir, cloudInitSnapdRestrictFile)
|
|
|
|
switch {
|
|
case opts.DisableAfterLocalDatasourcesRun && strutil.ListContains(localDatasources, res.DataSource):
|
|
// On UC20, DisableAfterLocalDatasourcesRun will be set, where we want
|
|
// to disable local sources like NoCloud and None after first-boot
|
|
// instead of just restricting them like we do below for UC16 and UC18.
|
|
|
|
// as such, change the action taken to disable and disable cloud-init
|
|
res.Action = "disable"
|
|
err = DisableCloudInit(dirs.GlobalRootDir)
|
|
case res.DataSource == "NoCloud":
|
|
// With the NoCloud datasource (which is one of the local datasources),
|
|
// we also need to restrict/disable the import of arbitrary filesystem
|
|
// labels to use as datasources, i.e. a USB drive inserted by an
|
|
// attacker with label CIDATA will defeat security measures on Ubuntu
|
|
// Core, so with the additional fs_label spec, we disable that import.
|
|
err = ioutil.WriteFile(cloudInitRestrictFile, nocloudRestrictYaml, 0644)
|
|
default:
|
|
// all other cases are either not local on UC20, or not NoCloud and as
|
|
// such we simply restrict cloud-init to the specific datasource used so
|
|
// that an attack via NoCloud is protected against
|
|
yaml := []byte(fmt.Sprintf(genericCloudRestrictYamlPattern, res.DataSource))
|
|
err = ioutil.WriteFile(cloudInitRestrictFile, yaml, 0644)
|
|
}
|
|
|
|
return res, err
|
|
}
|