Files
Michael Vogt 218b5abbaa snapstate: notify user when refresh-app-awareness snap finished (#12715)
* snapstate: notify user when refresh-app-awareness snap refreshed

This is a minimal commit to show a notification when a refresh that
was triggered by the user closing an application is now ready
to use.

* {iface,snap}state: make LinkParticipant pass a *SnapSetup

* snapstate: use notifyLinkParticipant mechanism to trigger finish notification

* agentnotify: move agent notification into their own package

* snapstate: make AutoRefresh() take *AutoRefreshOptions

* agentnotify: import from overlord to ensure linkParticipant handler gets registered

* tests: add new refresh-app-awareness-notify spread test

* snapstate: fix unreachable code

* tests: move from wormhole to test-snapd-sh in refresh-app-awareness-notify

* agentnotify: send notification when snap starts to refresh

* usersession: tweak wording when refresh is ready (thanks to Oliver)

* usersession: actually add the missing finishRefreshNotificationCmd endpoint

* snap: disable graphicalSessionFlow() to avoid confusion

It's unclear if this flow ever worked and the finish-refresh
part for sure never worked because in the userd the API for
finish-notification was not wired in.

This needs to be re-examined when we have a proper UX design.

* usersession: show notification when update is finished (thanks to Oliver)

* agentnotify: remove uneeded notifyUnlinkSnap()

After a quick sync with Oliver the decision was taken to have
just a notification message when the snap refresh is finished
and not when it starts to avoid too many user distractions.

* usersession: tweak wording when refresh is ready (thanks to Oliver)

* agentnotify: remove unneeded comment

* usersession: one more wording tweak (thanks to Oliver)

* agentnotify: add missing unit test

* snapstate: add test that ensures the snapsup.Flags.IsContinuedAutoRefresh is set

* snapstate: add TODO

* many: tweak wordings/comment/variable names (thanks to Miguel)

* tests: simplify refresh-app-awareness-notify test (thanks to Miguel)

* tests: fix quoting in test

* snap: simplify how inhibit worflow inhibited

* tests: tweak tests and ensure "jq" is installed

* agent: fix unit test error
2023-04-18 14:35:47 +02:00
..