mirror of
https://github.com/token2/snapd.git
synced 2026-03-13 11:15:47 -07:00
cc12dae393
Some licenses were missing. Update to the latest version of the SPDX license list. Fixes: https://bugs.launchpad.net/snapcraft/+bug/1903609 * spdx: add deprecated license IDs Some deprecated license IDs may be in common use, eg. GPL-2.0, GPL-3.0. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com> * spdx: drop implicit handling of 'or-later' licenses Some licenses had 'or-later' variants, eg. GPL-2.0+. The code would incorrectly treat such licenses and lics as 'gnuplot+' would validate correctly even though it is unexpected. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com> * spdx: add a test case for GPL-2.0++ license Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com> * spdx: update to 3.11 2020-11-25 version of license list data Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
79 lines
2.2 KiB
Go
79 lines
2.2 KiB
Go
// -*- Mode: Go; indent-tabs-mode: t -*-
|
|
|
|
/*
|
|
* Copyright (C) 2016 Canonical Ltd
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 3 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
package spdx_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
. "gopkg.in/check.v1"
|
|
|
|
"github.com/snapcore/snapd/spdx"
|
|
)
|
|
|
|
func Test(t *testing.T) { TestingT(t) }
|
|
|
|
type spdxSuite struct{}
|
|
|
|
var _ = Suite(&spdxSuite{})
|
|
|
|
func (s *spdxSuite) TestParseHappy(c *C) {
|
|
for _, t := range []string{
|
|
"GPL-2.0",
|
|
"GPL-2.0+",
|
|
"GPL-2.0 AND BSD-2-Clause",
|
|
"GPL-2.0 OR BSD-2-Clause",
|
|
"GPL-2.0 WITH GCC-exception-3.1",
|
|
"(GPL-2.0 AND BSD-2-Clause)",
|
|
"GPL-2.0 AND (BSD-2-Clause OR 0BSD)",
|
|
"(BSD-2-Clause OR 0BSD) AND GPL-2.0 WITH GCC-exception-3.1",
|
|
"((GPL-2.0 AND (BSD-2-Clause OR 0BSD)) OR GPL-3.0) ",
|
|
} {
|
|
err := spdx.ValidateLicense(t)
|
|
c.Check(err, IsNil, Commentf("input: %q", t))
|
|
}
|
|
}
|
|
|
|
func (s *spdxSuite) TestParseError(c *C) {
|
|
for _, t := range []struct {
|
|
inp string
|
|
errStr string
|
|
}{
|
|
{"", "empty expression"},
|
|
{"GPL-2.0++", `unknown license: GPL-2.0\+\+`},
|
|
{"GPL-3.0 AND ()", "empty expression"},
|
|
{"()", "empty expression"},
|
|
|
|
{"FOO", `unknown license: FOO`},
|
|
{"GPL-3.0 xxx", `unexpected string: "xxx"`},
|
|
{"GPL-2.0 GPL-3.0", `missing AND or OR between "GPL-2.0" and "GPL-3.0"`},
|
|
{"(GPL-2.0))", `unexpected "\)"`},
|
|
{"(GPL-2.0", `expected "\)" got ""`},
|
|
{"OR", "missing license before OR"},
|
|
{"OR GPL-2.0", "missing license before OR"},
|
|
{"GPL-2.0 OR", "missing license after OR"},
|
|
{"GPL-2.0 WITH BAR", "unknown license exception: BAR"},
|
|
{"GPL-2.0 WITH (foo)", `"\(" not allowed after WITH`},
|
|
{"(BSD-2-Clause OR 0BSD) WITH GCC-exception-3.1", `expected license name before WITH`},
|
|
} {
|
|
err := spdx.ValidateLicense(t.inp)
|
|
c.Check(err, ErrorMatches, t.errStr, Commentf("input: %q", t.inp))
|
|
}
|
|
}
|