mirror of
https://github.com/token2/snapd.git
synced 2026-03-13 11:15:47 -07:00
61d7eba0cd
* daemon: establish a cancelation chain for incoming API requests Establish a cancelation chain for incoming API requests, to ensure orderly shutdown. This prevents a situation in which an API request, such as notices wait can block snapd shtudown for a long time. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com> * daemon: return 500 when the request context gets canceled Request's can be canceled based on the code actually issuing a cancel on the associted context, hence an Internal Server Error seems more appropriate. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com> * o/snapstate: leave TODOs about using caller provided context Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com> * daemon: pass down request context where possible Pass the context from the API request further down. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com> * daemon: set context in snap instruction for many-snap operation Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com> * daemon: pass context as an explicit parameter to request handlers Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com> * daemon: pass context Thanks to @ZeyadYasser Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com> * daemon: comment on Start() taking a context. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com> * daemon: add unit tests targeting context passed to Start() Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com> * daemon: drop unit test for hijacked context The test isn't very useful. Another option to trigger this would be to call Stop() without a prior call to Start(), but this segfaults on d.standbyOpinions.Stop(), so it'c clear this needs a followup fix or callign Stop() this way isn't supported. Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com> --------- Signed-off-by: Maciej Borzecki <maciej.borzecki@canonical.com>
61 lines
1.6 KiB
Go
61 lines
1.6 KiB
Go
// -*- Mode: Go; indent-tabs-mode: t -*-
|
|
|
|
/*
|
|
* Copyright (C) 2019 Canonical Ltd
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 3 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
package daemon
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
|
|
"github.com/snapcore/snapd/client"
|
|
"github.com/snapcore/snapd/overlord/auth"
|
|
)
|
|
|
|
var cohortsCmd = &Command{
|
|
Path: "/v2/cohorts",
|
|
POST: postCohorts,
|
|
WriteAccess: authenticatedAccess{},
|
|
}
|
|
|
|
func postCohorts(c *Command, r *http.Request, user *auth.UserState) Response {
|
|
var inst client.CohortAction
|
|
dec := json.NewDecoder(r.Body)
|
|
if err := dec.Decode(&inst); err != nil {
|
|
return BadRequest("cannot decode request body into cohort instruction: %v", err)
|
|
}
|
|
if dec.More() {
|
|
return BadRequest("spurious content after cohort instruction")
|
|
}
|
|
|
|
if inst.Action != "create" {
|
|
return BadRequest("unknown cohort action %q", inst.Action)
|
|
}
|
|
|
|
if len(inst.Snaps) == 0 {
|
|
// nothing to do ¯\_(ツ)_/¯
|
|
return SyncResponse(map[string]string{})
|
|
}
|
|
|
|
cohorts, err := storeFrom(c.d).CreateCohorts(r.Context(), inst.Snaps)
|
|
if err != nil {
|
|
return InternalError(err.Error())
|
|
}
|
|
return SyncResponse(cohorts)
|
|
}
|