mirror of
https://github.com/token2/snapd.git
synced 2026-03-13 11:15:47 -07:00
* client: fix specificErr handling in SnapshotExport()
The code was checking generating a `specificErr` but then checked
`if err != nil {` (and not check for specificErr) and also lacked
a unit test.
When adding the code test it became clear that the other issue
there is that the response body was never read so r.err() would
always return nil.
This commit fixes both issues.
* client: fix TestClientExportSnapshotSpecificErr naming
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
---------
Co-authored-by: Miguel Pires <miguelpires94@gmail.com>
283 lines
8.4 KiB
Go
283 lines
8.4 KiB
Go
// -*- Mode: Go; indent-tabs-mode: t -*-
|
|
|
|
/*
|
|
* Copyright (C) 2018 Canonical Ltd
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 3 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
package client
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"crypto/sha256"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"net/url"
|
|
"sort"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/snapcore/snapd/snap"
|
|
)
|
|
|
|
// SnapshotExportMediaType is the media type used to identify snapshot exports in the API.
|
|
const SnapshotExportMediaType = "application/x.snapd.snapshot"
|
|
|
|
var (
|
|
ErrSnapshotSetNotFound = errors.New("no snapshot set with the given ID")
|
|
ErrSnapshotSnapsNotFound = errors.New("no snapshot for the requested snaps found in the set with the given ID")
|
|
)
|
|
|
|
// A snapshotAction is used to request an operation on a snapshot.
|
|
type snapshotAction struct {
|
|
SetID uint64 `json:"set"`
|
|
Action string `json:"action"`
|
|
Snaps []string `json:"snaps,omitempty"`
|
|
Users []string `json:"users,omitempty"`
|
|
}
|
|
|
|
// A Snapshot is a collection of archives with a simple metadata json file
|
|
// (and hashsums of everything).
|
|
type Snapshot struct {
|
|
// SetID is the ID of the snapshot set (a snapshot set is the result of a "snap save" invocation)
|
|
SetID uint64 `json:"set"`
|
|
// the time this snapshot's data collection was started
|
|
Time time.Time `json:"time"`
|
|
|
|
// information about the snap this data is for
|
|
Snap string `json:"snap"`
|
|
Revision snap.Revision `json:"revision"`
|
|
SnapID string `json:"snap-id,omitempty"`
|
|
Epoch snap.Epoch `json:"epoch,omitempty"`
|
|
Summary string `json:"summary"`
|
|
Version string `json:"version"`
|
|
|
|
// the snap's configuration at snapshot time
|
|
Conf map[string]interface{} `json:"conf,omitempty"`
|
|
|
|
// the hash of the archives' data, keyed by archive path
|
|
// (either 'archive.tgz' for the system archive, or
|
|
// user/<username>.tgz for each user)
|
|
SHA3_384 map[string]string `json:"sha3-384"`
|
|
// the sum of the archive sizes
|
|
Size int64 `json:"size,omitempty"`
|
|
|
|
// dynamic snapshot options
|
|
Options *snap.SnapshotOptions `json:"options,omitempty"`
|
|
|
|
// if the snapshot failed to open this will be the reason why
|
|
Broken string `json:"broken,omitempty"`
|
|
|
|
// set if the snapshot was created automatically on snap removal;
|
|
// note, this is only set inside actual snapshot file for old snapshots;
|
|
// newer snapd just updates this flag on the fly for snapshots
|
|
// returned by List().
|
|
Auto bool `json:"auto,omitempty"`
|
|
}
|
|
|
|
// IsValid checks whether the snapshot is missing information that
|
|
// should be there for a snapshot that's just been opened.
|
|
func (sh *Snapshot) IsValid() bool {
|
|
return !(sh == nil || sh.SetID == 0 || sh.Snap == "" || sh.Revision.Unset() || len(sh.SHA3_384) == 0 || sh.Time.IsZero())
|
|
}
|
|
|
|
// ContentHash returns a hash that can be used to identify the snapshot
|
|
// by its content, leaving out metadata like "time" or "set-id".
|
|
func (sh *Snapshot) ContentHash() ([]byte, error) {
|
|
sh2 := *sh
|
|
sh2.SetID = 0
|
|
sh2.Time = time.Time{}
|
|
sh2.Auto = false
|
|
sh2.Options = nil
|
|
h := sha256.New()
|
|
enc := json.NewEncoder(h)
|
|
if err := enc.Encode(&sh2); err != nil {
|
|
return nil, err
|
|
}
|
|
return h.Sum(nil), nil
|
|
}
|
|
|
|
// A SnapshotSet is a set of snapshots created by a single "snap save".
|
|
type SnapshotSet struct {
|
|
ID uint64 `json:"id"`
|
|
Snapshots []*Snapshot `json:"snapshots"`
|
|
}
|
|
|
|
// Time returns the earliest time in the set.
|
|
func (ss SnapshotSet) Time() time.Time {
|
|
if len(ss.Snapshots) == 0 {
|
|
return time.Time{}
|
|
}
|
|
mint := ss.Snapshots[0].Time
|
|
for _, sh := range ss.Snapshots {
|
|
if sh.Time.Before(mint) {
|
|
mint = sh.Time
|
|
}
|
|
}
|
|
return mint
|
|
}
|
|
|
|
// Size returns the sum of the set's sizes.
|
|
func (ss SnapshotSet) Size() int64 {
|
|
var sum int64
|
|
for _, sh := range ss.Snapshots {
|
|
sum += sh.Size
|
|
}
|
|
return sum
|
|
}
|
|
|
|
type bySnap []*Snapshot
|
|
|
|
func (ss bySnap) Len() int { return len(ss) }
|
|
func (ss bySnap) Swap(i, j int) { ss[i], ss[j] = ss[j], ss[i] }
|
|
func (ss bySnap) Less(i, j int) bool { return ss[i].Snap < ss[j].Snap }
|
|
|
|
// ContentHash returns a hash that can be used to identify the SnapshotSet by
|
|
// its content.
|
|
func (ss SnapshotSet) ContentHash() ([]byte, error) {
|
|
sortedSnapshots := make([]*Snapshot, len(ss.Snapshots))
|
|
copy(sortedSnapshots, ss.Snapshots)
|
|
sort.Sort(bySnap(sortedSnapshots))
|
|
|
|
h := sha256.New()
|
|
for _, sh := range sortedSnapshots {
|
|
ch, err := sh.ContentHash()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
h.Write(ch)
|
|
}
|
|
return h.Sum(nil), nil
|
|
}
|
|
|
|
// SnapshotSets lists the snapshot sets in the system that belong to the
|
|
// given set (if non-zero) and are for the given snaps (if non-empty).
|
|
func (client *Client) SnapshotSets(setID uint64, snapNames []string) ([]SnapshotSet, error) {
|
|
q := make(url.Values)
|
|
if setID > 0 {
|
|
q.Add("set", strconv.FormatUint(setID, 10))
|
|
}
|
|
if len(snapNames) > 0 {
|
|
q.Add("snaps", strings.Join(snapNames, ","))
|
|
}
|
|
|
|
var snapshotSets []SnapshotSet
|
|
_, err := client.doSync("GET", "/v2/snapshots", q, nil, nil, &snapshotSets)
|
|
return snapshotSets, err
|
|
}
|
|
|
|
// ForgetSnapshots permanently removes the snapshot set, limited to the
|
|
// given snaps (if non-empty).
|
|
func (client *Client) ForgetSnapshots(setID uint64, snaps []string) (changeID string, err error) {
|
|
return client.snapshotAction(&snapshotAction{
|
|
SetID: setID,
|
|
Action: "forget",
|
|
Snaps: snaps,
|
|
})
|
|
}
|
|
|
|
// CheckSnapshots verifies the archive checksums in the given snapshot set.
|
|
//
|
|
// If snaps or users are non-empty, limit to checking only those
|
|
// archives of the snapshot.
|
|
func (client *Client) CheckSnapshots(setID uint64, snaps []string, users []string) (changeID string, err error) {
|
|
return client.snapshotAction(&snapshotAction{
|
|
SetID: setID,
|
|
Action: "check",
|
|
Snaps: snaps,
|
|
Users: users,
|
|
})
|
|
}
|
|
|
|
// RestoreSnapshots extracts the given snapshot set.
|
|
//
|
|
// If snaps or users are non-empty, limit to checking only those
|
|
// archives of the snapshot.
|
|
func (client *Client) RestoreSnapshots(setID uint64, snaps []string, users []string) (changeID string, err error) {
|
|
return client.snapshotAction(&snapshotAction{
|
|
SetID: setID,
|
|
Action: "restore",
|
|
Snaps: snaps,
|
|
Users: users,
|
|
})
|
|
}
|
|
|
|
func (client *Client) snapshotAction(action *snapshotAction) (changeID string, err error) {
|
|
data, err := json.Marshal(action)
|
|
if err != nil {
|
|
return "", fmt.Errorf("cannot marshal snapshot action: %v", err)
|
|
}
|
|
|
|
headers := map[string]string{
|
|
"Content-Type": "application/json",
|
|
}
|
|
|
|
return client.doAsync("POST", "/v2/snapshots", nil, headers, bytes.NewBuffer(data))
|
|
}
|
|
|
|
// SnapshotExport streams the requested snapshot set.
|
|
//
|
|
// The return value includes the length of the returned stream.
|
|
func (client *Client) SnapshotExport(setID uint64) (stream io.ReadCloser, contentLength int64, err error) {
|
|
rsp, err := client.raw(context.Background(), "GET", fmt.Sprintf("/v2/snapshots/%v/export", setID), nil, nil, nil)
|
|
if err != nil {
|
|
return nil, 0, err
|
|
}
|
|
if rsp.StatusCode != 200 {
|
|
defer rsp.Body.Close()
|
|
|
|
var r response
|
|
dec := json.NewDecoder(rsp.Body)
|
|
if err := dec.Decode(&r); err == nil {
|
|
specificErr := r.err(client, rsp.StatusCode)
|
|
if specificErr != nil {
|
|
return nil, 0, specificErr
|
|
}
|
|
}
|
|
return nil, 0, fmt.Errorf("unexpected status code: %v", rsp.Status)
|
|
}
|
|
contentType := rsp.Header.Get("Content-Type")
|
|
if contentType != SnapshotExportMediaType {
|
|
return nil, 0, fmt.Errorf("unexpected snapshot export content type %q", contentType)
|
|
}
|
|
|
|
return rsp.Body, rsp.ContentLength, nil
|
|
}
|
|
|
|
// SnapshotImportSet is a snapshot import created by a "snap import-snapshot".
|
|
type SnapshotImportSet struct {
|
|
ID uint64 `json:"set-id"`
|
|
Snaps []string `json:"snaps"`
|
|
}
|
|
|
|
// SnapshotImport imports an exported snapshot set.
|
|
func (client *Client) SnapshotImport(exportStream io.Reader, size int64) (SnapshotImportSet, error) {
|
|
headers := map[string]string{
|
|
"Content-Type": SnapshotExportMediaType,
|
|
"Content-Length": strconv.FormatInt(size, 10),
|
|
}
|
|
|
|
var importSet SnapshotImportSet
|
|
if _, err := client.doSync("POST", "/v2/snapshots", nil, headers, exportStream, &importSet); err != nil {
|
|
return importSet, err
|
|
}
|
|
|
|
return importSet, nil
|
|
}
|