mirror of
https://github.com/token2/snapd.git
synced 2026-03-13 11:15:47 -07:00
d33346c0e6
Many tests currently implicitly rely on reading state from /proc/self/mountinfo through the system-key or other various aspects that care about what's mounted on the system. These tests currently suffer from leaking state from the host system that the unit test is being run on into the test, exposing us to a problem where we may have false positives if these tests are run on systems with the state present and the state was not properly mocked. To alleviate this, we make LoadMountInfo take no arguments and panic if it was not properly mocked during tests. The proper way to mock mountinfo now is to use MockMountInfo(), which is now exported and will do the right thing. This does mean we have to eliminate a test in osutil which was testing about the filename argument to LoadMountInfo which no longer is possible. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
108 lines
4.8 KiB
Go
108 lines
4.8 KiB
Go
// -*- Mode: Go; indent-tabs-mode: t -*-
|
|
|
|
/*
|
|
* Copyright (C) 2016-2018 Canonical Ltd
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 3 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
package osutil_test
|
|
|
|
import (
|
|
. "gopkg.in/check.v1"
|
|
|
|
"github.com/snapcore/snapd/osutil"
|
|
)
|
|
|
|
type overlaySuite struct{}
|
|
|
|
var _ = Suite(&overlaySuite{})
|
|
|
|
func (s *overlaySuite) TestIsRootWritableOverlay(c *C) {
|
|
cases := []struct {
|
|
mountinfo string
|
|
overlay string
|
|
errorPattern string
|
|
}{{
|
|
// Errors from parsing mountinfo are propagated.
|
|
mountinfo: "bad syntax",
|
|
errorPattern: "cannot parse mountinfo:.*, .*",
|
|
}, {
|
|
// overlay mounted on / are recognized
|
|
// casper mount source /cow
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay /cow rw,lowerdir=//filesystem.squashfs,upperdir=/cow/upper,workdir=/cow/work",
|
|
overlay: "/upper",
|
|
}, {
|
|
// casper mount source upperdir trailing slash
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay /cow rw,lowerdir=//filesystem.squashfs,upperdir=/cow/upper/,workdir=/cow/work",
|
|
overlay: "/upper",
|
|
}, {
|
|
// casper mount source trailing slash
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay /cow/ rw,lowerdir=//filesystem.squashfs,upperdir=/cow/upper,workdir=/cow/work",
|
|
overlay: "/upper",
|
|
}, {
|
|
// non-casper mount source
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay overlay rw,lowerdir=//filesystem.squashfs,upperdir=/cow/upper,workdir=/cow/work",
|
|
overlay: "/cow/upper",
|
|
}, {
|
|
// overlay mounted elsewhere are ignored
|
|
mountinfo: "31 1 0:26 /elsewhere /elsewhere rw,relatime shared:1 - overlay /cow rw,lowerdir=//filesystem.squashfs,upperdir=/cow/upper,workdir=/cow/work",
|
|
}, {
|
|
mountinfo: "31 1 0:26 /elsewhere /elsewhere rw,relatime shared:1 - overlay overlay rw,lowerdir=//filesystem.squashfs,upperdir=/cow/upper,workdir=/cow/work",
|
|
}, {
|
|
// casper overlay which results in empty upperdir are ignored
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay /upper rw,lowerdir=//filesystem.squashfs,upperdir=/upper,workdir=/cow/work",
|
|
}, {
|
|
// overlay with relative paths, AARE or double quotes are
|
|
// ignored
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay /cow rw,lowerdir=//filesystem.squashfs,upperdir=cow/upper,workdir=/cow/work",
|
|
}, {
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay /cow rw,lowerdir=//filesystem.squashfs,upperdir=/cow/bad?upper,workdir=/cow/work",
|
|
}, {
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay /cow rw,lowerdir=//filesystem.squashfs,upperdir=/cow/bad*upper,workdir=/cow/work",
|
|
}, {
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay /cow rw,lowerdir=//filesystem.squashfs,upperdir=/cow/bad[upper,workdir=/cow/work",
|
|
}, {
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay overlay rw,lowerdir=//filesystem.squashfs,upperdir=/cow/bad]upper,workdir=/cow/work",
|
|
}, {
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay overlay rw,lowerdir=//filesystem.squashfs,upperdir=/cow/bad{upper,workdir=/cow/work",
|
|
}, {
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay overlay rw,lowerdir=//filesystem.squashfs,upperdir=/cow/bad}upper,workdir=/cow/work",
|
|
}, {
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay overlay rw,lowerdir=//filesystem.squashfs,upperdir=/cow/bad^upper,workdir=/cow/work",
|
|
}, {
|
|
mountinfo: "31 1 0:26 / / rw,relatime shared:1 - overlay overlay rw,lowerdir=//filesystem.squashfs,upperdir=/cow/bad\"upper,workdir=/cow/work",
|
|
}, {
|
|
// The special cased version for 18.10 server release
|
|
mountinfo: "28 0 0:24 / / rw,realtime shared:1 - overlay overlayroot rw,lowerdir=/media/root-ro,upperdir=/media/root-rw/overlay,workdir=/media/root-rw/overlay-workdir/_",
|
|
overlay: "/overlay",
|
|
}, {
|
|
// The special cased version for Manjaro live CD,
|
|
mountinfo: "37 1 0:24 / / rw,realtime shared:1 - overlay overlay rw,lowerdir=/run/miso/sfs/livefs:/run/miso/sfs/mhwdfs:/run/miso/sfs/desktopfs:/run/miso/sfs/rootfs,upperdir=/run/miso/overlay_root/upper,workdir=/run/miso/overlay_root/work,index=off",
|
|
overlay: "/upper",
|
|
}}
|
|
for _, tc := range cases {
|
|
restore := osutil.MockMountInfo(tc.mountinfo)
|
|
defer restore()
|
|
|
|
overlay, err := osutil.IsRootWritableOverlay()
|
|
if tc.errorPattern != "" {
|
|
c.Assert(err, ErrorMatches, tc.errorPattern, Commentf("test case %#v", tc))
|
|
} else {
|
|
c.Assert(err, IsNil)
|
|
}
|
|
c.Assert(overlay, Equals, tc.overlay)
|
|
}
|
|
}
|