Files
snapd/daemon/api_snapctl_test.go
Samuele Pedroni c9d961a863 daemon: have apiBaseSuite.errorReq return *apiError directly
now that apiError is used everywhere to return errors

result naming and checks in tests are adjusted accordingly
2021-06-10 13:15:35 +02:00

98 lines
3.0 KiB
Go

// -*- Mode: Go; indent-tabs-mode: t -*-
/*
* Copyright (C) 2014-2020 Canonical Ltd
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 3 as
* published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
package daemon_test
import (
"bytes"
"fmt"
"net/http"
"gopkg.in/check.v1"
"github.com/snapcore/snapd/client"
"github.com/snapcore/snapd/daemon"
"github.com/snapcore/snapd/dirs"
"github.com/snapcore/snapd/overlord/hookstate"
"github.com/snapcore/snapd/overlord/hookstate/ctlcmd"
)
var _ = check.Suite(&snapctlSuite{})
type snapctlSuite struct {
apiBaseSuite
}
func (s *snapctlSuite) SetUpTest(c *check.C) {
s.apiBaseSuite.SetUpTest(c)
s.expectWriteAccess(daemon.SnapAccess{})
}
func (s *snapctlSuite) TestSnapctlGetNoUID(c *check.C) {
s.daemon(c)
buf := bytes.NewBufferString(`{"context-id": "some-context", "args": ["get", "something"]}`)
req, err := http.NewRequest("POST", "/v2/snapctl", buf)
c.Assert(err, check.IsNil)
rsp := s.errorReq(c, req, nil)
c.Assert(rsp.Status, check.Equals, 403)
}
func (s *snapctlSuite) TestSnapctlForbiddenError(c *check.C) {
s.daemon(c)
defer daemon.MockUcrednetGet(func(string) (*daemon.Ucrednet, error) {
return &daemon.Ucrednet{Uid: 100, Pid: 9999, Socket: dirs.SnapSocket}, nil
})()
defer daemon.MockCtlcmdRun(func(ctx *hookstate.Context, arg []string, uid uint32) ([]byte, []byte, error) {
return nil, nil, &ctlcmd.ForbiddenCommandError{}
})()
buf := bytes.NewBufferString(fmt.Sprintf(`{"context-id": "some-context", "args": [%q, %q]}`, "set", "foo=bar"))
req, err := http.NewRequest("POST", "/v2/snapctl", buf)
c.Assert(err, check.IsNil)
rsp := s.errorReq(c, req, nil)
c.Assert(rsp.Status, check.Equals, 403)
}
func (s *snapctlSuite) TestSnapctlUnsuccesfulError(c *check.C) {
s.daemon(c)
defer daemon.MockUcrednetGet(func(string) (*daemon.Ucrednet, error) {
return &daemon.Ucrednet{Uid: 100, Pid: 9999, Socket: dirs.SnapSocket}, nil
})()
defer daemon.MockCtlcmdRun(func(ctx *hookstate.Context, arg []string, uid uint32) ([]byte, []byte, error) {
return nil, nil, &ctlcmd.UnsuccessfulError{ExitCode: 123}
})()
buf := bytes.NewBufferString(fmt.Sprintf(`{"context-id": "some-context", "args": [%q, %q]}`, "is-connected", "plug"))
req, err := http.NewRequest("POST", "/v2/snapctl", buf)
c.Assert(err, check.IsNil)
rspe := s.errorReq(c, req, nil)
c.Check(rspe.Status, check.Equals, 200)
c.Check(rspe.Kind, check.Equals, client.ErrorKindUnsuccessful)
c.Check(rspe.Value, check.DeepEquals, map[string]interface{}{
"stdout": "",
"stderr": "",
"exit-code": 123,
})
}