This commit updates the if/case statements that check for
secboot.EncryptionTypeLUKS to also deal with EncryptionTypeLUKSWithICE
and add some TODO:ICE: about cleanup we can do later.
Include OnDiskStructure in LaidOutStructure so we really have all the
needed information to create partitions and content in
LaidOutStructure. Also, remove the now unneeded
onDiskAndLaidoutStructure.
* gadget: change FindDeviceForStructure input to a VolumeStructure
as we did not need the full LaidOutStructure. This also simplifies the
tests.
* gadget/install: use OnDiskStructure in ensureNodesExist
As we did not need the full laid out structure.
* gadget: include OnDiskStructure in LaidOutStructure
Include OnDiskStructure in LaidOutStructure so we really have all the
needed information to create partitions and content in
LaidOutStructure. Also, remove the now unneeded
onDiskAndLaidoutStructure.
* gadget: remove StartOffset from LaidOutStructure
It is not needed as we have the same field in OnDiskStructure, which
is contained in LaidOutStructure.
* gadget: replace access to LaidOutStructure.VolumeStructure by methods
where possible.
* gadget: set encryption info in gadget.LaidoutVolume
Pass around encryption information so we can set the encryption info
in LaidOutStructure nearer to where it is created, which simplifies
the code and fixes cases not considered before.
* tests/muinstaller: use temporarily commit from branch for the build
To be removed as soon as https://github.com/snapcore/snapd/pull/12515
is merged.
This makes the debug endpoint work on UC18 and UC16 devices which have this
implicit system-data role.
Also add a small check to make sure the options are non-nil in
AllDiskVolumeDeviceTraits when we provide them to
DiskTraitsFromDeviceAndValidate.
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
the cleanliness gained by having two structures with almost
the same fields is probably not enough to justify both of them,
especially because daemon is where we are supposed to build
responses, we might as well deal with the details
Meta was a quick hack, also it hasn't really grown since so we can
try to remove it now
AsyncResponse never takes anything over the result but the change id
