Go 1.19 includes some changes to gofmt which intend to make lists and
heading clearer when rendered (https://go.dev/doc/go1.19). This commit
is the result of running the new gofmt and manually fixing some of it.
This was necessary because the new gofmt assumed lines beginning w/ tabs
to start lists or examples. While this is often true in our codebase,
we occasionally also use tabs to indent the lines after a TODO or FIXME
prefix or in yaml (e.g., excerpts of a snap.yaml). This meant that a lot of the
reformatted comments were broken and had to be fixed manually.
Signed-off-by: Miguel Pires <miguel.pires@canonical.com>
This commit replaces the use of "sanity" with more inclusive
naming.
When `sanity` is used in a more general sense either `validity`
or `quick` is used.
Motivation
In the context of assertion bulk refresh the API supports
dividing the requested assertions in groups, it is natural for
example to have one group for the relevant assertions for each
snap. Some assertions though will then belong to more than one
group, for example store account-keys or developer account
assertions for developers of many snaps on the system. We want
to detect such cases to request them separately and only once for
better caching properties of the requests. At the low-level
Grouping will help with that with one associated with each
in-play assertion to track to which groups it belongs while
setting up bulk refresh requests. A higher level abstraction
asserts.Pool will leverage this and implement other related
details and features for bulk refresh.
