From 49c0eb481a14b53d5ae71beaabd37bd30d0ce4fc Mon Sep 17 00:00:00 2001 From: Tamir Suliman Date: Sat, 6 Jun 2026 13:43:49 +0200 Subject: [PATCH] Fix #8 - correct PopulateListView forward declaration signature The forward declaration at line 568 had one parameter (const std::wstring&) while the definition at line 694 takes two (HWND, const std::wstring&). The mismatch is a latent ODR violation: the compiler currently resolves correctly because the declaration appears after the definition, but any reorganisation that moves the declaration above the definition would cause a compile error or a silent wrong-function call. Updated the declaration to match the definition and the single call site exactly. Fixes #8 --- FIDO2.1 Manager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FIDO2.1 Manager.cpp b/FIDO2.1 Manager.cpp index 2d552e1..852592a 100644 --- a/FIDO2.1 Manager.cpp +++ b/FIDO2.1 Manager.cpp @@ -565,7 +565,7 @@ LRESULT CALLBACK WindowProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam); std::vector RunCommandAndGetOutput(const std::wstring& command); void PopulateComboBox(); -void PopulateListView(const std::wstring& deviceNumber); +void PopulateListView(HWND hwnd, const std::wstring& deviceNumber); void ResizeControls(HWND hwnd); void RefreshData();