mirror of
https://github.com/token2/chromeos_smart_card_connector.git
synced 2026-06-22 14:42:50 -07:00
Maksim IvanovandGitHub
30f4f5a20a
Change the users of the find-files-for-linting.py Python code (eslient.py and format-code.py) to import it as a Python module rather than run as a subprocess. This should avoid unnecessary overhead and data conversions. The change renames the file to "find_files_for_linting.py" as dashes in file names aren't Python-friendly.
66 lines
2.2 KiB
Python
Executable File
66 lines
2.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
|
|
# Copyright 2023 Google Inc. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""Runs clang-format on all relevant C++/JavaScript files in the repository."""
|
|
|
|
import argparse
|
|
from internal import find_files_for_linting
|
|
import os.path
|
|
import subprocess
|
|
import sys
|
|
|
|
FILE_MASKS = ['*.cc', '*.h', '*.js']
|
|
FORMAT_OPTIONS = [
|
|
'--style=Chromium',
|
|
# TODO(emaxx): Consider reenabling this, now that we don't use <> includes for
|
|
# the headers maintained in this project.
|
|
'--sort-includes=false',
|
|
]
|
|
CHECK_ONLY_OPTIONS = ['--dry-run', '-Werror']
|
|
|
|
def parse_command_line_args():
|
|
parser = argparse.ArgumentParser(
|
|
description='Runs clang-format on C++/JS files in the repository.')
|
|
parser.add_argument(
|
|
'--base', type=str, default='main',
|
|
help='Git ref to diff against, or "none" if the whole repository is to '
|
|
'be reformatted (default: %(default)s)')
|
|
parser.add_argument(
|
|
'--check-only', action='store_true',
|
|
help='When specified, files are only checked for formatting, but no '
|
|
'edits are made automatically. Non-zero exit code will indicate at '
|
|
'least one formatting issue.')
|
|
return parser.parse_args()
|
|
|
|
def get_file_paths(args):
|
|
return find_files_for_linting.find_files_for_linting(
|
|
patterns=FILE_MASKS, diff_base=args.base)
|
|
|
|
def run_clang_format(path, args):
|
|
command = ['clang-format', '-i'] + FORMAT_OPTIONS
|
|
if args.check_only:
|
|
command += CHECK_ONLY_OPTIONS
|
|
command += [path]
|
|
return subprocess.call(command) == 0
|
|
|
|
def main():
|
|
args = parse_command_line_args()
|
|
paths = get_file_paths(args)
|
|
return 0 if all([run_clang_format(path, args) for path in paths]) else 1
|
|
|
|
if __name__ == '__main__':
|
|
sys.exit(main())
|