The macOS packager treated each library install name as a load command, so
@executable_path self-ids failed the portability check. FreeBSD configure
requires Qt6 Charts and Svg. Android libretro could not link the prebuilt
OpenSSL archive until Poly1305 SVE2 binds locally, matching yuzu-android.
* feat(export): bake separate update/DLC dumps into standalone snapshots
Resolve base ROM plus picked update/DLC files and optional NAND-installed
add-ons through PatchManager at export time, so packaged exefs and
romfs.bin are the patched snapshot AOT recompiles. Dump decrypted AOC
next to the package and serve it from the deconstructed loader so the
standalone runtime does not need post-export NAND installs.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* fix(export): rename AOC dir local to unshadow loader member
-Werror=shadow failed Linux tests and macOS MoltenVK: the baked-AOC
scan used a local `name` that collided with AppLoader_DeconstructedRomDirectory::name.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* fix(export): fail closed on bake errors; honest ExeFS/AOC status
HOLD on PR 29: OnExport ignored session failures, directory ROMs could
claim an update bake after PatchExeFS(nullptr), empty exefs/ blocked the
Windows extract fallback, and aoc:u Count used the raw program id.
- Abort export on Resolve/ok()/unreadable extras; keep bake status
- Pass directory ExeFS into PatchManager; only list updates that applied
- Do not mkpath empty exefs/; extract fallback on all platforms; refuse
DLC without main
- CountAddOnContent uses GetBaseTitleID like ListAddOnContent
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* fix(export): refuse mixed directory+update snapshots; unbreak macOS
HOLD re-review on 363f352:
- Fail closed when an update is present but RomFS cannot BKTR without a
Program NCA (directory dumps). Do not list Update over base romfs.bin.
- Do not create exefs/ for romfs.bin alone; never FillMissing unpatched
main next to dumped AOC; honor extract/package failures.
- Drop static forward decls that Clang treated as extra overloads
(DumpVirtualDir/ExtractExeFsFromRom ambiguous on macOS).
- Always remove .aot_work_* on export failure via RAII.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* fix(export): drop unused ExtractRomFsFromRom; require PatchManager replace
- Delete dead static ExtractRomFsFromRom (-Werror=unused on ENABLE_QT=ON)
- Count update as applied only when PatchExeFS/PatchRomFS return a
different handle than the base input, not a side NCA open
- Refuse-path status is the error only (not "base game only")
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* test(export): drop Core::System Resolve cases that SIGSEGV in CI
Linux tests on ea6d1a7 crashed in ExportContentSession Resolve after
System::Initialize. Keep header-only bake helpers; live Resolve still
needs a fuller emulator fixture.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* fix(export): stop Linux tests spinning 1500s; refuse-path status is the error
CoreTiming tests busy-waited while(HasPendingEvents()) with no deadline.
346d452 hung after Catch2's seed line until CTest's 1500s default. Bound
that wait to 5s, cap the tests target at 180s, and stream --durations.
Resolve error paths now set status to the error (not "base game only").
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* test(ci): name Catch2 hangs; yield fiber handshake spins
346d452 Linux tests timed out at 1500s with only Catch2's seed line
because ctest captured stdout. Run bin/tests directly with -s /
--durations, split [export] vs the rest, and cap each at 30s/90s.
Fibers::InterExchange busy-waited on atomics with no yield; on a
2-vCPU runner that can starve the handshake. Yield and 5s deadline.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* test(ci): name Catch2 cases at start; fiber timeout yields home
Drop -s (lazy headers still hide hangs; RingBuffer -s floods Actions).
Print+flush the case name from a testCaseStarting listener; keep
--durations yes --order decl.
On InterExchange handshake expiry, YieldTo this thread's home fiber
and return so join() completes and REQUIRE_FALSE can fail closed.
Do not YieldTo the partner (fiber mutex deadlock).
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* fix(core_timing): join host timer without a lost wakeup
Linux tests on a784eaf named CoreTiming[BasicOrderNoPausing] then
SIGTERM at the 90s GNU timeout. WaitForTimingIdle had already
returned; ~CoreTiming join hung because Reset Set() the events
before request_stop, so the thread could Wait() again with the
signal consumed. Stop first, then wake; skip pause_event.Wait
once the stop token is set.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* test(recompiler): pin instruction correctness vs Dynarmic + x86-64 sanitizers
Expand backlog #4 coverage: hosted Translate C vs independent ARM arithmetic
(edge cases and randomized inputs) in homebrew_harness, and Translate AOT vs
in-tree Dynarmic on the same encodings in recomp_stack_harness.
ANDS/BICS/TST now update N/Z only (C/V unchanged when the shifter is idle),
matching Dynarmic and the ARM ARM.
Wire ASan+UBSan via -DSUYU_ENABLE_SANITIZERS / -DYUZU_ENABLE_SANITIZERS and a
Linux x86-64 tests.yml job. Nested probe/AOT compiles inherit the flags.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* test(recompiler): compare ANDS NZCV vs Dynarmic on N/Z only
AOT preserves incoming C/V when ANDS shift amount is 0 (ARM ARM). Dynarmic
reports C=V=0 on the same block, so the stack pin matches N/Z (and GPRs)
rather than treating Dynarmic C/V as the architectural reference.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* fix(recompiler): ANDS AOT writes C=V=0 to match A64/Dynarmic
Restore recomp_set_flags(add, result, 0, result) for ANDS/BICS/TST so
generated code clears C and V instead of leaving them stale. Drop the
N/Z-only Dynarmic mask; homebrew pins ands.c_cleared/v_cleared against a
C=V=1 preset so a stale emit fails.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* test(recompiler): real ArmRecomp+Dynarmic+kernel stack harness
Add recomp_stack_harness that boots a minimal System, creates an
application KProcess with in-tree fixture bytes, and drives ArmRecomp
RunThread/StepThread against real ApplicationMemory and Dynarmic JIT
fallback. Proves SVC parking, TLS/TPIDRRO, cross-page stores, AOT miss
and unhandled->Dynarmic transitions, icache invalidation, restart, and
StepThread fallback.
Keep homebrew_harness as the no-deps stub smoke; fix Windows helpers
under #ifdef so full-tree -Werror builds. Wire the new target into Linux
tests CI.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* fix(recompiler): wire SetRecompLookup AOT + real icache asserts
Path-1 Hashbrown HOLD: process ArmInterface is ArmRecomp via SetRecompLookup
before init; Translate'd AOT + matching guest RX; LoadContext alone publishes
TPIDRRO; registered-PC force-miss; ClearInstructionCache refuses AOT.
Also: InvalidateCacheRange no longer permanently kills AOT (loader RX protect
was rejecting every block before first insn); Dynarmic Clear/Invalidate resets
MemoryReadCode page cache so rewritten guest RX is visible after Clear.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* test(ci): add release publication gate regression
Drive the Publish Release job the way GitHub Actions would. The check
evaluates job `if`/`needs` from `.github/workflows/release.yml` and runs
the job's shell against a stub `gh`. Required platform failures still
publish. The rolling `v0.04-latest` tag is deleted before the empty
artifact check. The release notes have no commit, toolchain, or checksum
metadata.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* fix(ci): gate release publish on required results
Replace if: always() with !cancelled() plus required job results so a
Windows, Linux, macOS, Android, or libretro failure cannot replace a
release. Keep FreeBSD and libretro-android optional. Stop deleting
v0.04-latest. Publish v0.04-<date>-<sha> with commit, toolchain, and
SHA-256 metadata. Call exporter smoke and the Catch2 tests from both
pull-request CI and the release needs list.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* chore(ci): drop leftover always() lecture from the gate check
Delete the module docstring that still taught if: always() after
release.yml stopped using it. GitHub's default success() wrap lives in
apply_github_default_success. Publish is forbidden from deleting a tag
at all, not only from deleting before the empty check.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* test(ci): reject gh prerelease as latest
GitHub returns HTTP 422 Latest release cannot be draft or prerelease
when gh release create passes --prerelease with --latest, then runs
cleanupDraftRelease. The gate stub now fails the same way.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
* fix(ci): stop marking prereleases as latest
Remove --latest from publish_release.sh. GitHub forbids a prerelease
from being the latest release and gh then deletes the draft.
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Dallin Bland <SourCreamCulture@users.noreply.github.com>
Dallin Bland
