If a `Go On A Ghost Hunt` Boo is killed while it has a gravity of -1 (at the bottom of its oscillation), and does not hit a wall, it will keep the same negative gravity and continue moving until the textbox is closed. Boo Y speed isn't capped in this scenario, so the constant -1 gravity leads to the boo moving upwards at an increasing rate.
This leads to issues in `boo_act_4`. The distance eventually increases to a point where the boo object is too far to be returned in `cur_obj_nearest_object_with_behavior`.
This can have 2 buggy effects:
- the wrong dialog box being brought up if the textbox is delayed (easiest to do by hanging on a ledge).
- the puzzle solved jingle being played incorrectly if you wait in the textbox long enough
This doesn't actually cause issues with King Boo, it just brings up the wrong text box. King Boo spawning is unaffected by this bug.
The fix is to stop the boo after the death animation has finished playing, stopping the boo from accelerating upwards. I don't believe this to cause any other issues (the boo is already dead after all!)
Thanks to Kyman for finding this bug.
* Fixed one or two bugs, cleaned up a few things, put every non vanilla styled change into POLISHED_TRANSITIONS
And renamed set_and_reset_transition_fade_timer
* Undid the renaming of set_and_reset_transition_fade_timer as suggested
* add displaylist macros
* implement displaylist macro in memory.c
* API update
* implement displaylist macro on all 'hot' code paths
* Remove the macro entirely
* rename tmpDL
* remove the other two macros
* catch the last 2 missing statements
---------
Co-authored-by: someone2639 <someone2639@gmail.com>
* math util cleanup
* clean up min/max 3 and also distance and angle functions
* improve pipelining and make macros safe
* macros safer and cleaned approaches
* fix build
* made sure puppycam builds (and fixed unused var warnings)
* added 32 bit mins and maxs
* removed extraneous mat stack index decrement in geo_process_camera (#708)
* Fixed typo in FCR enums (#707)
* v2.1.1
---------
Co-authored-by: Matt Pharoah <mtpharoah@gmail.com>
