Rangi
4522162d45
Consistent labels for each nickname in RAM
2021-03-17 16:38:21 -04:00
Rangi
40902ffe24
Verify data table sizes with table_width and assert_table_length macros
...
This was discussed in #706
It also uncovered some off-by-one issues with defining some constants.
A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
2021-03-04 00:15:03 -05:00
Rangi
99e66c2557
Rename some labels
...
- Remove "Buffer" suffix from some byte and word quantities
- Change "Ptr" to "Pointer"
Fixes #789
2020-12-23 16:29:30 -05:00
Rangi
9b3c45b14d
Resolve some "???" comments
2020-11-17 11:09:02 -05:00
Rangi
7254c10093
Identify remaining uses of wBuffer1-6 as general-purpose HP buffers or mobile
2020-11-03 23:25:22 -05:00
Rangi
826e070f04
More syncing with pokegold
2020-11-03 10:13:06 -05:00
Rangi
ba5bc304f9
Updates to more closely sync with pokegold
2020-10-29 23:23:57 -04:00
Rangi
bcc0d633e9
Identify the remaining (non-mobile) uses of another WRAM union
2020-10-29 14:51:41 -04:00
Rangi
9dcdad5e60
Comment, remove, or revise many unreferenced labels
2020-10-26 20:29:58 -04:00
Rangi
306c85750e
Identify some more unnamed labels
2020-10-04 20:10:39 -04:00
Rangi
cf37abd3ec
Remove wKickCounter and wPresentPower aliases for wBattleAnimParam
2020-08-29 20:35:49 -04:00
Rangi
75035a71a5
Label some mobile addresses, and revise some comments
2020-06-13 18:48:26 -04:00
Rangi
0345e4fb0e
Add suffixes to some constants to avoid ambiguity
...
- `PSYCHIC` → `PSYCHIC_TYPE` (not the trainer `PSYCHIC_T` or the move `PSYCHIC_M`)
- `BLACKBELT` → `BLACKBELT_I` (not the trainer `BLACKBELT_T`)
- `CURSE_T` → `CURSE_TYPE` (not the move `CURSE`)
- `TOWN_MAP_D` → `TOWN_MAP_POSTER` (not the item `TOWN_MAP`)
This also uncovered a misidentified event: `EVENT_DECO_PLANT_4` → `EVENT_DECO_POSTER_1`. (There are three plants and four posters.)
2020-03-21 17:59:26 -04:00
Rangi
0cce00cb73
Document a bug where Teleport cannot fail for wild Pokémon
2020-02-28 11:17:58 -05:00
mid-kid
e3e0bcd653
#641 fixes and additions. ( #646 )
...
Name a lot of text labels according to our conventions
2019-10-20 18:24:17 -04:00
mid-kid
3e78e5b2b6
TextBox -> Textbox
...
Homogenizing names.
2019-04-09 16:09:18 +02:00
Rangi
1853e3d127
Say "BANK(Foo) ; aka BANK(Bar)" to clarify that Foo and Bar share a bank
2019-01-12 15:17:20 -05:00
mid-kid
930d285fab
Fix comments around BANK() statements
...
Found a couple BANK()s that reference multiple labels.
2018-12-26 21:58:13 +01:00
mid-kid
c210f052a8
Move BattleSideCopy to transform.asm
2018-11-21 14:14:34 +01:00
Rangi
557ce82073
hQuotient is a four-byte buffer ( fixes #558 )
2018-08-26 13:49:38 -04:00
Rangi
eb1e3636bb
Use labels instead of constants for HRAM
...
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 14:28:22 -04:00
mid-kid
bc0595564e
Fix constants in BattleCommand_MirrorCoat
2018-08-07 09:46:21 +02:00
Rangi
9dec80b07e
Add meaningful aliases for wd265
...
Introduce MONICON_* constants
Introduce BATTLEPLAYERACTION_* constants
2018-07-29 00:25:52 -04:00
Rangi
4f0c9cecf9
StringCmp → CompareBytes; CompareLong → CompareBytesLong
...
hStringCmpString[1/2] → h[EnemyMon/PartyMon1]Speed
2018-07-23 00:25:53 -04:00
IIMarckus
8aebc7ba56
Merge branch 'master' of hyperdriveguy/pokecrystal
2018-07-21 00:41:56 -06:00
