pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-09-08 08:13:02 -07:00
Code Issues Packages Projects Releases Wiki Activity

Use labels instead of constants for HRAM

Browse Source 
Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
This commit is contained in:
Rangi
2018-08-25 14:28:22 -04:00
parent 376c64468b
commit eb1e3636bb
243 changed files with 4706 additions and 4661 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
engine/tilesets/timeofday_pals.asm
View File

@@ -43,11 +43,11 @@ _TimeOfDayPals::
ld hl, wBGPals1 palette PAL_BG_TEXT
; save wram bank
ld a, [rSVBK]
ldh a, [rSVBK]
ld b, a
ld a, BANK(wBGPals1)
ld [rSVBK], a
ldh [rSVBK], a
; push palette
ld c, NUM_PAL_COLORS
@@ -62,7 +62,7 @@ _TimeOfDayPals::
; restore wram bank
ld a, b
ld [rSVBK], a
ldh [rSVBK], a
; update sgb pals
ld b, SCGB_MAPPALS
@@ -72,11 +72,11 @@ _TimeOfDayPals::
ld hl, wOBPals1 - 1 ; last byte in wBGPals1
; save wram bank
ld a, [rSVBK]
ldh a, [rSVBK]
ld d, a
ld a, BANK(wOBPals1)
ld [rSVBK], a
ldh [rSVBK], a
; pop palette
ld e, NUM_PAL_COLORS
@@ -91,7 +91,7 @@ _TimeOfDayPals::
; restore wram bank
ld a, d
ld [rSVBK], a
ldh [rSVBK], a
; update palettes
call _UpdateTimePals
@@ -158,10 +158,10 @@ FadeBlackQuickly:
ret
FillWhiteBGColor:
ld a, [rSVBK]
ldh a, [rSVBK]
push af
ld a, BANK(wBGPals1)
ld [rSVBK], a
ldh [rSVBK], a
ld hl, wBGPals1
ld a, [hli]
@@ -182,7 +182,7 @@ endr
jr nz, .loop
pop af
ld [rSVBK], a
ldh [rSVBK], a
ret
ReplaceTimeOfDayPals:
@@ -306,7 +306,7 @@ ConvertTimePalsDecHL:
GetTimePalFade:
; check cgb
ld a, [hCGB]
ldh a, [hCGB]
and a
jr nz, .cgb