pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-11-16 11:27:33 -08:00
Code Issues Packages Projects Releases Wiki Activity

Document weird code involving link trades of mew and celebi

Browse Source 
This piece of code is frankly rather confusing, as it seemingly doesn't
serve much of a purpose. Documenting it here for future reference.
This commit is contained in:
mid-kid 2020-08-19 13:32:11 +02:00
parent 0b31d12dac
commit e40f421ffb
1 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
engine/link/link.asm
View File

@ -1882,24 +1882,31 @@ LinkTrade:
call LoadTradeScreenBorder
call SetTradeRoomBGPals
farcall Link_WaitBGMap
ld b, $1
; Check if either of the Pokémon sent was a Mew or Celebi, and send a different
; byte depending on that. Presumably this would've been some prevention against
; illicit trade machines, but it doesn't seem like a very effective one.
; Removing this code breaks link compatibility with the vanilla gen2 games, but
; has otherwise no consequence.
ld b, 1
pop af
ld c, a
cp MEW
jr z, .loop
jr z, .send_checkbyte
ld a, [wCurPartySpecies]
cp MEW
jr z, .loop
ld b, $2
jr z, .send_checkbyte
ld b, 2
ld a, c
cp CELEBI
jr z, .loop
jr z, .send_checkbyte
ld a, [wCurPartySpecies]
cp CELEBI
jr z, .loop
ld b, $0
jr z, .send_checkbyte
.loop
; Send the byte in a loop until the desired byte has been received.
ld b, 0
.send_checkbyte
ld a, b
ld [wPlayerLinkAction], a
push bc
@ -1913,7 +1920,7 @@ LinkTrade:
jr z, .save
ld a, [wOtherPlayerLinkAction]
cp b
jr nz, .loop
jr nz, .send_checkbyte
.save
farcall SaveAfterLinkTrade