pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-09-08 08:13:02 -07:00
Code Issues Packages Projects Releases Wiki Activity

Every diff line starts with +, -, or space

Browse Source
This commit is contained in:
Rangi
2018-07-29 19:35:37 -04:00
parent 366330e981
commit e346cc7b41
1 changed files with 42 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
docs/design_flaws.md
View File

@@ -161,12 +161,12 @@ Modify `GetFrontpicPointer`:
ld d, BANK(PokemonPicPointers)
jr .ok
.unown
.unown
ld a, [wUnownLetter]
+ ld hl, UnownPicPointers
ld d, BANK(UnownPicPointers)
.ok
.ok
- ld hl, PokemonPicPointers ; UnownPicPointers
dec a
ld bc, 6
@@ -175,7 +175,7 @@ Modify `GetFrontpicPointer`:
And `GetMonBackpic`:
```asm
```diff
- ; These are assumed to be at the same address in their respective banks.
- ld hl, PokemonPicPointers ; UnownPicPointers
ld a, b
@@ -186,7 +186,7 @@ And `GetMonBackpic`:
ld a, c
+ ld hl, UnownPicPointers
ld d, BANK(UnownPicPointers)
.ok
.ok
dec a
ld bc, 6
call AddNTimes
@@ -359,8 +359,8 @@ Move `ITEM_C3` and `ITEM_DC` above all the TMs in every table of item data.
Modify engine/items/items.asm:
```diff
GetTMHMNumber::
; Return the number of a TM/HM by item id c.
GetTMHMNumber::
; Return the number of a TM/HM by item id c.
ld a, c
-; Skip any dummy items.
- cp ITEM_C3 ; TM04-05
@@ -376,8 +376,8 @@ GetTMHMNumber::
ld c, a
ret
GetNumberedTMHM:
; Return the item id of a TM/HM by number c.
GetNumberedTMHM:
; Return the item id of a TM/HM by number c.
ld a, c
-; Skip any gaps.
- cp ITEM_C3 - (TM01 - 1)