pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-11-16 11:27:33 -08:00
Code Issues Packages Projects Releases Wiki Activity

Create empty sections for the remaining FixPicBank array entries

Browse Source
This commit is contained in:
Rangi 2018-06-03 23:25:21 -04:00
parent 7cd5bcbae4
commit c7bb2d15cf
4 changed files with 33 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/design_flaws.md
View File

@ -66,11 +66,11 @@ GLOBAL PICS_FIX
db BANK("Pics 17") ; BANK("Pics 1") + 16
db BANK("Pics 18") ; BANK("Pics 1") + 17
db BANK("Pics 19") ; BANK("Pics 1") + 18
db BANK("Pics 1") + 19
db BANK("Pics 1") + 20
db BANK("Pics 1") + 21
db BANK("Pics 1") + 22
db BANK("Pics 1") + 23
db BANK("Pics 20") ; BANK("Pics 1") + 19
db BANK("Pics 21") ; BANK("Pics 1") + 20
db BANK("Pics 22") ; BANK("Pics 1") + 21
db BANK("Pics 23") ; BANK("Pics 1") + 22
db BANK("Pics 24") ; BANK("Pics 1") + 23
```
**Fix:** Use `dba` instead of `dba_pic`, delete `FixPicBank`, and remove all four calls to `FixPicBank`.

10
engine/gfx/load_pics.asm
View File

@ -282,11 +282,11 @@ GLOBAL PICS_FIX
db BANK("Pics 17") ; BANK("Pics 1") + 16
db BANK("Pics 18") ; BANK("Pics 1") + 17
db BANK("Pics 19") ; BANK("Pics 1") + 18
db BANK("Pics 1") + 19
db BANK("Pics 1") + 20
db BANK("Pics 1") + 21
db BANK("Pics 1") + 22
db BANK("Pics 1") + 23
db BANK("Pics 20") ; BANK("Pics 1") + 19
db BANK("Pics 21") ; BANK("Pics 1") + 20
db BANK("Pics 22") ; BANK("Pics 1") + 21
db BANK("Pics 23") ; BANK("Pics 1") + 22
db BANK("Pics 24") ; BANK("Pics 1") + 23
Function511ec: ; 511ec
ld a, c

18
gfx/pics.asm
View File

@ -793,3 +793,21 @@ INCBIN "gfx/pokemon/unown_y/back.2bpp.lz"
INCBIN "gfx/pokemon/unown_p/back.2bpp.lz"
INCBIN "gfx/pokemon/unown_i/back.2bpp.lz"
INCBIN "gfx/pokemon/unown_r/back.2bpp.lz"
; Sections "Pics 20" to "Pics 24" are not used for any graphics,
; but entries for their banks exist in FixPicBank (see engine/gfx/load_pics.asm).
SECTION "Pics 20", ROMX
SECTION "Pics 21", ROMX
SECTION "Pics 22", ROMX
SECTION "Pics 23", ROMX
SECTION "Pics 24", ROMX

5
pokecrystal.link
View File

@ -234,17 +234,22 @@ ROMX $5a
"Pics 19"
ROMX $5b
"bank5B"
"Pics 20"
ROMX $5c
"Mobile 5C"
"Pics 21"
ROMX $5d
"Crystal Phone Text 2"
"Pics 22"
ROMX $5e
"UpdateBattleHUDs"
"Songs 5"
"Crystal Sound Effects"
"Mobile 5E"
"Pics 23"
ROMX $5f
"Mobile 5F"
"Pics 24"
ROMX $60
"Map Scripts 13"
"Pokedex Entries 001-064"