Label all of PARTYMENUACTION_*

It's pretty clear what it's used for.
PartyMenuActionText is used for two things:
1) Storing what kind of action we're going to do (<$10)
2) Storing the text for some kind of healing stuff I'm not entirely sure (>=$f0)

In the former case, if GetPartyMenuTilemapPointers is ran, it will be
used to pick a sequence of actions that should be done, specified in the
table, and it'll print the corresponding string using the
PartyMenuStrings table. The items in the sequence of actions that should
be done are in WritePartyMenuTilemap.

Strangely enough, one possible value is left completely unused:
PARTYMENUACTION_GIVE_MON_FEMALE. It works in the exact same way as it's
male counterpart, and as such I don't believe it was used in the
japanese version either, since it doesn't matter which gender your 'mon
is when you put 'em in the daycare.
This commit is contained in:
mid-kid 2017-11-30 20:27:25 +01:00
parent 7a2a205281
commit a1fc73603e
8 changed files with 15 additions and 15 deletions

View File

@ -2995,7 +2995,7 @@ SelectBattleMon: ; 3d329
PickPartyMonInBattle: ; 3d33c PickPartyMonInBattle: ; 3d33c
.loop .loop
ld a, $2 ; Which PKMN? ld a, PARTYMENUACTION_SWITCH ; Which PKMN?
ld [PartyMenuActionText], a ld [PartyMenuActionText], a
call JumpToPartyMenuAndPrintText call JumpToPartyMenuAndPrintText
call SelectBattleMon call SelectBattleMon

View File

@ -416,16 +416,16 @@ ITEMMENU_CLOSE EQU 6
; PartyMenuActionText ; PartyMenuActionText
const_def const_def
const PARTYMENUACTION_00 const PARTYMENUACTION_CHOOSE_POKEMON
const PARTYMENUACTION_HEALING_ITEM const PARTYMENUACTION_HEALING_ITEM
const PARTYMENUACTION_02 const PARTYMENUACTION_SWITCH
const PARTYMENUACTION_TEACH_TM const PARTYMENUACTION_TEACH_TMHM
const PARTYMENUACTION_04 const PARTYMENUACTION_MOVE
const PARTYMENUACTION_EVO_STONE const PARTYMENUACTION_EVO_STONE
const PARTYMENUACTION_06 const PARTYMENUACTION_GIVE_MON
const PARTYMENUACTION_07 const PARTYMENUACTION_GIVE_MON_FEMALE ; unused
const PARTYMENUACTION_08 const PARTYMENUACTION_GIVE_ITEM
const PARTYMENUACTION_MOBILE const PARTYMENUACTION_MOBILE ; mobile
const_value set $f0 const_value set $f0
const PARTYMENUTEXT_HEAL_PSN const PARTYMENUTEXT_HEAL_PSN

View File

@ -39,7 +39,7 @@ NPCTrade:: ; fcba8
jr c, .done jr c, .done
; Select givemon from party ; Select givemon from party
ld b, 6 ld b, PARTYMENUACTION_GIVE_MON
callba SelectTradeOrDaycareMon callba SelectTradeOrDaycareMon
ld a, TRADE_CANCEL ld a, TRADE_CANCEL
jr c, .done jr c, .done

View File

@ -603,7 +603,7 @@ GiveItem: ; 103fd
push af push af
res NO_TEXT_SCROLL, a res NO_TEXT_SCROLL, a
ld [Options], a ld [Options], a
ld a, $8 ld a, PARTYMENUACTION_GIVE_ITEM
ld [PartyMenuActionText], a ld [PartyMenuActionText], a
call ClearBGPalettes call ClearBGPalettes
callba LoadPartyMenuGFX callba LoadPartyMenuGFX

View File

@ -745,7 +745,7 @@ SwitchPartyMons: ; 12aec
callba HoldSwitchmonIcon callba HoldSwitchmonIcon
callba InitPartyMenuNoCancel callba InitPartyMenuNoCancel
ld a, 4 ld a, PARTYMENUACTION_MOVE
ld [PartyMenuActionText], a ld [PartyMenuActionText], a
callba WritePartyMenuTilemap callba WritePartyMenuTilemap
callba PrintPartyMenuText callba PrintPartyMenuText

View File

@ -80,7 +80,7 @@ ChooseMonToLearnTMHM_NoRefresh: ; 2c80a
callba LoadPartyMenuGFX callba LoadPartyMenuGFX
callba InitPartyMenuWithCancel callba InitPartyMenuWithCancel
callba InitPartyMenuGFX callba InitPartyMenuGFX
ld a, $3 ; TeachWhichPKMNString ld a, PARTYMENUACTION_TEACH_TMHM
ld [PartyMenuActionText], a ld [PartyMenuActionText], a
.loopback .loopback
callba WritePartyMenuTilemap callba WritePartyMenuTilemap

View File

@ -123,7 +123,7 @@ DayCareAskDepositPokemon: ; 16798
jr c, .OnlyOneMon jr c, .OnlyOneMon
ld a, DAYCARETEXT_WHICH_ONE ld a, DAYCARETEXT_WHICH_ONE
call PrintDayCareText call PrintDayCareText
ld b, 6 ld b, PARTYMENUACTION_GIVE_MON
callba SelectTradeOrDaycareMon callba SelectTradeOrDaycareMon
jr c, .Declined jr c, .Declined
ld a, [CurPartySpecies] ld a, [CurPartySpecies]

View File

@ -316,7 +316,7 @@ Function4aa25: ; 4aa25
call Function4aad3 call Function4aad3
Function4aa34: ; 4aa34 Function4aa34: ; 4aa34
ld a, $9 ld a, PARTYMENUACTION_MOBILE
ld [PartyMenuActionText], a ld [PartyMenuActionText], a
callba WritePartyMenuTilemap callba WritePartyMenuTilemap
xor a xor a