mirror of
https://gitlab.com/xCrystal/pokecrystal-board.git
synced 2024-09-09 09:51:34 -07:00
Clean up XXX comments for unused content
This commit is contained in:
parent
f27f79488a
commit
9a3088e50c
@ -246,45 +246,45 @@ SpriteAnimFrameData: ; 8d6e6
|
||||
frame SPRITE_ANIM_OAMSET_MAGNET_TRAIN_RED_2, 8, OAM_X_FLIP
|
||||
dorestart
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
frame SPRITE_ANIM_OAMSET_43, 8
|
||||
frame SPRITE_ANIM_OAMSET_44, 8
|
||||
dorestart
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
frame SPRITE_ANIM_OAMSET_45, 8
|
||||
frame SPRITE_ANIM_OAMSET_46, 8
|
||||
dorestart
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
frame SPRITE_ANIM_OAMSET_47, 8
|
||||
frame SPRITE_ANIM_OAMSET_48, 8
|
||||
dorestart
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
frame SPRITE_ANIM_OAMSET_49, 1
|
||||
frame SPRITE_ANIM_OAMSET_49, 1, OAM_X_FLIP
|
||||
frame SPRITE_ANIM_OAMSET_49, 1, OAM_X_FLIP, OAM_Y_FLIP
|
||||
frame SPRITE_ANIM_OAMSET_49, 1, OAM_Y_FLIP
|
||||
dorestart
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
frame SPRITE_ANIM_OAMSET_4A, 32
|
||||
endanim
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
frame SPRITE_ANIM_OAMSET_4B, 32
|
||||
endanim
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
frame SPRITE_ANIM_OAMSET_4C, 32
|
||||
endanim
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
frame SPRITE_ANIM_OAMSET_4D, 32
|
||||
endanim
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
frame SPRITE_ANIM_OAMSET_4E, 3
|
||||
dorepeat 3
|
||||
dorestart
|
||||
|
@ -863,8 +863,7 @@ ENDM
|
||||
ret
|
||||
; 8c7c9 (23:47c9)
|
||||
|
||||
Function8c7c9:
|
||||
; XXX
|
||||
Unreferenced_Function8c7c9:
|
||||
ld a, $1
|
||||
ld [hBGMapMode], a
|
||||
call WaitBGMap
|
||||
|
@ -8551,8 +8551,7 @@ InitEnemyWildmon: ; 3f607
|
||||
ret
|
||||
; 3f662
|
||||
|
||||
Function3f662: ; 3f662
|
||||
; XXX
|
||||
Unreferenced_Function3f662: ; 3f662
|
||||
ld hl, EnemyMonMoves
|
||||
ld de, wListMoves_MoveIndicesBuffer
|
||||
ld b, NUM_MOVES
|
||||
|
@ -2559,7 +2559,7 @@ BillsPC_ChangeBoxSubmenu: ; e36f9 (38:76f9)
|
||||
ret
|
||||
; e3778 (38:7778)
|
||||
|
||||
hlcoord 11, 7 ; XXX
|
||||
hlcoord 11, 7 ; unused
|
||||
|
||||
.MenuDataHeader: ; 0xe377b
|
||||
db $40 ; flags
|
||||
|
@ -78,8 +78,7 @@ CheckContestMon:
|
||||
and a
|
||||
ret
|
||||
|
||||
Function8aa4:
|
||||
; XXX
|
||||
Unreferenced_Function8aa4:
|
||||
push de
|
||||
push bc
|
||||
ld hl, PalPacket_9ce6
|
||||
@ -180,8 +179,7 @@ Function8b3f:
|
||||
ld hl, BlkPacket_9a86
|
||||
jp PushSGBPals_
|
||||
|
||||
Function8b4d:
|
||||
; XXX
|
||||
Unreferenced_Function8b4d:
|
||||
call CheckCGB
|
||||
jr nz, .cgb
|
||||
ld a, [hSGB]
|
||||
@ -196,8 +194,7 @@ Function8b4d:
|
||||
call GetPredefPal
|
||||
jp LoadHLPaletteIntoDE
|
||||
|
||||
Function8b67:
|
||||
; XXX
|
||||
Unreferenced_Function8b67:
|
||||
call CheckCGB
|
||||
jr nz, .cgb
|
||||
ld a, [hSGB]
|
||||
@ -212,8 +209,7 @@ Function8b67:
|
||||
call GetPredefPal
|
||||
jp LoadHLPaletteIntoDE
|
||||
|
||||
Function8b81:
|
||||
; XXX
|
||||
Unreferenced_Function8b81:
|
||||
call CheckCGB
|
||||
jr nz, .cgb
|
||||
ld a, [hSGB]
|
||||
@ -281,8 +277,7 @@ got_palette_pointer_8bd7
|
||||
call LoadPalette_White_Col1_Col2_Black
|
||||
ret
|
||||
|
||||
Function8bec:
|
||||
; XXX
|
||||
Unreferenced_Function8bec:
|
||||
ld a, [hCGB]
|
||||
and a
|
||||
jr nz, .cgb
|
||||
@ -455,8 +450,7 @@ INCLUDE "data/palettes/mail.pal"
|
||||
|
||||
INCLUDE "engine/cgb_layouts.asm"
|
||||
|
||||
Function95f0:
|
||||
; XXX
|
||||
Unreferenced_Function95f0:
|
||||
ld hl, .Palette
|
||||
ld de, wBGPals1
|
||||
ld bc, 1 palettes
|
||||
@ -768,8 +762,7 @@ Function9779: mobile
|
||||
BattleObjectPals:
|
||||
INCLUDE "data/palettes/battle_objects.pal"
|
||||
|
||||
Function97cc:
|
||||
; XXX
|
||||
Unreferenced_Function97cc:
|
||||
call CheckCGB
|
||||
ret z
|
||||
ld a, $90
|
||||
@ -979,8 +972,7 @@ _InitSGBBorderPals:
|
||||
dw PalPacket_9dd6
|
||||
dw PalPacket_9de6
|
||||
|
||||
Function9911:
|
||||
; XXX
|
||||
Unreferenced_Function9911:
|
||||
di
|
||||
xor a
|
||||
ld [rJOYP], a
|
||||
|
@ -112,7 +112,7 @@ Mobile_ReloadMapPart: ; 104099
|
||||
ret
|
||||
; 1040d4
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
ld hl, .unreferenced_1040da
|
||||
jp CallInSafeGFXMode
|
||||
|
||||
@ -136,7 +136,7 @@ Mobile_ReloadMapPart: ; 104099
|
||||
ret
|
||||
; 1040fb
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
ld hl, .unreferenced_104101
|
||||
jp CallInSafeGFXMode
|
||||
|
||||
|
@ -163,7 +163,7 @@ Kurt_SelectQuantity: ; 880c2
|
||||
db 09, 06 ; start coords
|
||||
db 12, 19 ; end coords
|
||||
|
||||
db 0, 0, -1, 0 ; XXX
|
||||
db 0, 0, -1, 0 ; unused
|
||||
|
||||
.PlaceApricornName: ; 88116
|
||||
call MenuBoxCoord2Tile
|
||||
|
@ -217,7 +217,7 @@ endr
|
||||
|
||||
INCLUDE "data/items/mom_phone.asm"
|
||||
|
||||
db 0, 0, 0 ; XXX
|
||||
db 0, 0, 0 ; unused
|
||||
|
||||
_MomText_HiHowAreYou: ; 0xfd1b1
|
||||
; Hi, ! How are you?
|
||||
@ -255,10 +255,10 @@ _MomText_ItsInRoom: ; 0xfd1ca
|
||||
db "@"
|
||||
; 0xfd1cf
|
||||
|
||||
db 0 ; XXX
|
||||
db 0 ; unused
|
||||
|
||||
Predef3A: ; fd1d0
|
||||
ret
|
||||
; fd1d1
|
||||
|
||||
ret ; XXX
|
||||
ret ; unused
|
||||
|
@ -1749,7 +1749,7 @@ Script_GetOnBike_Register: ; 0xd14e
|
||||
special ReplaceKrisSprite
|
||||
end
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
nop
|
||||
ret
|
||||
|
||||
|
@ -333,7 +333,7 @@ EvolveAfterBattle_MasterLoop
|
||||
inc hl
|
||||
jp .loop
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
pop hl
|
||||
.ReturnToMap:
|
||||
pop de
|
||||
|
@ -725,8 +725,7 @@ MailGFX_PlaceMessage: ; b9803
|
||||
jp PlaceString
|
||||
; b984e
|
||||
|
||||
Functionb984e: ; b984e
|
||||
; XXX
|
||||
Unreferenced_Functionb984e: ; b984e
|
||||
.loop
|
||||
ld a, [hl]
|
||||
xor $ff
|
||||
|
@ -324,8 +324,7 @@ ListMovePP: ; 50c50
|
||||
jr nz, .load_loop
|
||||
ret
|
||||
|
||||
Function50cd0: ; 50cd0
|
||||
; XXX
|
||||
Unreferenced_Function50cd0: ; 50cd0
|
||||
.loop
|
||||
ld [hl], $32
|
||||
inc hl
|
||||
|
@ -1795,7 +1795,7 @@ InitNickname: ; e3de
|
||||
pop hl
|
||||
ld de, StringBuffer1
|
||||
call InitName
|
||||
ld a, $4 ; XXX could this be in bank 4 in pokered?
|
||||
ld a, $4 ; ExitAllMenus is in bank 0, XXX could this be in bank 4 in pokered?
|
||||
ld hl, ExitAllMenus
|
||||
rst FarCall
|
||||
ret
|
||||
|
@ -739,7 +739,7 @@ NamingScreen_AdvanceCursor_CheckEndOfString: ; 11b27
|
||||
|
||||
; 11b39 (4:5b39)
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
ld a, [wNamingScreenCurrNameLength]
|
||||
and a
|
||||
ret z
|
||||
@ -1434,7 +1434,7 @@ MailComposition_TryAddLastCharacter: ; 121ac (4:61ac)
|
||||
|
||||
; 121b2 (4:61b2)
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
ld a, [wNamingScreenCurrNameLength]
|
||||
and a
|
||||
ret z
|
||||
|
@ -695,7 +695,7 @@ PokeAnim_ConvertAndApplyBitmask: ; d036b
|
||||
ret
|
||||
; d03f4
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
db 6, 5, 4
|
||||
|
||||
.GetTilemap: ; d03f7
|
||||
|
@ -1,5 +1,4 @@
|
||||
Function88248: ; 88248
|
||||
; XXX
|
||||
Unreferenced_Function88248: ; 88248
|
||||
ld c, CAL
|
||||
ld a, [wPlayerGender]
|
||||
bit 0, a
|
||||
|
@ -1309,7 +1309,7 @@ PokegearPhoneContactSubmenu: ; 91342 (24:5342)
|
||||
|
||||
; 9146e
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
ld a, [hHours]
|
||||
cp 12
|
||||
jr c, .am
|
||||
@ -1499,7 +1499,7 @@ UpdateRadioStation: ; 9166f (24:566f)
|
||||
|
||||
; 916a1 (24:56a1)
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
ld [wPokegearRadioChannelBank], a
|
||||
ld a, [hli]
|
||||
ld [wPokegearRadioChannelAddr], a
|
||||
@ -2932,7 +2932,7 @@ INCBIN "gfx/pokegear/dexmap_nest_icon.2bpp"
|
||||
FlyMapLabelBorderGFX: ; 922e1
|
||||
INCBIN "gfx/pokegear/flymap_label_border.1bpp"
|
||||
|
||||
; XXX
|
||||
Unreferenced_Function92311:
|
||||
xor a
|
||||
ld [wTownMapPlayerIconLandmark], a
|
||||
call ClearBGPalettes
|
||||
|
@ -596,8 +596,7 @@ PlacePrinterStatusString: ; 84785
|
||||
ret
|
||||
; 847bd
|
||||
|
||||
Function847bd: ; 847bd
|
||||
; XXX
|
||||
Unreferenced_Function847bd: ; 847bd
|
||||
ld a, [wPrinterStatus]
|
||||
and a
|
||||
ret z
|
||||
|
@ -165,7 +165,7 @@ _PrintNum:: ; c4c7
|
||||
dec e
|
||||
jr nz, .money_leading_zero
|
||||
inc hl
|
||||
ld [hl], $f2 ; XXX
|
||||
ld [hl], "<DOT>"
|
||||
|
||||
.money_leading_zero
|
||||
call .AdvancePointer
|
||||
|
@ -1,5 +1,4 @@
|
||||
Function1dd6a9: ; 1dd6a9
|
||||
; XXX
|
||||
Unreferenced_Function1dd6a9: ; 1dd6a9
|
||||
ld a, b
|
||||
ld b, c
|
||||
ld c, a
|
||||
|
@ -1,4 +1,4 @@
|
||||
StopRTC: ; Unreferenced???
|
||||
StopRTC: ; Unreferenced
|
||||
ld a, SRAM_ENABLE
|
||||
ld [MBC3SRamEnable], a
|
||||
call LatchClock
|
||||
|
@ -415,8 +415,7 @@ EraseHallOfFame: ; 14d06
|
||||
jp CloseSRAM
|
||||
; 14d18
|
||||
|
||||
Function14d18: ; 14d18
|
||||
; XXX
|
||||
Unreferenced_Function14d18: ; 14d18
|
||||
; copy .Data to SRA4:a007
|
||||
ld a, $4
|
||||
call GetSRAMBank
|
||||
@ -452,8 +451,7 @@ SaveData: ; 14d68
|
||||
ret
|
||||
; 14d6c
|
||||
|
||||
Function14d6c: ; 14d6c
|
||||
; XXX
|
||||
Unreferenced_Function14d6c: ; 14d6c
|
||||
ld a, $4
|
||||
call GetSRAMBank
|
||||
ld a, [$a60b]
|
||||
@ -469,8 +467,7 @@ Function14d6c: ; 14d6c
|
||||
ret
|
||||
; 14d83
|
||||
|
||||
Function14d83: ; 14d83
|
||||
; XXX
|
||||
Unreferenced_Function14d83: ; 14d83
|
||||
ld a, $4
|
||||
call GetSRAMBank
|
||||
xor a
|
||||
@ -480,8 +477,7 @@ Function14d83: ; 14d83
|
||||
ret
|
||||
; 14d93
|
||||
|
||||
Function14d93: ; 14d93
|
||||
; XXX
|
||||
Unreferenced_Function14d93: ; 14d93
|
||||
ld a, $7
|
||||
call GetSRAMBank
|
||||
xor a
|
||||
|
@ -2852,7 +2852,7 @@ Script_loadbytec2cf:
|
||||
ld [wc2cf], a
|
||||
ret
|
||||
|
||||
ld c, c ; XXX
|
||||
ld c, c ; unused
|
||||
|
||||
Script_closetext:
|
||||
; script command 0x49
|
||||
|
@ -225,13 +225,13 @@ CheckUnusedTwoDayTimer: ; 1150c
|
||||
ret
|
||||
; 1151c
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
ld hl, wDailyFlags
|
||||
set 2, [hl]
|
||||
ret
|
||||
; 11522
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
and a
|
||||
ld hl, wDailyFlags
|
||||
bit 2, [hl]
|
||||
|
8
home.asm
8
home.asm
@ -552,7 +552,7 @@ CopyTilemapAtOnce:: ; 323d
|
||||
jr .CopyTilemapAtOnce
|
||||
; 323f
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
farcall HDMATransferAttrMapAndTileMapToWRAMBank3
|
||||
ret
|
||||
; 3246
|
||||
@ -1127,8 +1127,7 @@ Print8BitNumRightAlign:: ; 3842
|
||||
jp PrintNum
|
||||
; 384d
|
||||
|
||||
Function384d:: ; 384d
|
||||
; XXX
|
||||
Unreferenced_Function384d:: ; 384d
|
||||
; GetNthMove
|
||||
ld hl, wListMoves_MoveIndicesBuffer
|
||||
ld c, a
|
||||
@ -1321,8 +1320,7 @@ GetPartyLocation:: ; 3927
|
||||
jp AddNTimes
|
||||
; 392d
|
||||
|
||||
Function392d:: ; 392d
|
||||
; XXX
|
||||
Unreferenced_Function392d:: ; 392d
|
||||
; GetDexNumber
|
||||
; Probably used in gen 1 to convert index number to dex number
|
||||
; Not required in gen 2 because index number == dex number
|
||||
|
@ -1,8 +1,7 @@
|
||||
; Functions to fade the screen in and out.
|
||||
|
||||
|
||||
Function48c:: ; 48c
|
||||
; XXX
|
||||
Unreferenced_Function48c:: ; 48c
|
||||
; TimeOfDayFade
|
||||
ld a, [TimeOfDayPal]
|
||||
ld b, a
|
||||
|
@ -384,7 +384,7 @@ CheckIndoorMap:: ; 22f4
|
||||
ret
|
||||
; 2300
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
cp INDOOR
|
||||
ret z
|
||||
cp GATE
|
||||
@ -2075,7 +2075,6 @@ GetAnyMapHeaderPointer:: ; 0x2bed
|
||||
|
||||
; inputs:
|
||||
; b = map group, c = map number
|
||||
; XXX de = ???
|
||||
|
||||
; outputs:
|
||||
; hl points to the map header
|
||||
@ -2247,7 +2246,7 @@ GetMapEnvironment:: ; 2c8a
|
||||
ret
|
||||
; 2c98
|
||||
|
||||
ret ; XXX
|
||||
ret ; unused
|
||||
; 2c99
|
||||
|
||||
GetAnyMapEnvironment:: ; 2c99
|
||||
|
@ -316,7 +316,7 @@ CheckObjectTime:: ; 18f5
|
||||
ret
|
||||
; 194d
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
ld [hMapObjectIndexBuffer], a
|
||||
call GetMapObject
|
||||
call CopyObjectStruct
|
||||
@ -383,7 +383,7 @@ CopyPlayerObjectTemplate:: ; 19a6
|
||||
ret
|
||||
; 19b8
|
||||
|
||||
; XXX
|
||||
Unreferenced_Function19b8:
|
||||
call GetMapObject
|
||||
ld hl, MAPOBJECT_OBJECT_STRUCT_ID
|
||||
add hl, bc
|
||||
|
@ -398,8 +398,7 @@ LinkDataReceived:: ; 908
|
||||
ret
|
||||
; 919
|
||||
|
||||
Function919:: ; 919
|
||||
; XXX
|
||||
Unreferenced_Function919:: ; 919
|
||||
ld a, [wLinkMode]
|
||||
and a
|
||||
ret nz
|
||||
|
@ -1015,8 +1015,7 @@ Text_PlaySound:: ; 1500
|
||||
ret
|
||||
; 1522
|
||||
|
||||
Function1522:: ; 1522
|
||||
; XXX
|
||||
Unreferenced_Function1522:: ; 1522
|
||||
; TX_CRY
|
||||
push de
|
||||
ld e, [hl]
|
||||
|
@ -99,7 +99,7 @@ SafeUpdateSprites:: ; 2e31
|
||||
ld [hOAMUpdate], a
|
||||
ret
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
scf
|
||||
ret
|
||||
; 2e50
|
||||
|
@ -6908,7 +6908,7 @@ Function112d33: ; 112d33
|
||||
dec a
|
||||
jp .asm_112e46
|
||||
|
||||
; XXX
|
||||
; unused
|
||||
ret
|
||||
|
||||
.asm_112d4d
|
||||
@ -8611,7 +8611,7 @@ endr
|
||||
ld [$cc0d], a
|
||||
ld a, l
|
||||
ld [$cc0c], a
|
||||
cp $8e ; XXX ; LOW(Unknown_113b8e + $100) ???
|
||||
cp $8e ; XXX LOW(Unknown_113b8e + $100) ???
|
||||
jp nz, .asm_113751
|
||||
ld de, $cc18
|
||||
ld hl, $cbe7
|
||||
|
@ -33,8 +33,7 @@ Function11c075: ; 11c075
|
||||
ret
|
||||
; 11c082
|
||||
|
||||
Function11c082: ; 11c082
|
||||
; XXX
|
||||
Unreferenced_Function11c082: ; 11c082
|
||||
push de
|
||||
ld a, c
|
||||
call Function11c254
|
||||
|
@ -7350,7 +7350,7 @@ INCBIN "data/mobile/ascii-sym.txt"
|
||||
|
||||
; everything from here to the end of the bank is related to the
|
||||
; Mobile Stadium option from the continue/newgame menu.
|
||||
; XXX better function names
|
||||
; Needs better function names
|
||||
MobileStudium: ; 0x117a7f
|
||||
ld a, [hInMenu]
|
||||
push af
|
||||
|
@ -1,9 +1,8 @@
|
||||
; http://forums.glitchcity.info/index.php?topic=7509.msg206449#msg206449
|
||||
|
||||
db $cc, $6b, $1e ; XXX
|
||||
db $cc, $6b, $1e ; unused
|
||||
|
||||
Function1f4003: ; 1f4003
|
||||
; XXX
|
||||
Unreferenced_Function1f4003: ; 1f4003
|
||||
ld a, $6
|
||||
call GetSRAMBank
|
||||
ld hl, .news_data
|
||||
@ -16,8 +15,7 @@ Function1f4003: ; 1f4003
|
||||
.news_data
|
||||
INCBIN "mobile/news/news_1.bin"
|
||||
|
||||
Function1f4dbe: ; 1f4dbe
|
||||
; XXX
|
||||
Unreferenced_Function1f4dbe: ; 1f4dbe
|
||||
ld a, $6
|
||||
call GetSRAMBank
|
||||
ld hl, .news_data
|
||||
|
@ -1,5 +1,4 @@
|
||||
GetGen1TrainerClassName: ; 50a28
|
||||
; XXX
|
||||
Unreferenced_GetGen1TrainerClassName: ; 50a28
|
||||
ld hl, .Strings
|
||||
ld a, [TrainerClass]
|
||||
dec a
|
||||
|
Loading…
Reference in New Issue
Block a user