Clean up XXX comments for unused content

2025-04-09 05:44:44 -07:00 · 2018-01-02 13:24:05 +01:00
parent f27f79488a
commit 9a3088e50c
36 changed files with 68 additions and 97 deletions
--- a/data/sprite_anims/framesets.asm
+++ b/data/sprite_anims/framesets.asm
@@ -246,45 +246,45 @@ SpriteAnimFrameData: ; 8d6e6
 	frame SPRITE_ANIM_OAMSET_MAGNET_TRAIN_RED_2,  8, OAM_X_FLIP
 	dorestart

-; XXX
+; unused
 	frame SPRITE_ANIM_OAMSET_43,  8
 	frame SPRITE_ANIM_OAMSET_44,  8
 	dorestart

-; XXX
+; unused
 	frame SPRITE_ANIM_OAMSET_45,  8
 	frame SPRITE_ANIM_OAMSET_46,  8
 	dorestart

-; XXX
+; unused
 	frame SPRITE_ANIM_OAMSET_47,  8
 	frame SPRITE_ANIM_OAMSET_48,  8
 	dorestart

-; XXX
+; unused
 	frame SPRITE_ANIM_OAMSET_49,  1
 	frame SPRITE_ANIM_OAMSET_49,  1, OAM_X_FLIP
 	frame SPRITE_ANIM_OAMSET_49,  1, OAM_X_FLIP, OAM_Y_FLIP
 	frame SPRITE_ANIM_OAMSET_49,  1, OAM_Y_FLIP
 	dorestart

-; XXX
+; unused
 	frame SPRITE_ANIM_OAMSET_4A, 32
 	endanim

-; XXX
+; unused
 	frame SPRITE_ANIM_OAMSET_4B, 32
 	endanim

-; XXX
+; unused
 	frame SPRITE_ANIM_OAMSET_4C, 32
 	endanim

-; XXX
+; unused
 	frame SPRITE_ANIM_OAMSET_4D, 32
 	endanim

-; XXX
+; unused
 	frame SPRITE_ANIM_OAMSET_4E,  3
 	dorepeat  3
 	dorestart
--- a/engine/battle/battle_transition.asm
+++ b/engine/battle/battle_transition.asm
@@ -863,8 +863,7 @@ ENDM
 	ret
 ; 8c7c9 (23:47c9)

-Function8c7c9:
-; XXX
+Unreferenced_Function8c7c9:
 	ld a, $1
 	ld [hBGMapMode], a
 	call WaitBGMap
--- a/engine/battle/core.asm
+++ b/engine/battle/core.asm
@@ -8551,8 +8551,7 @@ InitEnemyWildmon: ; 3f607
 	ret
 ; 3f662

-Function3f662: ; 3f662
-; XXX
+Unreferenced_Function3f662: ; 3f662
 	ld hl, EnemyMonMoves
 	ld de, wListMoves_MoveIndicesBuffer
 	ld b, NUM_MOVES
--- a/engine/billspc.asm
+++ b/engine/billspc.asm
@@ -2559,7 +2559,7 @@ BillsPC_ChangeBoxSubmenu: ; e36f9 (38:76f9)
 	ret
 ; e3778 (38:7778)

-	hlcoord 11, 7 ; XXX
+	hlcoord 11, 7 ; unused

 .MenuDataHeader: ; 0xe377b
 	db $40 ; flags
--- a/engine/color.asm
+++ b/engine/color.asm
@@ -78,8 +78,7 @@ CheckContestMon:
 	and a
 	ret

-Function8aa4:
-; XXX
+Unreferenced_Function8aa4:
 	push de
 	push bc
 	ld hl, PalPacket_9ce6
@@ -180,8 +179,7 @@ Function8b3f:
 	ld hl, BlkPacket_9a86
 	jp PushSGBPals_

-Function8b4d:
-; XXX
+Unreferenced_Function8b4d:
 	call CheckCGB
 	jr nz, .cgb
 	ld a, [hSGB]
@@ -196,8 +194,7 @@ Function8b4d:
 	call GetPredefPal
 	jp LoadHLPaletteIntoDE

-Function8b67:
-; XXX
+Unreferenced_Function8b67:
 	call CheckCGB
 	jr nz, .cgb
 	ld a, [hSGB]
@@ -212,8 +209,7 @@ Function8b67:
 	call GetPredefPal
 	jp LoadHLPaletteIntoDE

-Function8b81:
-; XXX
+Unreferenced_Function8b81:
 	call CheckCGB
 	jr nz, .cgb
 	ld a, [hSGB]
@@ -281,8 +277,7 @@ got_palette_pointer_8bd7
 	call LoadPalette_White_Col1_Col2_Black
 	ret

-Function8bec:
-; XXX
+Unreferenced_Function8bec:
 	ld a, [hCGB]
 	and a
 	jr nz, .cgb
@@ -455,8 +450,7 @@ INCLUDE "data/palettes/mail.pal"

 INCLUDE "engine/cgb_layouts.asm"

-Function95f0:
-; XXX
+Unreferenced_Function95f0:
 	ld hl, .Palette
 	ld de, wBGPals1
 	ld bc, 1 palettes
@@ -768,8 +762,7 @@ Function9779: mobile
 BattleObjectPals:
 INCLUDE "data/palettes/battle_objects.pal"

-Function97cc:
-; XXX
+Unreferenced_Function97cc:
 	call CheckCGB
 	ret z
 	ld a, $90
@@ -979,8 +972,7 @@ _InitSGBBorderPals:
 	dw PalPacket_9dd6
 	dw PalPacket_9de6

-Function9911:
-; XXX
+Unreferenced_Function9911:
 	di
 	xor a
 	ld [rJOYP], a
--- a/engine/dma_transfer.asm
+++ b/engine/dma_transfer.asm
@@ -112,7 +112,7 @@ Mobile_ReloadMapPart: ; 104099
 	ret
 ; 1040d4

-; XXX
+; unused
 	ld hl, .unreferenced_1040da
 	jp CallInSafeGFXMode

@@ -136,7 +136,7 @@ Mobile_ReloadMapPart: ; 104099
 	ret
 ; 1040fb

-; XXX
+; unused
 	ld hl, .unreferenced_104101
 	jp CallInSafeGFXMode

--- a/engine/events/kurt.asm
+++ b/engine/events/kurt.asm
@@ -163,7 +163,7 @@ Kurt_SelectQuantity: ; 880c2
 	db 09, 06 ; start coords
 	db 12, 19 ; end coords

-	db 0, 0, -1, 0 ; XXX
+	db 0, 0, -1, 0 ; unused

 .PlaceApricornName: ; 88116
 	call MenuBoxCoord2Tile
--- a/engine/events/mom_phone.asm
+++ b/engine/events/mom_phone.asm
@@ -217,7 +217,7 @@ endr

 INCLUDE "data/items/mom_phone.asm"

-	db 0, 0, 0 ; XXX
+	db 0, 0, 0 ; unused

 _MomText_HiHowAreYou: ; 0xfd1b1
 	; Hi,  ! How are you?
@@ -255,10 +255,10 @@ _MomText_ItsInRoom: ; 0xfd1ca
 	db "@"
 ; 0xfd1cf

-	db 0 ; XXX
+	db 0 ; unused

 Predef3A: ; fd1d0
 	ret
 ; fd1d1

-	ret ; XXX
+	ret ; unused
--- a/engine/events/overworld.asm
+++ b/engine/events/overworld.asm
@@ -1749,7 +1749,7 @@ Script_GetOnBike_Register: ; 0xd14e
 	special ReplaceKrisSprite
 	end

-; XXX
+; unused
 	nop
 	ret

--- a/engine/evolve.asm
+++ b/engine/evolve.asm
@@ -333,7 +333,7 @@ EvolveAfterBattle_MasterLoop
 	inc hl
 	jp .loop

-; XXX
+; unused
 	pop hl
 .ReturnToMap:
 	pop de
--- a/engine/mail_2.asm
+++ b/engine/mail_2.asm
@@ -725,8 +725,7 @@ MailGFX_PlaceMessage: ; b9803
 	jp PlaceString
 ; b984e

-Functionb984e: ; b984e
-; XXX
+Unreferenced_Functionb984e: ; b984e
 .loop
 	ld a, [hl]
 	xor $ff
--- a/engine/mon_stats.asm
+++ b/engine/mon_stats.asm
@@ -324,8 +324,7 @@ ListMovePP: ; 50c50
 	jr nz, .load_loop
 	ret

-Function50cd0: ; 50cd0
-; XXX
+Unreferenced_Function50cd0: ; 50cd0
 .loop
 	ld [hl], $32
 	inc hl
--- a/engine/move_mon.asm
+++ b/engine/move_mon.asm
@@ -1795,7 +1795,7 @@ InitNickname: ; e3de
 	pop hl
 	ld de, StringBuffer1
 	call InitName
-	ld a, $4 ; XXX could this be in bank 4 in pokered?
+	ld a, $4 ; ExitAllMenus is in bank 0, XXX could this be in bank 4 in pokered?
 	ld hl, ExitAllMenus
 	rst FarCall
 	ret
--- a/engine/namingscreen.asm
+++ b/engine/namingscreen.asm
@@ -739,7 +739,7 @@ NamingScreen_AdvanceCursor_CheckEndOfString: ; 11b27

 ; 11b39 (4:5b39)

-; XXX
+; unused
 	ld a, [wNamingScreenCurrNameLength]
 	and a
 	ret z
@@ -1434,7 +1434,7 @@ MailComposition_TryAddLastCharacter: ; 121ac (4:61ac)

 ; 121b2 (4:61b2)

-; XXX
+; unused
 	ld a, [wNamingScreenCurrNameLength]
 	and a
 	ret z
--- a/engine/pic_animation.asm
+++ b/engine/pic_animation.asm
@@ -695,7 +695,7 @@ PokeAnim_ConvertAndApplyBitmask: ; d036b
 	ret
 ; d03f4

-; XXX
+; unused
 	db 6, 5, 4

 .GetTilemap: ; d03f7
--- a/engine/player_gfx.asm
+++ b/engine/player_gfx.asm
@@ -1,5 +1,4 @@
-Function88248: ; 88248
-; XXX
+Unreferenced_Function88248: ; 88248
 	ld c, CAL
 	ld a, [wPlayerGender]
 	bit 0, a
--- a/engine/pokegear.asm
+++ b/engine/pokegear.asm
@@ -1309,7 +1309,7 @@ PokegearPhoneContactSubmenu: ; 91342 (24:5342)

 ; 9146e

-; XXX
+; unused
 	ld a, [hHours]
 	cp 12
 	jr c, .am
@@ -1499,7 +1499,7 @@ UpdateRadioStation: ; 9166f (24:566f)

 ; 916a1 (24:56a1)

-; XXX
+; unused
 	ld [wPokegearRadioChannelBank], a
 	ld a, [hli]
 	ld [wPokegearRadioChannelAddr], a
@@ -2932,7 +2932,7 @@ INCBIN "gfx/pokegear/dexmap_nest_icon.2bpp"
 FlyMapLabelBorderGFX: ; 922e1
 INCBIN "gfx/pokegear/flymap_label_border.1bpp"

-; XXX
+Unreferenced_Function92311:
 	xor a
 	ld [wTownMapPlayerIconLandmark], a
 	call ClearBGPalettes
--- a/engine/printer.asm
+++ b/engine/printer.asm
@@ -596,8 +596,7 @@ PlacePrinterStatusString: ; 84785
 	ret
 ; 847bd

-Function847bd: ; 847bd
-; XXX
+Unreferenced_Function847bd: ; 847bd
 	ld a, [wPrinterStatus]
 	and a
 	ret z
--- a/engine/printnum.asm
+++ b/engine/printnum.asm
@@ -165,7 +165,7 @@ _PrintNum:: ; c4c7
 	dec e
 	jr nz, .money_leading_zero
 	inc hl
-	ld [hl], $f2 ; XXX
+	ld [hl], "<DOT>"

 .money_leading_zero
 	call .AdvancePointer
--- a/engine/routines/printhoursmins.asm
+++ b/engine/routines/printhoursmins.asm
@@ -1,5 +1,4 @@
-Function1dd6a9: ; 1dd6a9
-; XXX
+Unreferenced_Function1dd6a9: ; 1dd6a9
 	ld a, b
 	ld b, c
 	ld c, a
--- a/Show More
+++ b/Show More