pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-09-09 09:51:34 -07:00
Code Issues Packages Projects Releases Wiki Activity

Clean up XXX comments for unused content

Browse Source
This commit is contained in:
xCrystal 2018-01-02 13:24:05 +01:00
parent f27f79488a
commit 9a3088e50c
36 changed files with 68 additions and 97 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
data/sprite_anims/framesets.asm
View File

@ -246,45 +246,45 @@ SpriteAnimFrameData: ; 8d6e6
frame SPRITE_ANIM_OAMSET_MAGNET_TRAIN_RED_2, 8, OAM_X_FLIP frame SPRITE_ANIM_OAMSET_MAGNET_TRAIN_RED_2, 8, OAM_X_FLIP
dorestart dorestart
; XXX ; unused
frame SPRITE_ANIM_OAMSET_43, 8 frame SPRITE_ANIM_OAMSET_43, 8
frame SPRITE_ANIM_OAMSET_44, 8 frame SPRITE_ANIM_OAMSET_44, 8
dorestart dorestart
; XXX ; unused
frame SPRITE_ANIM_OAMSET_45, 8 frame SPRITE_ANIM_OAMSET_45, 8
frame SPRITE_ANIM_OAMSET_46, 8 frame SPRITE_ANIM_OAMSET_46, 8
dorestart dorestart
; XXX ; unused
frame SPRITE_ANIM_OAMSET_47, 8 frame SPRITE_ANIM_OAMSET_47, 8
frame SPRITE_ANIM_OAMSET_48, 8 frame SPRITE_ANIM_OAMSET_48, 8
dorestart dorestart
; XXX ; unused
frame SPRITE_ANIM_OAMSET_49, 1 frame SPRITE_ANIM_OAMSET_49, 1
frame SPRITE_ANIM_OAMSET_49, 1, OAM_X_FLIP frame SPRITE_ANIM_OAMSET_49, 1, OAM_X_FLIP
frame SPRITE_ANIM_OAMSET_49, 1, OAM_X_FLIP, OAM_Y_FLIP frame SPRITE_ANIM_OAMSET_49, 1, OAM_X_FLIP, OAM_Y_FLIP
frame SPRITE_ANIM_OAMSET_49, 1, OAM_Y_FLIP frame SPRITE_ANIM_OAMSET_49, 1, OAM_Y_FLIP
dorestart dorestart
; XXX ; unused
frame SPRITE_ANIM_OAMSET_4A, 32 frame SPRITE_ANIM_OAMSET_4A, 32
endanim endanim
; XXX ; unused
frame SPRITE_ANIM_OAMSET_4B, 32 frame SPRITE_ANIM_OAMSET_4B, 32
endanim endanim
; XXX ; unused
frame SPRITE_ANIM_OAMSET_4C, 32 frame SPRITE_ANIM_OAMSET_4C, 32
endanim endanim
; XXX ; unused
frame SPRITE_ANIM_OAMSET_4D, 32 frame SPRITE_ANIM_OAMSET_4D, 32
endanim endanim
; XXX ; unused
frame SPRITE_ANIM_OAMSET_4E, 3 frame SPRITE_ANIM_OAMSET_4E, 3
dorepeat 3 dorepeat 3
dorestart dorestart

3
engine/battle/battle_transition.asm
View File

@ -863,8 +863,7 @@ ENDM
ret ret
; 8c7c9 (23:47c9) ; 8c7c9 (23:47c9)
Function8c7c9: Unreferenced_Function8c7c9:
; XXX
ld a, $1 ld a, $1
ld [hBGMapMode], a ld [hBGMapMode], a
call WaitBGMap call WaitBGMap

3
engine/battle/core.asm
View File

@ -8551,8 +8551,7 @@ InitEnemyWildmon: ; 3f607
ret ret
; 3f662 ; 3f662
Function3f662: ; 3f662 Unreferenced_Function3f662: ; 3f662
; XXX
ld hl, EnemyMonMoves ld hl, EnemyMonMoves
ld de, wListMoves_MoveIndicesBuffer ld de, wListMoves_MoveIndicesBuffer
ld b, NUM_MOVES ld b, NUM_MOVES

2
engine/billspc.asm
View File

@ -2559,7 +2559,7 @@ BillsPC_ChangeBoxSubmenu: ; e36f9 (38:76f9)
ret ret
; e3778 (38:7778) ; e3778 (38:7778)
hlcoord 11, 7 ; XXX hlcoord 11, 7 ; unused
.MenuDataHeader: ; 0xe377b .MenuDataHeader: ; 0xe377b
db $40 ; flags db $40 ; flags

24
engine/color.asm
View File

@ -78,8 +78,7 @@ CheckContestMon:
and a and a
ret ret
Function8aa4: Unreferenced_Function8aa4:
; XXX
push de push de
push bc push bc
ld hl, PalPacket_9ce6 ld hl, PalPacket_9ce6
@ -180,8 +179,7 @@ Function8b3f:
ld hl, BlkPacket_9a86 ld hl, BlkPacket_9a86
jp PushSGBPals_ jp PushSGBPals_
Function8b4d: Unreferenced_Function8b4d:
; XXX
call CheckCGB call CheckCGB
jr nz, .cgb jr nz, .cgb
ld a, [hSGB] ld a, [hSGB]
@ -196,8 +194,7 @@ Function8b4d:
call GetPredefPal call GetPredefPal
jp LoadHLPaletteIntoDE jp LoadHLPaletteIntoDE
Function8b67: Unreferenced_Function8b67:
; XXX
call CheckCGB call CheckCGB
jr nz, .cgb jr nz, .cgb
ld a, [hSGB] ld a, [hSGB]
@ -212,8 +209,7 @@ Function8b67:
call GetPredefPal call GetPredefPal
jp LoadHLPaletteIntoDE jp LoadHLPaletteIntoDE
Function8b81: Unreferenced_Function8b81:
; XXX
call CheckCGB call CheckCGB
jr nz, .cgb jr nz, .cgb
ld a, [hSGB] ld a, [hSGB]
@ -281,8 +277,7 @@ got_palette_pointer_8bd7
call LoadPalette_White_Col1_Col2_Black call LoadPalette_White_Col1_Col2_Black
ret ret
Function8bec: Unreferenced_Function8bec:
; XXX
ld a, [hCGB] ld a, [hCGB]
and a and a
jr nz, .cgb jr nz, .cgb
@ -455,8 +450,7 @@ INCLUDE "data/palettes/mail.pal"
INCLUDE "engine/cgb_layouts.asm" INCLUDE "engine/cgb_layouts.asm"
Function95f0: Unreferenced_Function95f0:
; XXX
ld hl, .Palette ld hl, .Palette
ld de, wBGPals1 ld de, wBGPals1
ld bc, 1 palettes ld bc, 1 palettes
@ -768,8 +762,7 @@ Function9779: mobile
BattleObjectPals: BattleObjectPals:
INCLUDE "data/palettes/battle_objects.pal" INCLUDE "data/palettes/battle_objects.pal"
Function97cc: Unreferenced_Function97cc:
; XXX
call CheckCGB call CheckCGB
ret z ret z
ld a, $90 ld a, $90
@ -979,8 +972,7 @@ _InitSGBBorderPals:
dw PalPacket_9dd6 dw PalPacket_9dd6
dw PalPacket_9de6 dw PalPacket_9de6
Function9911: Unreferenced_Function9911:
; XXX
di di
xor a xor a
ld [rJOYP], a ld [rJOYP], a

4
engine/dma_transfer.asm
View File

@ -112,7 +112,7 @@ Mobile_ReloadMapPart: ; 104099
ret ret
; 1040d4 ; 1040d4
; XXX ; unused
ld hl, .unreferenced_1040da ld hl, .unreferenced_1040da
jp CallInSafeGFXMode jp CallInSafeGFXMode
@ -136,7 +136,7 @@ Mobile_ReloadMapPart: ; 104099
ret ret
; 1040fb ; 1040fb
; XXX ; unused
ld hl, .unreferenced_104101 ld hl, .unreferenced_104101
jp CallInSafeGFXMode jp CallInSafeGFXMode

2
engine/events/kurt.asm
View File

@ -163,7 +163,7 @@ Kurt_SelectQuantity: ; 880c2
db 09, 06 ; start coords db 09, 06 ; start coords
db 12, 19 ; end coords db 12, 19 ; end coords
db 0, 0, -1, 0 ; XXX db 0, 0, -1, 0 ; unused
.PlaceApricornName: ; 88116 .PlaceApricornName: ; 88116
call MenuBoxCoord2Tile call MenuBoxCoord2Tile

6
engine/events/mom_phone.asm
View File

@ -217,7 +217,7 @@ endr
INCLUDE "data/items/mom_phone.asm" INCLUDE "data/items/mom_phone.asm"
db 0, 0, 0 ; XXX db 0, 0, 0 ; unused
_MomText_HiHowAreYou: ; 0xfd1b1 _MomText_HiHowAreYou: ; 0xfd1b1
; Hi, ! How are you? ; Hi, ! How are you?
@ -255,10 +255,10 @@ _MomText_ItsInRoom: ; 0xfd1ca
db "@" db "@"
; 0xfd1cf ; 0xfd1cf
db 0 ; XXX db 0 ; unused
Predef3A: ; fd1d0 Predef3A: ; fd1d0
ret ret
; fd1d1 ; fd1d1
ret ; XXX ret ; unused

2
engine/events/overworld.asm
View File

@ -1749,7 +1749,7 @@ Script_GetOnBike_Register: ; 0xd14e
special ReplaceKrisSprite special ReplaceKrisSprite
end end
; XXX ; unused
nop nop
ret ret

2
engine/evolve.asm
View File

@ -333,7 +333,7 @@ EvolveAfterBattle_MasterLoop
inc hl inc hl
jp .loop jp .loop
; XXX ; unused
pop hl pop hl
.ReturnToMap: .ReturnToMap:
pop de pop de

3
engine/mail_2.asm
View File

@ -725,8 +725,7 @@ MailGFX_PlaceMessage: ; b9803
jp PlaceString jp PlaceString
; b984e ; b984e
Functionb984e: ; b984e Unreferenced_Functionb984e: ; b984e
; XXX
.loop .loop
ld a, [hl] ld a, [hl]
xor $ff xor $ff

3
engine/mon_stats.asm
View File

@ -324,8 +324,7 @@ ListMovePP: ; 50c50
jr nz, .load_loop jr nz, .load_loop
ret ret
Function50cd0: ; 50cd0 Unreferenced_Function50cd0: ; 50cd0
; XXX
.loop .loop
ld [hl], $32 ld [hl], $32
inc hl inc hl

2
engine/move_mon.asm
View File

@ -1795,7 +1795,7 @@ InitNickname: ; e3de
pop hl pop hl
ld de, StringBuffer1 ld de, StringBuffer1
call InitName call InitName
ld a, $4 ; XXX could this be in bank 4 in pokered? ld a, $4 ; ExitAllMenus is in bank 0, XXX could this be in bank 4 in pokered?
ld hl, ExitAllMenus ld hl, ExitAllMenus
rst FarCall rst FarCall
ret ret

4
engine/namingscreen.asm
View File

@ -739,7 +739,7 @@ NamingScreen_AdvanceCursor_CheckEndOfString: ; 11b27
; 11b39 (4:5b39) ; 11b39 (4:5b39)
; XXX ; unused
ld a, [wNamingScreenCurrNameLength] ld a, [wNamingScreenCurrNameLength]
and a and a
ret z ret z
@ -1434,7 +1434,7 @@ MailComposition_TryAddLastCharacter: ; 121ac (4:61ac)
; 121b2 (4:61b2) ; 121b2 (4:61b2)
; XXX ; unused
ld a, [wNamingScreenCurrNameLength] ld a, [wNamingScreenCurrNameLength]
and a and a
ret z ret z

2
engine/pic_animation.asm
View File

@ -695,7 +695,7 @@ PokeAnim_ConvertAndApplyBitmask: ; d036b
ret ret
; d03f4 ; d03f4
; XXX ; unused
db 6, 5, 4 db 6, 5, 4
.GetTilemap: ; d03f7 .GetTilemap: ; d03f7

3
engine/player_gfx.asm
View File

@ -1,5 +1,4 @@
Function88248: ; 88248 Unreferenced_Function88248: ; 88248
; XXX
ld c, CAL ld c, CAL
ld a, [wPlayerGender] ld a, [wPlayerGender]
bit 0, a bit 0, a

6
engine/pokegear.asm
View File

@ -1309,7 +1309,7 @@ PokegearPhoneContactSubmenu: ; 91342 (24:5342)
; 9146e ; 9146e
; XXX ; unused
ld a, [hHours] ld a, [hHours]
cp 12 cp 12
jr c, .am jr c, .am
@ -1499,7 +1499,7 @@ UpdateRadioStation: ; 9166f (24:566f)
; 916a1 (24:56a1) ; 916a1 (24:56a1)
; XXX ; unused
ld [wPokegearRadioChannelBank], a ld [wPokegearRadioChannelBank], a
ld a, [hli] ld a, [hli]
ld [wPokegearRadioChannelAddr], a ld [wPokegearRadioChannelAddr], a
@ -2932,7 +2932,7 @@ INCBIN "gfx/pokegear/dexmap_nest_icon.2bpp"
FlyMapLabelBorderGFX: ; 922e1 FlyMapLabelBorderGFX: ; 922e1
INCBIN "gfx/pokegear/flymap_label_border.1bpp" INCBIN "gfx/pokegear/flymap_label_border.1bpp"
; XXX Unreferenced_Function92311:
xor a xor a
ld [wTownMapPlayerIconLandmark], a ld [wTownMapPlayerIconLandmark], a
call ClearBGPalettes call ClearBGPalettes

3
engine/printer.asm
View File

@ -596,8 +596,7 @@ PlacePrinterStatusString: ; 84785
ret ret
; 847bd ; 847bd
Function847bd: ; 847bd Unreferenced_Function847bd: ; 847bd
; XXX
ld a, [wPrinterStatus] ld a, [wPrinterStatus]
and a and a
ret z ret z

2
engine/printnum.asm
View File

@ -165,7 +165,7 @@ _PrintNum:: ; c4c7
dec e dec e
jr nz, .money_leading_zero jr nz, .money_leading_zero
inc hl inc hl
ld [hl], $f2 ; XXX ld [hl], "<DOT>"
.money_leading_zero .money_leading_zero
call .AdvancePointer call .AdvancePointer

3
engine/routines/printhoursmins.asm
View File

@ -1,5 +1,4 @@
Function1dd6a9: ; 1dd6a9 Unreferenced_Function1dd6a9: ; 1dd6a9
; XXX
ld a, b ld a, b
ld b, c ld b, c
ld c, a ld c, a

2
engine/rtc.asm
View File

@ -1,4 +1,4 @@
StopRTC: ; Unreferenced??? StopRTC: ; Unreferenced
ld a, SRAM_ENABLE ld a, SRAM_ENABLE
ld [MBC3SRamEnable], a ld [MBC3SRamEnable], a
call LatchClock call LatchClock

12
engine/save.asm
View File

@ -415,8 +415,7 @@ EraseHallOfFame: ; 14d06
jp CloseSRAM jp CloseSRAM
; 14d18 ; 14d18
Function14d18: ; 14d18 Unreferenced_Function14d18: ; 14d18
; XXX
; copy .Data to SRA4:a007 ; copy .Data to SRA4:a007
ld a, $4 ld a, $4
call GetSRAMBank call GetSRAMBank
@ -452,8 +451,7 @@ SaveData: ; 14d68
ret ret
; 14d6c ; 14d6c
Function14d6c: ; 14d6c Unreferenced_Function14d6c: ; 14d6c
; XXX
ld a, $4 ld a, $4
call GetSRAMBank call GetSRAMBank
ld a, [$a60b] ld a, [$a60b]
@ -469,8 +467,7 @@ Function14d6c: ; 14d6c
ret ret
; 14d83 ; 14d83
Function14d83: ; 14d83 Unreferenced_Function14d83: ; 14d83
; XXX
ld a, $4 ld a, $4
call GetSRAMBank call GetSRAMBank
xor a xor a
@ -480,8 +477,7 @@ Function14d83: ; 14d83
ret ret
; 14d93 ; 14d93
Function14d93: ; 14d93 Unreferenced_Function14d93: ; 14d93
; XXX
ld a, $7 ld a, $7
call GetSRAMBank call GetSRAMBank
xor a xor a

2
engine/scripting.asm
View File

@ -2852,7 +2852,7 @@ Script_loadbytec2cf:
ld [wc2cf], a ld [wc2cf], a
ret ret
ld c, c ; XXX ld c, c ; unused
Script_closetext: Script_closetext:
; script command 0x49 ; script command 0x49

4
engine/time.asm
View File

@ -225,13 +225,13 @@ CheckUnusedTwoDayTimer: ; 1150c
ret ret
; 1151c ; 1151c
; XXX ; unused
ld hl, wDailyFlags ld hl, wDailyFlags
set 2, [hl] set 2, [hl]
ret ret
; 11522 ; 11522
; XXX ; unused
and a and a
ld hl, wDailyFlags ld hl, wDailyFlags
bit 2, [hl] bit 2, [hl]

8
home.asm
View File

@ -552,7 +552,7 @@ CopyTilemapAtOnce:: ; 323d
jr .CopyTilemapAtOnce jr .CopyTilemapAtOnce
; 323f ; 323f
; XXX ; unused
farcall HDMATransferAttrMapAndTileMapToWRAMBank3 farcall HDMATransferAttrMapAndTileMapToWRAMBank3
ret ret
; 3246 ; 3246
@ -1127,8 +1127,7 @@ Print8BitNumRightAlign:: ; 3842
jp PrintNum jp PrintNum
; 384d ; 384d
Function384d:: ; 384d Unreferenced_Function384d:: ; 384d
; XXX
; GetNthMove ; GetNthMove
ld hl, wListMoves_MoveIndicesBuffer ld hl, wListMoves_MoveIndicesBuffer
ld c, a ld c, a
@ -1321,8 +1320,7 @@ GetPartyLocation:: ; 3927
jp AddNTimes jp AddNTimes
; 392d ; 392d
Function392d:: ; 392d Unreferenced_Function392d:: ; 392d
; XXX
; GetDexNumber ; GetDexNumber
; Probably used in gen 1 to convert index number to dex number ; Probably used in gen 1 to convert index number to dex number
; Not required in gen 2 because index number == dex number ; Not required in gen 2 because index number == dex number

3
home/fade.asm
View File

@ -1,8 +1,7 @@
; Functions to fade the screen in and out. ; Functions to fade the screen in and out.
Function48c:: ; 48c Unreferenced_Function48c:: ; 48c
; XXX
; TimeOfDayFade ; TimeOfDayFade
ld a, [TimeOfDayPal] ld a, [TimeOfDayPal]
ld b, a ld b, a

5
home/map.asm
View File

@ -384,7 +384,7 @@ CheckIndoorMap:: ; 22f4
ret ret
; 2300 ; 2300
; XXX ; unused
cp INDOOR cp INDOOR
ret z ret z
cp GATE cp GATE
@ -2075,7 +2075,6 @@ GetAnyMapHeaderPointer:: ; 0x2bed
; inputs: ; inputs:
; b = map group, c = map number ; b = map group, c = map number
; XXX de = ???
; outputs: ; outputs:
; hl points to the map header ; hl points to the map header
@ -2247,7 +2246,7 @@ GetMapEnvironment:: ; 2c8a
ret ret
; 2c98 ; 2c98
ret ; XXX ret ; unused
; 2c99 ; 2c99
GetAnyMapEnvironment:: ; 2c99 GetAnyMapEnvironment:: ; 2c99

4
home/map_objects.asm
View File

@ -316,7 +316,7 @@ CheckObjectTime:: ; 18f5
ret ret
; 194d ; 194d
; XXX ; unused
ld [hMapObjectIndexBuffer], a ld [hMapObjectIndexBuffer], a
call GetMapObject call GetMapObject
call CopyObjectStruct call CopyObjectStruct
@ -383,7 +383,7 @@ CopyPlayerObjectTemplate:: ; 19a6
ret ret
; 19b8 ; 19b8
; XXX Unreferenced_Function19b8:
call GetMapObject call GetMapObject
ld hl, MAPOBJECT_OBJECT_STRUCT_ID ld hl, MAPOBJECT_OBJECT_STRUCT_ID
add hl, bc add hl, bc

3
home/serial.asm
View File

@ -398,8 +398,7 @@ LinkDataReceived:: ; 908
ret ret
; 919 ; 919
Function919:: ; 919 Unreferenced_Function919:: ; 919
; XXX
ld a, [wLinkMode] ld a, [wLinkMode]
and a and a
ret nz ret nz

3
home/text.asm
View File

@ -1015,8 +1015,7 @@ Text_PlaySound:: ; 1500
ret ret
; 1522 ; 1522
Function1522:: ; 1522 Unreferenced_Function1522:: ; 1522
; XXX
; TX_CRY ; TX_CRY
push de push de
ld e, [hl] ld e, [hl]

2
home/window.asm
View File

@ -99,7 +99,7 @@ SafeUpdateSprites:: ; 2e31
ld [hOAMUpdate], a ld [hOAMUpdate], a
ret ret
; XXX ; unused
scf scf
ret ret
; 2e50 ; 2e50

4
lib/mobile/main.asm
View File

@ -6908,7 +6908,7 @@ Function112d33: ; 112d33
dec a dec a
jp .asm_112e46 jp .asm_112e46
; XXX ; unused
ret ret
.asm_112d4d .asm_112d4d
@ -8611,7 +8611,7 @@ endr
ld [$cc0d], a ld [$cc0d], a
ld a, l ld a, l
ld [$cc0c], a ld [$cc0c], a
cp $8e ; XXX ; LOW(Unknown_113b8e + $100) ??? cp $8e ; XXX LOW(Unknown_113b8e + $100) ???
jp nz, .asm_113751 jp nz, .asm_113751
ld de, $cc18 ld de, $cc18
ld hl, $cbe7 ld hl, $cbe7

3
mobile/fixed_words.asm
View File

@ -33,8 +33,7 @@ Function11c075: ; 11c075
ret ret
; 11c082 ; 11c082
Function11c082: ; 11c082 Unreferenced_Function11c082: ; 11c082
; XXX
push de push de
ld a, c ld a, c
call Function11c254 call Function11c254

2
mobile/mobile_45.asm
View File

@ -7350,7 +7350,7 @@ INCBIN "data/mobile/ascii-sym.txt"
; everything from here to the end of the bank is related to the ; everything from here to the end of the bank is related to the
; Mobile Stadium option from the continue/newgame menu. ; Mobile Stadium option from the continue/newgame menu.
; XXX better function names ; Needs better function names
MobileStudium: ; 0x117a7f MobileStudium: ; 0x117a7f
ld a, [hInMenu] ld a, [hInMenu]
push af push af

8
mobile/news/news.asm
View File

@ -1,9 +1,8 @@
; http://forums.glitchcity.info/index.php?topic=7509.msg206449#msg206449 ; http://forums.glitchcity.info/index.php?topic=7509.msg206449#msg206449
db $cc, $6b, $1e ; XXX db $cc, $6b, $1e ; unused
Function1f4003: ; 1f4003 Unreferenced_Function1f4003: ; 1f4003
; XXX
ld a, $6 ld a, $6
call GetSRAMBank call GetSRAMBank
ld hl, .news_data ld hl, .news_data
@ -16,8 +15,7 @@ Function1f4003: ; 1f4003
.news_data .news_data
INCBIN "mobile/news/news_1.bin" INCBIN "mobile/news/news_1.bin"
Function1f4dbe: ; 1f4dbe Unreferenced_Function1f4dbe: ; 1f4dbe
; XXX
ld a, $6 ld a, $6
call GetSRAMBank call GetSRAMBank
ld hl, .news_data ld hl, .news_data

3
text/unused_gen_1_trainers.asm
View File

@ -1,5 +1,4 @@
GetGen1TrainerClassName: ; 50a28 Unreferenced_GetGen1TrainerClassName: ; 50a28
; XXX
ld hl, .Strings ld hl, .Strings
ld a, [TrainerClass] ld a, [TrainerClass]
dec a dec a