pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-04-09 05:44:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

Document bugs and glitches

Browse Source
This commit is contained in:
Remy Oukaour
2017-12-12 20:15:07 -05:00
parent f0ab091254
commit 93c32e3580
8 changed files with 954 additions and 525 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
battle/effect_commands.asm
View File

@ -9810,7 +9810,7 @@ GetItemHeldEffect: ; 37dd0
dec a dec a
ld c, a ld c, a
ld b, 0 ld b, 0
ld a, Item2Attributes - Item1Attributes ld a, ITEMATTR_STRUCT_LENGTH
call AddNTimes call AddNTimes
ld a, BANK(ItemAttributes) ld a, BANK(ItemAttributes)
call GetFarHalfword call GetFarHalfword

3
constants/item_constants.asm
View File

@ -298,7 +298,6 @@ CANT_TOSS EQU 1 << 7
; held item effects ; held item effects
const_def const_def
const HELD_NONE const HELD_NONE
const HELD_BERRY const HELD_BERRY
const HELD_2 const HELD_2
@ -382,7 +381,7 @@ const_value SET 70
const ITEMATTR_PERMISSIONS const ITEMATTR_PERMISSIONS
const ITEMATTR_POCKET const ITEMATTR_POCKET
const ITEMATTR_HELP const ITEMATTR_HELP
NUM_ITEMATTRS EQU const_value ITEMATTR_STRUCT_LENGTH EQU const_value
; item menu types ; item menu types
ITEMMENU_NOUSE EQU 0 ITEMMENU_NOUSE EQU 0

689
docs/bugs.md Normal file
View File

File diff suppressed because it is too large Load Diff

2
engine/items.asm
View File

@ -554,7 +554,7 @@ GetItemAttr: ; d460
ld a, [CurItem] ld a, [CurItem]
dec a dec a
ld c, a ld c, a
ld a, NUM_ITEMATTRS ld a, ITEMATTR_STRUCT_LENGTH
call AddNTimes call AddNTimes
ld a, BANK(ItemAttributes) ld a, BANK(ItemAttributes)
call GetFarByte call GetFarByte

4
engine/search.asm
View File

@ -219,7 +219,7 @@ CheckOwnMon: ; 0x4a7ba
ld hl, PlayerName ld hl, PlayerName
rept 4 rept PLAYER_NAME_LENGTH_JAPANESE - 1 ; should be PLAYER_NAME_LENGTH - 1
ld a, [de] ld a, [de]
cp [hl] cp [hl]
jr nz, .notfound jr nz, .notfound
@ -227,7 +227,7 @@ CheckOwnMon: ; 0x4a7ba
jr z, .found ; reached end of string jr z, .found ; reached end of string
inc hl inc hl
inc de inc de
endr endr
ld a, [de] ld a, [de]
cp [hl] cp [hl]

261
items/item_attributes.asm
View File

File diff suppressed because it is too large Load Diff

4
items/item_effects.asm
View File

@ -1006,7 +1006,7 @@ LoveBallMultiplier:
pop de pop de
cp d cp d
pop bc pop bc
ret nz ; for the intended effect, this should be “ret z” ret nz ; for the intended effect, this should be "ret z"
sla b sla b
jr c, .max jr c, .max
@ -1044,7 +1044,7 @@ FastBallMultiplier:
cp -1 cp -1
jr z, .next jr z, .next
cp c cp c
jr nz, .next ; for the intended effect, this should be “jr nz, .loop” jr nz, .next ; for the intended effect, this should be "jr nz, .loop"
sla b sla b
jr c, .max jr c, .max

2
main.asm
View File

@ -236,8 +236,6 @@ CheckNickErrors:: ; 669f
db -1 ; end db -1 ; end
INCLUDE "engine/math.asm" INCLUDE "engine/math.asm"
ItemAttributes: ; 67c1
INCLUDE "items/item_attributes.asm" INCLUDE "items/item_attributes.asm"
INCLUDE "engine/npc_movement.asm" INCLUDE "engine/npc_movement.asm"
INCLUDE "event/happiness_egg.asm" INCLUDE "event/happiness_egg.asm"