From 91a768b24343ffabbe5ab4084451d1e3ecbc306b Mon Sep 17 00:00:00 2001 From: mid-kid Date: Sun, 1 Apr 2018 17:01:51 +0200 Subject: [PATCH] Update file paths in constants/ and docs/ --- constants/audio_constants.asm | 2 +- constants/deco_constants.asm | 16 +++++++-------- constants/engine_flags.asm | 2 +- constants/gfx_constants.asm | 2 +- constants/item_constants.asm | 2 +- constants/item_data_constants.asm | 6 +++--- constants/map_data_constants.asm | 2 +- constants/map_object_constants.asm | 8 ++++---- constants/map_setup_constants.asm | 2 +- constants/menu_constants.asm | 4 ++-- constants/radio_constants.asm | 10 ++++----- constants/scgb_constants.asm | 4 ++-- constants/script_constants.asm | 12 +++++------ constants/sprite_anim_constants.asm | 2 +- constants/sprite_constants.asm | 2 +- constants/text_constants.asm | 2 +- docs/bugs_and_glitches.md | 32 ++++++++++++++--------------- docs/design_flaws.md | 18 ++++++++-------- docs/event_commands.md | 2 +- docs/movement_commands.md | 2 +- 20 files changed, 66 insertions(+), 66 deletions(-) diff --git a/constants/audio_constants.asm b/constants/audio_constants.asm index 7aa0895a3..288caad91 100755 --- a/constants/audio_constants.asm +++ b/constants/audio_constants.asm @@ -17,7 +17,7 @@ const CC ; d (used for pitchoffset) ; channel -; ChannelPointers indexes (see engine/audio.asm) +; ChannelPointers indexes (see audio/engine.asm) const_def const CHAN1 ; 0 const CHAN2 ; 1 diff --git a/constants/deco_constants.asm b/constants/deco_constants.asm index 3b0230965..f385e7cd7 100644 --- a/constants/deco_constants.asm +++ b/constants/deco_constants.asm @@ -35,7 +35,7 @@ const_value = 1 const YELLOW_CARPET const GREEN_CARPET -; DoDecorationAction2.DecoActions indexes (see engine/decorations.asm) +; DoDecorationAction2.DecoActions indexes (see engine/overworld/decorations.asm) const_value = 1 const SET_UP_BED const PUT_AWAY_BED @@ -64,41 +64,41 @@ ENDM ; - DecorationIDs (see data/decorations/decorations.asm) const_value = 1 __enum__ = 0 -; FindOwnedBeds.beds values (see engine/decorations.asm) +; FindOwnedBeds.beds values (see engine/overworld/decorations.asm) const BEDS deco FEATHERY_BED deco PINK_BED deco POLKADOT_BED deco PIKACHU_BED -; FindOwnedCarpets.carpets values (see engine/decorations.asm) +; FindOwnedCarpets.carpets values (see engine/overworld/decorations.asm) const CARPETS deco RED_CARPET deco BLUE_CARPET deco YELLOW_CARPET deco GREEN_CARPET -; FindOwnedPlants.plants values (see engine/decorations.asm) +; FindOwnedPlants.plants values (see engine/overworld/decorations.asm) const PLANTS deco MAGNAPLANT deco TROPICPLANT deco JUMBOPLANT -; FindOwnedPosters.posters values (see engine/decorations.asm) +; FindOwnedPosters.posters values (see engine/overworld/decorations.asm) const POSTERS deco TOWN_MAP deco PIKACHU_POSTER deco CLEFAIRY_POSTER deco JIGGLYPUFF_POSTER -; FindOwnedConsoles.consoles values (see engine/decorations.asm) +; FindOwnedConsoles.consoles values (see engine/overworld/decorations.asm) const CONSOLES deco FAMICOM deco SNES deco N64 deco VIRTUAL_BOY -; FindOwnedBigDolls.big_dolls values (see engine/decorations.asm) +; FindOwnedBigDolls.big_dolls values (see engine/overworld/decorations.asm) const BIG_DOLLS deco BIG_SNORLAX_DOLL deco BIG_ONIX_DOLL deco BIG_LAPRAS_DOLL -; FindOwnedOrnaments.ornaments values (see engine/decorations.asm) +; FindOwnedOrnaments.ornaments values (see engine/overworld/decorations.asm) const DOLLS deco PIKACHU_DOLL deco SURF_PIKACHU_DOLL diff --git a/constants/engine_flags.asm b/constants/engine_flags.asm index 9b2eaaeaf..518edf806 100644 --- a/constants/engine_flags.asm +++ b/constants/engine_flags.asm @@ -1,4 +1,4 @@ -; EngineFlags indexes (see engine/engine_flasg.asm) +; EngineFlags indexes (see engine/engine_flags.asm) const_def ; wPokegearFlags const ENGINE_RADIO_CARD diff --git a/constants/gfx_constants.asm b/constants/gfx_constants.asm index d0f8b2b62..515045306 100644 --- a/constants/gfx_constants.asm +++ b/constants/gfx_constants.asm @@ -41,7 +41,7 @@ SPRITEOAMSTRUCT_LENGTH EQU const_value NUM_SPRITE_OAM_STRUCTS EQU 40 ; see wVirtualOAM -; PokeAnims indexes (see engine/pic_animation.asm) +; PokeAnims indexes (see engine/gfx/pic_animation.asm) const_def const ANIM_MON_SLOW const ANIM_MON_NORMAL diff --git a/constants/item_constants.asm b/constants/item_constants.asm index 426f28bd0..ec5f5f211 100644 --- a/constants/item_constants.asm +++ b/constants/item_constants.asm @@ -3,7 +3,7 @@ ; - ItemNames (see data/items/names.asm) ; - ItemDescriptions (see data/items/descriptions.asm) ; - ItemAttributes (see data/items/attributes.asm) -; - ItemEffects (see engine/item_effects.asm) +; - ItemEffects (see engine/items/item_effects.asm) const_def const NO_ITEM ; 00 const MASTER_BALL ; 01 diff --git a/constants/item_data_constants.asm b/constants/item_data_constants.asm index 1af3c47ac..055e24656 100644 --- a/constants/item_data_constants.asm +++ b/constants/item_data_constants.asm @@ -17,8 +17,8 @@ ITEMATTR_STRUCT_LENGTH EQU const_value const TM_HM ; 4 ; item menu types -; UseItem.dw indexes (see engine/pack.asm) -; UseRegisteredItem.SwitchTo indexes (see engine/select_menu.asm) +; UseItem.dw indexes (see engine/items/pack.asm) +; UseRegisteredItem.SwitchTo indexes (see engine/overworld/select_menu.asm) ITEMMENU_NOUSE EQU 0 ITEMMENU_CURRENT EQU 4 ITEMMENU_PARTY EQU 5 @@ -130,7 +130,7 @@ MAIL_STRUCT_LENGTH EQU $2f ; mailmsg struct const HELD_FOCUS_BAND -; mart types (see engine/mart.asm) +; mart types (see engine/items/mart.asm) const_def const MARTTYPE_STANDARD const MARTTYPE_BITTER diff --git a/constants/map_data_constants.asm b/constants/map_data_constants.asm index 0178e22b1..9a160a2fa 100644 --- a/constants/map_data_constants.asm +++ b/constants/map_data_constants.asm @@ -103,6 +103,6 @@ const_value = -1 NUM_SPAWNS EQU const_value -; outdoor sprite limits (see engine/overworld.asm) +; outdoor sprite limits (see engine/overworld/overworld.asm) MAX_OUTDOOR_SPRITES EQU 23 SPRITE_GFX_LIST_CAPACITY EQU $20 diff --git a/constants/map_object_constants.asm b/constants/map_object_constants.asm index b752b66e8..73685d4ec 100644 --- a/constants/map_object_constants.asm +++ b/constants/map_object_constants.asm @@ -121,7 +121,7 @@ MAPOBJECT_SCREEN_WIDTH EQU 12 NUM_SPRITEMOVEDATA EQU const_value SPRITEMOVEDATA_FIELDS EQU 6 -; MapObjectMovementPattern.Pointers indexes (see engine/map_objects.asm) +; MapObjectMovementPattern.Pointers indexes (see engine/overworld/map_objects.asm) const_def const SPRITEMOVEFN_00 ; 00 const SPRITEMOVEFN_RANDOM_WALK_Y ; 01 @@ -152,7 +152,7 @@ SPRITEMOVEDATA_FIELDS EQU 6 const SPRITEMOVEFN_BOULDERDUST ; 1a const SPRITEMOVEFN_GRASS ; 1b -; StepTypesJumptable indexes (see engine/map_objects.asm) +; StepTypesJumptable indexes (see engine/overworld/map_objects.asm) const_def const STEP_TYPE_00 ; 00 const STEP_TYPE_SLEEP ; 01 @@ -181,7 +181,7 @@ SPRITEMOVEDATA_FIELDS EQU 6 const STEP_TYPE_18 ; 18 const STEP_TYPE_SKYFALL_TOP ; 19 -; ObjectActionPairPointers indexes (see engine/map_object_action.asm) +; ObjectActionPairPointers indexes (see engine/overworld/map_object_action.asm) const_def const OBJECT_ACTION_00 ; 00 const OBJECT_ACTION_STAND ; 01 @@ -237,7 +237,7 @@ SPRITEMOVEDATA_FIELDS EQU 6 const FACING_GRASS_2 ; 1f -; DoPlayerMovement.DoStep arguments (see engine/player_movement.asm) +; DoPlayerMovement.DoStep arguments (see engine/overworld/player_movement.asm) const_def const STEP_SLOW ; 0 const STEP_WALK ; 1 diff --git a/constants/map_setup_constants.asm b/constants/map_setup_constants.asm index 9c6164169..426cbb298 100644 --- a/constants/map_setup_constants.asm +++ b/constants/map_setup_constants.asm @@ -14,7 +14,7 @@ const MAPSETUP_BADWARP ; fb const MAPSETUP_FLY ; fc -; MapSetupCommands indexes (see engine/map_setup.asm) +; MapSetupCommands indexes (see engine/overworld/map_setup.asm) ; Names taken from Condensation water's scripting compendium ; https://hax.iimarck.us/files/scriptingcodes_eng.htm const_def diff --git a/constants/menu_constants.asm b/constants/menu_constants.asm index f1ca20ae5..46c65474d 100644 --- a/constants/menu_constants.asm +++ b/constants/menu_constants.asm @@ -34,7 +34,7 @@ ; MonMenuOptions indexes (see data/mon_menu.asm) -; used by PokemonActionSubmenu (see engine/start_menu.asm) +; used by PokemonActionSubmenu (see engine/menus/start_menu.asm) const_def 1 ; moves const MONMENUITEM_CUT ; 1 @@ -83,7 +83,7 @@ HMENURETURN_ASM EQU %11111111 const PARTYMENUACTION_GIVE_MON_FEMALE ; unused const PARTYMENUACTION_GIVE_ITEM const PARTYMENUACTION_MOBILE ; mobile -; PrintPartyMenuActionText arguments (see engine/party_menu.asm) +; PrintPartyMenuActionText arguments (see engine/pokemon/party_menu.asm) const_def $f0 const PARTYMENUTEXT_HEAL_PSN const PARTYMENUTEXT_HEAL_BRN diff --git a/constants/radio_constants.asm b/constants/radio_constants.asm index 8903ef005..537b3289e 100644 --- a/constants/radio_constants.asm +++ b/constants/radio_constants.asm @@ -1,8 +1,8 @@ ; radio channel ids ; indexes for: ; - RadioChannelSongs (see data/radio/channel_music.asm) -; - PlayRadioShow/RadioJumptable (see engine/radio.asm) -; - RadioChannels (see engine/radio.asm) +; - PlayRadioShow/RadioJumptable (see engine/pokegear/radio.asm) +; - RadioChannels (see engine/pokegear/radio.asm) const_def const OAKS_POKEMON_TALK ; 00 const POKEDEX_SHOW ; 01 @@ -94,7 +94,7 @@ const POKEDEX_SHOW_7 ; 56 const POKEDEX_SHOW_8 ; 57 -; PlayRadio.StationPointers indexes (see engine/pokegear.asm) +; PlayRadio.StationPointers indexes (see engine/pokegear/pokegear.asm) const_def const MAPRADIO_POKEMON_CHANNEL const MAPRADIO_OAKS_POKEMON_TALK @@ -106,7 +106,7 @@ const MAPRADIO_LETS_ALL_SING const MAPRADIO_ROCKET -; These tables in engine/radio.asm are all sized to a power of 2 +; These tables in engine/pokegear/radio.asm are all sized to a power of 2 ; so there's no need for a rejection sampling loop NUM_OAKS_POKEMON_TALK_ADVERBS EQU 16 ; OaksPKMNTalk8.Adverbs NUM_OAKS_POKEMON_TALK_ADJECTIVES EQU 16 ; OaksPKMNTalk9.Adjectives @@ -117,7 +117,7 @@ NUM_PNP_PLACES_ADJECTIVES EQU 16 ; PeoplePlaces7.Adjectives NUM_PASSWORD_CATEGORIES EQU 11 NUM_PASSWORDS_PER_CATEGORY EQU 3 -; GetBuenasPassword.StringFunctionJumpTable indexes (see engine/radio.asm) +; GetBuenasPassword.StringFunctionJumpTable indexes (see engine/pokegear/radio.asm) const_def const BUENA_MON const BUENA_ITEM diff --git a/constants/scgb_constants.asm b/constants/scgb_constants.asm index e31a2139f..e7d987113 100755 --- a/constants/scgb_constants.asm +++ b/constants/scgb_constants.asm @@ -1,4 +1,4 @@ -; GetSGBLayout arguments (see engine/cgb_layouts.asm and engine/sgb_layouts.asm) +; GetSGBLayout arguments (see engine/gfx/cgb_layouts.asm and engine/gfx/sgb_layouts.asm) const_def const SCGB_BATTLE_GRAYSCALE const SCGB_BATTLE_COLORS @@ -36,7 +36,7 @@ SCGB_PARTY_MENU_HP_PALS EQU -4 SCGB_RAM EQU -1 ; PredefPals indexes (see gfx/sgb/predef.pal) -; GetPredefPal arguments (see engine/color.asm) +; GetPredefPal arguments (see engine/gfx/color.asm) const_def const PREDEFPAL_00 const PREDEFPAL_PALLET diff --git a/constants/script_constants.asm b/constants/script_constants.asm index dd086e6b3..e1feaaed9 100644 --- a/constants/script_constants.asm +++ b/constants/script_constants.asm @@ -38,7 +38,7 @@ NUM_MEM_BUFFERS EQU const_value ; writecode/checkcode arguments -; _GetVarAction.VarActionTable indexes (see engine/variables.asm) +; _GetVarAction.VarActionTable indexes (see engine/overworld/variables.asm) const_def const VAR_STRINGBUFFER2 ; 00 const VAR_PARTYCOUNT ; 01 @@ -75,7 +75,7 @@ RETVAR_ADDR_DE EQU (1 << 6) RETVAR_EXECUTE EQU (2 << 6) -; PlayerEventScriptPointers indexes (see engine/events.asm) +; PlayerEventScriptPointers indexes (see engine/overworld/events.asm) const_def -1 const PLAYEREVENT_MAPSCRIPT const PLAYEREVENT_NONE @@ -92,7 +92,7 @@ NUM_PLAYER_EVENTS EQU const_value ; bg_event types -; TryBGEvent arguments (see engine/events.asm) +; TryBGEvent arguments (see engine/overworld/events.asm) const_def const BGEVENT_READ const BGEVENT_UP @@ -105,7 +105,7 @@ NUM_PLAYER_EVENTS EQU const_value const BGEVENT_COPY ; object_event types -; TryObjectEvent arguments (see engine/events.asm) +; TryObjectEvent arguments (see engine/overworld/events.asm) const_def const OBJECTTYPE_SCRIPT const OBJECTTYPE_ITEMBALL @@ -203,7 +203,7 @@ EMOTE_MEM EQU -1 NUM_FRUIT_TREES EQU const_value + -1 ; describedecoration arguments -; DescribeDecoration.JumpTable indexes (see engine/decorations.asm) +; DescribeDecoration.JumpTable indexes (see engine/overworld/decorations.asm) const_def const DECODESC_POSTER ; 0 const DECODESC_LEFT_DOLL ; 1 @@ -259,7 +259,7 @@ NUM_FRUIT_TREES EQU const_value + -1 const HEALMACHINE_HALL_OF_FAME ; 2 ; UnownPuzzle writebyte arguments -; LoadUnownPuzzlePiecesGFX.LZPointers indexes (see engine/unown_puzzle.asm) +; LoadUnownPuzzlePiecesGFX.LZPointers indexes (see engine/games/unown_puzzle.asm) const_def const UNOWNPUZZLE_KABUTO ; 0 const UNOWNPUZZLE_OMANYTE ; 1 diff --git a/constants/sprite_anim_constants.asm b/constants/sprite_anim_constants.asm index 8be0f312a..0fbc4d849 100644 --- a/constants/sprite_anim_constants.asm +++ b/constants/sprite_anim_constants.asm @@ -67,7 +67,7 @@ NUM_SPRITE_ANIM_STRUCTS EQU 10 ; see wSpriteAnimationStructs const SPRITE_ANIM_INDEX_INTRO_SUICUNE_AWAY ; 2b const SPRITE_ANIM_INDEX_CELEBI ; 2c -; DoAnimFrame.Jumptable indexes (see engine/sprite_anims.asm) +; DoAnimFrame.Jumptable indexes (see engine/gfx/sprite_anims.asm) const_def const SPRITE_ANIM_SEQ_NULL ; 00 const SPRITE_ANIM_SEQ_PARTY_MON ; 01 diff --git a/constants/sprite_constants.asm b/constants/sprite_constants.asm index c23a3b246..0e63cce52 100644 --- a/constants/sprite_constants.asm +++ b/constants/sprite_constants.asm @@ -144,7 +144,7 @@ SPRITE_POKEMON EQU const_value const SPRITE_LUGIA ; a1 const SPRITE_HO_OH ; a2 -; special GetMonSprite values (see engine/overworld.asm) +; special GetMonSprite values (see engine/overworld/overworld.asm) const_def $e0 const SPRITE_DAY_CARE_MON_1 ; e0 const SPRITE_DAY_CARE_MON_2 ; e1 diff --git a/constants/text_constants.asm b/constants/text_constants.asm index a64039f64..5a9a35931 100644 --- a/constants/text_constants.asm +++ b/constants/text_constants.asm @@ -36,7 +36,7 @@ TEXTBOX_INNERY EQU TEXTBOX_Y + 2 const PRINTNUM_RIGHTALIGN_F ; 6 const PRINTNUM_LEADINGZEROS_F ; 7 -; PrintNum arguments (see engine/printnum.asm) +; PrintNum arguments (see engine/math/printnum.asm) PRINTNUM_MONEY EQU 1 << PRINTNUM_MONEY_F PRINTNUM_RIGHTALIGN EQU 1 << PRINTNUM_RIGHTALIGN_F PRINTNUM_LEADINGZEROS EQU 1 << PRINTNUM_LEADINGZEROS_F diff --git a/docs/bugs_and_glitches.md b/docs/bugs_and_glitches.md index 0212ed6fc..c24876873 100644 --- a/docs/bugs_and_glitches.md +++ b/docs/bugs_and_glitches.md @@ -490,7 +490,7 @@ This is a bug with `LongAnim_UpdateVariables` in [engine/battle/anim_hp_bar.asm] ([Video](https://www.youtube.com/watch?v=9KyNVIZxJvI)) -This is a bug with `ShortHPBar_CalcPixelFrame` in [engine/anim_hp_bar.asm](/engine/anim_hp_bar.asm): +This is a bug with `ShortHPBar_CalcPixelFrame` in [engine/battle/anim_hp_bar.asm](/engine/battle/anim_hp_bar.asm): ```asm ld b, 0 @@ -519,7 +519,7 @@ This is a bug with `ShortHPBar_CalcPixelFrame` in [engine/anim_hp_bar.asm](/engi This can bring Pokémon straight from level 1 to 100 by gaining just a few experience points. -This is a bug with `CalcExpAtLevel` in [engine/experience.asm](/engine/experience.asm): +This is a bug with `CalcExpAtLevel` in [engine/pokemon/experience.asm](/engine/pokemon/experience.asm): ```asm CalcExpAtLevel: ; 50e47 @@ -589,7 +589,7 @@ Text_StringBuffer2ExpPoints:: ## BRN/PSN/PAR do not affect catch rate -This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_effects.asm): +This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm): ```asm ; This routine is buggy. It was intended that SLP and FRZ provide a higher @@ -923,7 +923,7 @@ This is a bug with `_HallOfFamePC.DisplayMonAndStrings` in [engine/events/hallof ([Video](https://www.youtube.com/watch?v=ojq3xqfRF6I)) -This is a bug with `Slots_PayoutAnim` in [engine/slot_machine.asm](/engine/slot_machine.asm): +This is a bug with `Slots_PayoutAnim` in [engine/games/slot_machine.asm](/engine/games/slot_machine.asm): ```asm .okay @@ -973,7 +973,7 @@ This is a bug with `PlayBattleMusic` in [engine/battle/start_battle.asm](/engine ## No bump noise if standing on tile `$3E` -This is a bug with `DoPlayerMovement.CheckWarp` in [engine/player_movement.asm](/engine/player_movement.asm): +This is a bug with `DoPlayerMovement.CheckWarp` in [engine/overworld/player_movement.asm](/engine/overworld/player_movement.asm): ```asm ; Bug: Since no case is made for STANDING here, it will check @@ -1108,7 +1108,7 @@ In [home/map.asm](/home/map.asm): This bug is why the Lapras in [maps/UnionCaveB2F.asm](/maps/UnionCaveB2F.asm), which uses `SPRITEMOVEDATA_SWIM_WANDER`, is not restricted by its `1, 1` movement radius. -In [engine/npc_movement.asm](/engine/npc_movement.asm): +In [engine/overworld/npc_movement.asm](/engine/overworld/npc_movement.asm): ```asm ld hl, OBJECT_FLAGS1 @@ -1126,7 +1126,7 @@ In [engine/npc_movement.asm](/engine/npc_movement.asm): This bug can allow you to talk to Eusine in Celadon City and encounter Ho-Oh with only traded legendary beasts. -In [engine/search.asm](/engine/search.asm): +In [engine/pokemon/search.asm](/engine/pokemon/search.asm): ```asm ; check OT @@ -1157,7 +1157,7 @@ endr This bug can affect Mew or Pokémon other than Ditto that used Transform via Mirror Move or Sketch. -This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_effects.asm): +This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm): ```asm ld hl, wEnemySubStatus5 @@ -1229,7 +1229,7 @@ This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_ef ([Video](https://www.youtube.com/watch?v=v1ErZdLCIyU)) -This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_effects.asm): +This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm): ```asm .room_in_party @@ -1254,7 +1254,7 @@ This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_ef ## `HELD_CATCH_CHANCE` has no effect -This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_effects.asm): +This is a bug with `PokeBallEffect` in [engine/items/item_effects.asm](/engine/items/item_effects.asm): ```asm ; BUG: farcall overwrites a, and GetItemHeldEffect takes b anyway. @@ -1281,7 +1281,7 @@ This is a bug with `PokeBallEffect` in [engine/item_effects.asm](/engine/item_ef ## Only the first three `EvosAttacks` evolution entries can have Stone compatibility reported correctly -This is a bug with `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` in [engine/party_menu.asm](/engine/party_menu.asm): +This is a bug with `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` in [engine/pokemon/party_menu.asm](/engine/pokemon/party_menu.asm): ```asm .DetermineCompatibility: ; 50268 @@ -1304,7 +1304,7 @@ This is a bug with `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` i ## `EVOLVE_STAT` can break Stone compatibility reporting -This is a bug with `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` in [engine/party_menu.asm](/engine/party_menu.asm): +This is a bug with `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` in [engine/pokemon/party_menu.asm](/engine/pokemon/party_menu.asm): ```asm .loop2 @@ -1337,7 +1337,7 @@ This is a bug with `PlacePartyMonEvoStoneCompatibility.DetermineCompatibility` i ## `ScriptCall` can overflow `wScriptStack` and crash -In [engine/scripting.asm](/engine/scripting.asm): +In [engine/overworld/scripting.asm](/engine/overworld/scripting.asm): ```asm ScriptCall: @@ -1377,7 +1377,7 @@ ScriptCall: ## `LoadSpriteGFX` does not limit the capacity of `UsedSprites` -In [engine/overworld.asm](/engine/overworld.asm): +In [engine/overworld/overworld.asm](/engine/overworld/overworld.asm): ```asm LoadSpriteGFX: ; 14306 @@ -1414,7 +1414,7 @@ LoadSpriteGFX: ; 14306 ## `ChooseWildEncounter` doesn't really validate the wild Pokémon species -In [engine/wildmons.asm](/engine/wildmons.asm): +In [engine/overworld/wildmons.asm](/engine/overworld/wildmons.asm): ```asm ChooseWildEncounter: ; 2a14f @@ -1452,7 +1452,7 @@ ValidateTempWildMonSpecies: ; 2a4a0 ## `TryObjectEvent` arbitrary code execution -In [engine/events.asm](/engine/events.asm): +In [engine/overworld/events.asm](/engine/overworld/events.asm): ```asm ; Bug: If IsInArray returns nc, data at bc will be executed as code. diff --git a/docs/design_flaws.md b/docs/design_flaws.md index 20b70cac1..e4a81123b 100644 --- a/docs/design_flaws.md +++ b/docs/design_flaws.md @@ -25,7 +25,7 @@ dba_pic: MACRO ; dbw bank, address ENDM ``` -The offset is translated into a correct bank by `FixPicBank` in [engine/load_pics.asm](/engine/load_pics.asm): +The offset is translated into a correct bank by `FixPicBank` in [engine/gfx/load_pics.asm](/engine/gfx/load_pics.asm): ```asm FixPicBank: ; 511c5 @@ -107,7 +107,7 @@ ROMX $49 "Pics 2" ``` -Two routines in [engine/load_pics.asm](/engine/load_pics.asm) make this assumption; `GetFrontpicPointer`: +Two routines in [engine/gfx/load_pics.asm](/engine/gfx/load_pics.asm) make this assumption; `GetFrontpicPointer`: ```asm ld a, [wCurPartySpecies] @@ -295,7 +295,7 @@ Modify `Pokedex_LoadAnyFootprint`: NUM_TMS = const_value - TM01 - 2 ; discount ITEM_C3 and ITEM_DC ``` -`GetTMHMNumber` and `GetNumberedTMHM` in [engine/items.asm](/engine/items.asm) have to compensate for this: +`GetTMHMNumber` and `GetNumberedTMHM` in [engine/items/items.asm](/engine/items/items.asm) have to compensate for this: ```asm GetTMHMNumber:: ; d407 @@ -338,7 +338,7 @@ GetNumberedTMHM: ; d417 Move `ITEM_C3` and `ITEM_DC` above all the TMs in every table of item data. -Modify engine/items.asm: +Modify engine/items/items.asm: ```asm GetTMHMNumber:: ; d407 @@ -399,7 +399,7 @@ GetDexEntryPointer: ; 44333 db BANK(PokedexEntries4) ``` -`GetPokedexEntryBank` in [engine/item_effects.asm](/engine/item_effects.asm): +`GetPokedexEntryBank` in [engine/items/item_effects.asm](/engine/items/item_effects.asm): ```asm GetPokedexEntryBank: @@ -425,7 +425,7 @@ GetPokedexEntryBank: db BANK(PokedexEntries4) ``` -And `PokedexShow_GetDexEntryBank` in [engine/radio.asm](/engine/radio.asm): +And `PokedexShow_GetDexEntryBank` in [engine/pokegear/radio.asm](/engine/pokegear/radio.asm): ```asm PokedexShow_GetDexEntryBank: @@ -457,7 +457,7 @@ PokedexShow_GetDexEntryBank: ## Identical sine wave code and data is repeated five times -`_Sine` in [engine/routines/sine.asm](/engine/routines/sine.asm): +`_Sine` in [engine/math/sine.asm](/engine/math/sine.asm): ```asm _Sine:: ; 84d9 @@ -466,7 +466,7 @@ _Sine:: ; 84d9 calc_sine_wave ``` -`Sprites_Cosine` and `Sprites_Sine` in [engine/sprites.asm](/engine/sprites.asm): +`Sprites_Cosine` and `Sprites_Sine` in [engine/gfx/sprites.asm](/engine/gfx/sprites.asm): ```asm Sprites_Cosine: ; 8e72a @@ -583,7 +583,7 @@ ENDM ## `GetForestTreeFrame` works, but it's still bad -In [engine/tileset_anims.asm](/engine/tileset_anims.asm): +In [engine/tilesets/tileset_anims.asm](/engine/tilesets/tileset_anims.asm): ```asm GetForestTreeFrame: ; fc54c diff --git a/docs/event_commands.md b/docs/event_commands.md index bb6d4def4..5eaf1d778 100644 --- a/docs/event_commands.md +++ b/docs/event_commands.md @@ -1,6 +1,6 @@ # Event Commands -Defined in [macros/scripts/events.asm](/macros/scripts/events.asm) and [engine/scripting.asm:ScriptCommandTable](/engine/scripting.asm). +Defined in [macros/scripts/events.asm](/macros/scripts/events.asm) and [engine/overworld/scripting.asm:ScriptCommandTable](/engine/overworld/scripting.asm). Until this document is filled out, the [G/S Scripting Compendium](https://hax.iimarckus.org/files/scriptingcodes_eng.htm) has descriptions for most of these commands. It was written for G/S binary hacking and not Crystal assembly hacking, so it's not 100% accurate for pokecrystal. diff --git a/docs/movement_commands.md b/docs/movement_commands.md index 10792c88b..794dd8a98 100644 --- a/docs/movement_commands.md +++ b/docs/movement_commands.md @@ -1,6 +1,6 @@ # Movement Commands -Defined in [macros/scripts/movement.asm](/macros/scripts/movement.asm) and [engine/movement.asm:MovementPointers](/engine/movement.asm). +Defined in [macros/scripts/movement.asm](/macros/scripts/movement.asm) and [engine/overworld/movement.asm:MovementPointers](/engine/overworld/movement.asm). ## `$00`−`$03`: turn_head direction