pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-11-16 11:27:33 -08:00
Code Issues Packages Projects Releases Wiki Activity

Clear sprite animations before board menu die roll animation to prevent artifacts such as from party menu animations (#11)

Browse Source
This commit is contained in:
xCrystal 2023-10-23 17:36:52 +02:00
parent 9fcd72af19
commit 866729d024
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
engine/board/menu.asm
View File

@ -90,6 +90,8 @@ BoardMenu::
ld a, BOARDMENUITEM_DIE ld a, BOARDMENUITEM_DIE
.ok .ok
ld [wBoardMenuCursorPosition], a ld [wBoardMenuCursorPosition], a
; clear any other sprite animation
farcall ClearSpriteAnims
; refresh overworld sprites to hide those behind textbox before drawing new graphics ; refresh overworld sprites to hide those behind textbox before drawing new graphics
call UpdateSprites call UpdateSprites
farcall LoadBoardMenuGFX farcall LoadBoardMenuGFX
@ -396,6 +398,7 @@ BoardMenu_OpenSubmenu:
BoardMenu_CloseSubmenu: BoardMenu_CloseSubmenu:
call ClearBGPalettes call ClearBGPalettes
farcall ClearSpriteAnims
ld a, TRUE ld a, TRUE
ld [wText2bpp], a ld [wText2bpp], a
call EnableOverworldHUD call EnableOverworldHUD

4
engine/overworld/scripting.asm
View File

@ -464,11 +464,7 @@ Script_verbosegiveitem:
ld de, GiveItemScript ld de, GiveItemScript
jp ScriptCall jp ScriptCall
GiveItemScript_DummyFunction:
ret
GiveItemScript: GiveItemScript:
callasm GiveItemScript_DummyFunction
writetext .ReceivedItemText writetext .ReceivedItemText
iffalse .Full iffalse .Full
waitsfx waitsfx