pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-04-09 05:44:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

Check some errors (not enough).

Browse Source 
malloc can always fail. Check to avoid null dereference.

malloc(0) is well defined but leads to an eventual crash on some systems.
Check it too.
This commit is contained in:
IIMarckus
2017-06-29 22:45:30 -06:00
parent 2ebbe91fe8
commit 80888726b9
3 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools/palette.c
View File

@@ -50,9 +50,17 @@ void print_palette(char* palette_filename) {
fseek(f, 0, SEEK_END);
size = ftell(f);
if (!size) {
fprintf(stderr, "empty file %s\n", palette_filename);
exit(1);
}
rewind(f);
bytes = malloc(size);
if (!bytes) {
fprintf(stderr, "malloc failure\n");
exit(1);
}
fseek(f, 0, SEEK_SET);
fread(bytes, 1, size, f);

8
tools/pokemon_animation.c
View File

@@ -54,9 +54,17 @@ void make_frames(struct Frames* frames, struct Bitmasks* bitmasks, char* tilemap
fseek(f, 0, SEEK_END);
size = ftell(f);
if (!size) {
fprintf(stderr, "empty file %s\n", tilemap_filename);
exit(1);
}
rewind(f);
tilemap = malloc(size);
if (!tilemap) {
fprintf(stderr, "malloc failure\n");
exit(1);
}
fread(tilemap, 1, size, f);
fclose(f);

8
tools/pokemon_animation_graphics.c
View File

@@ -90,8 +90,16 @@ void create_tilemap(struct Tilemap* tilemap, struct Graphic* graphic, char* grap
}
fseek(f, 0, SEEK_END);
graphics_size = ftell(f);
if (!graphics_size) {
fprintf(stderr, "empty file %s\n", graphics_filename);
exit(1);
}
rewind(f);
graphics = malloc(graphics_size);
if (!graphics) {
fprintf(stderr, "malloc failure\n");
exit(1);
}
fread(graphics, 1, graphics_size, f);
fclose(f);