Remove redundant data/ filename prefixes

constants/item_constants.asm

@@ -1,9 +1,9 @@
 ; item ids
 ; indexes for:
-; - ItemAttributes (see data/items/item_attributes.asm)
+; - ItemNames (see data/items/names.asm)
-; - ItemDescriptions (see data/items/item_descriptions.asm)
+; - ItemDescriptions (see data/items/descriptions.asm)
+; - ItemAttributes (see data/items/attributes.asm)
 ; - ItemEffects (see engine/item_effects.asm)
-; - ItemNames (see data/items/item_names.asm)
 	const_def
 	const NO_ITEM      ; $00
 	const MASTER_BALL  ; $01

constants/item_data_constants.asm

@@ -1,4 +1,4 @@
-; item_attributes struct members (see data/items/item_attributes.asm)
+; item_attributes struct members (see data/items/attributes.asm)
 	const_def
 	const ITEMATTR_PRICE
 	const ITEMATTR_PRICE_HI

constants/map_constants.asm

@@ -16,8 +16,8 @@ endm
 ; map group ids
 ; `newgroup` indexes are for:
 ; - MapGroupPointers (see maps/map_headers.asm)
+; - MapGroupRoofs (see data/maps/roofs.asm)
 ; - OutdoorSprites (see data/maps/outdoor_sprites.asm)
-; - MapGroupRoofs (see data/maps/mapgroup_roofs.asm)
 ; `mapgroup` indexes are for the sub-tables of MapGroupPointers (see maps/map_headers.asm)
 	const_def
 

constants/map_setup_constants.asm

@@ -1,5 +1,5 @@
 ; hMapEntryMethod values
-; MapSetupScripts indexes (see data/maps/map_setup_scripts.asm)
+; MapSetupScripts indexes (see data/maps/setup_scripts.asm)
 const_value SET $f1
 	const MAPSETUP_WARP       ; f1
 	const MAPSETUP_CONTINUE   ; f2

constants/move_constants.asm

@@ -1,9 +1,9 @@
 ; move ids
 ; indexes for:
 ; - Moves (see data/moves/moves.asm)
-; - MoveNames (see data/moves/move_names.asm)
+; - MoveNames (see data/moves/names.asm)
-; - MoveDescriptions (see data/moves/move_descriptions.asm)
+; - MoveDescriptions (see data/moves/descriptions.asm)
-; - BattleAnimations (see data/moves/move_anims.asm)
+; - BattleAnimations (see data/moves/animations.asm)
 	const_def
 	const NO_MOVE      ; 00
 	const POUND        ; 01

constants/move_effect_constants.asm

@@ -1,4 +1,4 @@
-; MoveEffectsPointers indexes (see data/moves/move_effects_pointers.asm)
+; MoveEffectsPointers indexes (see data/moves/effects_pointers.asm)
 	const_def
 	const EFFECT_NORMAL_HIT
 	const EFFECT_SLEEP

constants/pokemon_constants.asm

@@ -1,21 +1,21 @@
 ; pokemon ids
 ; indexes for:
-; - PokemonCries (see data/pokemon/cries.asm)
+; - PokemonNames (see data/pokemon/names.asm)
 ; - BaseData (see data/pokemon/base_stats.asm)
-; - EggMovePointers (see data/pokemon/egg_move_pointers.asm)
 ; - EvosAttacksPointers (see data/pokemon/evos_attacks_pointers.asm)
-; - PokemonNames (see data/pokemon/pokemon_names.asm)
+; - EggMovePointers (see data/pokemon/egg_move_pointers.asm)
+; - PokemonCries (see data/pokemon/cries.asm)
+; - MonMenuIcons (see data/pokemon/menu_icons.asm)
+; - PokemonPalettes (see data/pokemon/palettes.asm)
 ; - PokedexDataPointerTable (see data/pokemon/dex_entry_pointers.asm)
-; - AnimationPointers (see gfx/pokemon/anim_pointers.asm)
-; - BitmasksPointers (see gfx/pokemon/bitmask_pointers.asm)
-; - AnimationExtraPointers (see gfx/pokemon/extra_pointers.asm)
-; - FramesPointers (see gfx/pokemon/frame_pointers.asm)
-; - PicPointers (see gfx/pokemon/pic_pointers.asm)
-; - PokemonPalettes (see data/palettes/pokemon_palettes.asm)
 ; - AlphabeticalPokedexOrder (see data/pokemon/dex_order_alpha.asm)
 ; - NewPokedexOrder (see data/pokemon/dex_order_new.asm)
-; - MonMenuIcons (see data/pokemon/menu_icons.asm)
 ; - Pokered_MonIndices (see data/time_capsule/mon_order.asm)
+; - PokemonPicPointers (see gfx/pokemon/pic_pointers.asm)
+; - AnimationPointers (see gfx/pokemon/anim_pointers.asm)
+; - AnimationExtraPointers (see gfx/pokemon/extra_pointers.asm)
+; - BitmasksPointers (see gfx/pokemon/bitmask_pointers.asm)
+; - FramesPointers (see gfx/pokemon/frame_pointers.asm)
 ; - SortedPokemon (see mobile/fixed_words.asm)
 const_value set 1
 	const BULBASAUR  ; 01

constants/trainer_constants.asm

@@ -5,12 +5,14 @@ ENDM
 
 ; trainer class ids
 ; `trainerclass` indexes are for:
-; - TrainerClassAttributes (see data/trainers/trainer_attributes.asm)
+; - TrainerClassNames (see data/trainers/class_names.asm)
-; - TrainerClassDVs (see data/trainers/trainer_dvs.asm)
+; - TrainerClassAttributes (see data/trainers/attributes.asm)
-; - TrainerClassNames (see data/trainers/trainer_class_names.asm)
+; - TrainerClassDVs (see data/trainers/dvs.asm)
-; - TrainerEncounterMusic (see data/trainers/encounter_music.asm)
 ; - TrainerGroups (see data/trainers/party_pointers.asm)
-; - BTTrainerClassGenders (see data/trainers/gendered_trainers.asm)
+; - TrainerEncounterMusic (see data/trainers/encounter_music.asm)
+; - TrainerPicPointers (see data/trainers/pic_pointers.asm)
+; - TrainerPalettes (see data/trainers/palettes.asm)
+; - BTTrainerClassGenders (see data/trainers/genders.asm)
 ; trainer constants are Trainers indexes, for the sub-tables of TrainerGroups (see data/trainers/parties.asm)
 	enum_start
 CHRIS EQU __enum__

constants/trainer_data_constants.asm

@@ -1,4 +1,4 @@
-; TrainerClassAttributes struct members (see data/trainers/trainer_attributes.asm)
+; TrainerClassAttributes struct members (see data/trainers/attributes.asm)
 	const_def
 	const TRNATTR_ITEM1           ; 0
 	const TRNATTR_ITEM2           ; 1
@@ -45,7 +45,7 @@ SWITCH_SOMETIMES   EQU 1 << SWITCH_SOMETIMES_F
 SWITCH_RARELY      EQU 1 << SWITCH_RARELY_F
 SWITCH_OFTEN       EQU 1 << SWITCH_OFTEN_F
 
-; TrainerTypes indexes (see trainers/read_party.asm)
+; TrainerTypes indexes (see engine/battle/read_trainer_party.asm)
 	const_def
 	const TRAINERTYPE_NORMAL
 	const TRAINERTYPE_MOVES

data/battle_command_pointers.asm

@@ -1,7 +1,7 @@
 	dw 0 ; padding
 
 BattleCommandPointers: ; 3fd28
-; entries correspond to macros/scripts/effect_commands.asm
+; entries correspond to macros/scripts/battle_commands.asm
 	dw BattleCommand_CheckTurn ; 34084
 	dw BattleCommand_CheckObedience ; 343db
 	dw BattleCommand_UsedMoveText ; 34541

data/pokemon/pic_pointers.asm

@@ -1,4 +1,4 @@
-PicPointers::
+PokemonPicPointers::
 ; entries correspond to Pokémon species, two apiece
 	dba_pic BulbasaurFrontpic
 	dba_pic BulbasaurBackpic

data/trainers/dvs.asm

@@ -1,24 +1,3 @@
-GetTrainerDVs: ; 270c4
-; Return the DVs of OtherTrainerClass in bc
-
-	push hl
-	ld a, [OtherTrainerClass]
-	dec a
-	ld c, a
-	ld b, 0
-
-	ld hl, TrainerClassDVs
-	add hl, bc
-	add hl, bc
-
-	ld a, [hli]
-	ld b, a
-	ld c, [hl]
-
-	pop hl
-	ret
-; 270d6
-
 TrainerClassDVs: ; 270d6
 ; entries correspond to trainer classes (see constants/trainer_constants.asm)
 	;  Atk  Spd

docs/battle_anim_commands.md

@@ -1,6 +1,6 @@
 # Battle Animation Commands
 
-Defined in [macros/scripts/battle_anims.asm](/macros/scripts/battle_anims.asm) and [data/moves/move_anims.asm:BattleAnimations](/data/moves/move_anims.asm).
+Defined in [macros/scripts/battle_anims.asm](/macros/scripts/battle_anims.asm) and [data/moves/animations.asm:BattleAnimations](/data/moves/animations.asm).
 
 
 ## `$00`−`$EF`: `anim_wait` *length*

docs/bugs_and_glitches.md

@@ -186,7 +186,7 @@ BattleCommand_BellyDrum: ; 37c1a
 
 This bug affects Acid, Iron Tail, and Rock Smash.
 
-This is a bug with `DefenseDownHit` in [data/moves/move_effects.asm](/data/moves/move_effects.asm):
+This is a bug with `DefenseDownHit` in [data/moves/effects.asm](/data/moves/effects.asm):
 
 ```asm
 DefenseDownHit:
@@ -661,7 +661,7 @@ FastBallMultiplier:
 
 ## Dragon Scale, not Dragon Fang, boosts Dragon-type moves
 
-This is a bug with `ItemAttributes` in [items/item_attributes.asm](/items/item_attributes.asm):
+This is a bug with `ItemAttributes` in [items/attributes.asm](/items/attributes.asm):
 
 ```asm
 ; DRAGON FANG

docs/move_effect_commands.md

@@ -1,6 +1,6 @@
-# Effect Commands
+# Move Effect Commands
 
-Defined in [macros/scripts/effect_commands.asm](/macros/scripts/effect_commands.asm) and [data/moves/effect_command_pointers.asm:BattleCommandPointers](/data/moves/effect_command_pointers.asm).
+Defined in [macros/scripts/battle_commands.asm](/macros/scripts/battle_commands.asm) and [data/battle_command_pointers.asm:BattleCommandPointers](/data/battle_command_pointers.asm).
 
 
 ## `$01`: `checkturn`

engine/battle/read_trainer_dvs.asm

@@ -0,0 +1,20 @@
+GetTrainerDVs: ; 270c4
+; Return the DVs of OtherTrainerClass in bc
+
+	push hl
+	ld a, [OtherTrainerClass]
+	dec a
+	ld c, a
+	ld b, 0
+
+	ld hl, TrainerClassDVs
+	add hl, bc
+	add hl, bc
+
+	ld a, [hli]
+	ld b, a
+	ld c, [hl]
+
+	pop hl
+	ret
+; 270d6

engine/battle/read_trainer_party.asm

@@ -1,4 +1,3 @@
-
 ReadTrainerParty: ; 39771
 	ld a, [InBattleTowerBattle]
 	bit 0, a

engine/color.asm

@@ -1218,9 +1218,9 @@ INCLUDE "data/palettes/hp_bar.pal"
 ExpBarPalette:
 INCLUDE "data/palettes/exp_bar.pal"
 
-INCLUDE "data/palettes/pokemon_palettes.asm"
+INCLUDE "data/pokemon/palettes.asm"
 
-INCLUDE "data/palettes/trainer_palettes.asm"
+INCLUDE "data/trainers/palettes.asm"
 
 LoadMapPals:
 	farcall LoadSpecialMapPalette

engine/map_setup.asm

@@ -14,7 +14,7 @@ RunMapSetupScript:: ; 15363
 	ret
 ; 15377
 
-INCLUDE "data/maps/map_setup_scripts.asm"
+INCLUDE "data/maps/setup_scripts.asm"
 
 ReadMapSetupScript: ; 1541d
 .loop

gfx/load_pics.asm

@@ -103,13 +103,13 @@ _GetFrontpic: ; 510a5
 	ret
 
 GetFrontpicPointer: ; 510d7
-GLOBAL PicPointers, UnownPicPointers
+GLOBAL PokemonPicPointers, UnownPicPointers
 
 	ld a, [CurPartySpecies]
 	cp UNOWN
 	jr z, .unown
 	ld a, [CurPartySpecies]
-	ld d, BANK(PicPointers)
+	ld d, BANK(PokemonPicPointers)
 	jr .ok
 
 .unown
@@ -117,7 +117,7 @@ GLOBAL PicPointers, UnownPicPointers
 	ld d, BANK(UnownPicPointers)
 
 .ok
-	ld hl, PicPointers ; UnownPicPointers
+	ld hl, PokemonPicPointers ; UnownPicPointers
 	dec a
 	ld bc, 6
 	call AddNTimes
@@ -212,10 +212,10 @@ GetMonBackpic: ; 5116c
 
 	; These are assumed to be at the same
 	; address in their respective banks.
-	GLOBAL PicPointers,  UnownPicPointers
+	GLOBAL PokemonPicPointers,  UnownPicPointers
-	ld hl, PicPointers ; UnownPicPointers
+	ld hl, PokemonPicPointers ; UnownPicPointers
 	ld a, b
-	ld d, BANK(PicPointers)
+	ld d, BANK(PokemonPicPointers)
 	cp UNOWN
 	jr nz, .ok
 	ld a, c
@@ -295,16 +295,16 @@ GLOBAL PICS_FIX
 Function511ec: ; 511ec
 	ld a, c
 	push de
-	ld hl, PicPointers
+	ld hl, PokemonPicPointers
 	dec a
 	ld bc, 6
 	call AddNTimes
-	ld a, BANK(PicPointers)
+	ld a, BANK(PokemonPicPointers)
 	call GetFarByte
 	call FixPicBank
 	push af
 	inc hl
-	ld a, BANK(PicPointers)
+	ld a, BANK(PokemonPicPointers)
 	call GetFarHalfword
 	pop af
 	pop de

gfx/pics.asm

@@ -1,8 +1,8 @@
 INCLUDE "includes.asm"
 
 
-; PicPointers and UnownPicPointers are assumed to start at the same address,
+; PokemonPicPointers and UnownPicPointers are assumed to start at the same
-; but in different banks. This is enforced in pokecrystal.link.
+; address, but in different banks. This is enforced in pokecrystal.link.
 
 SECTION "Pic Pointers", ROMX
 

macros.asm

@@ -14,7 +14,7 @@ INCLUDE "macros/scripts/maps.asm"
 INCLUDE "macros/scripts/events.asm"
 INCLUDE "macros/scripts/text.asm"
 INCLUDE "macros/scripts/movement.asm"
-INCLUDE "macros/scripts/effect_commands.asm"
+INCLUDE "macros/scripts/battle_commands.asm"
 INCLUDE "macros/scripts/battle_anims.asm"
 INCLUDE "macros/scripts/trade_anims.asm"
 INCLUDE "macros/scripts/gfx_anims.asm"

macros/scripts/battle_commands.asm

@@ -3,7 +3,7 @@ command: macro
 \1 equs "db \1_command"
 endm
 
-; BattleCommandPointers indexes (see data/moves/effect_command_pointers.asm)
+; BattleCommandPointers indexes (see data/battle_command_pointers.asm)
 	enum_start 1
 	command checkturn               ; 01
 	command checkobedience          ; 02

main.asm

@@ -11,7 +11,7 @@ INCLUDE "engine/init_map.asm"
 INCLUDE "engine/learn.asm"
 INCLUDE "engine/routines/checknickerrors.asm"
 INCLUDE "engine/math.asm"
-INCLUDE "data/items/item_attributes.asm"
+INCLUDE "data/items/attributes.asm"
 INCLUDE "engine/npc_movement.asm"
 INCLUDE "engine/events/happiness_egg.asm"
 INCLUDE "engine/events/special.asm"
@@ -117,11 +117,12 @@ INCLUDE "engine/trainer_card.asm"
 INCLUDE "engine/events/prof_oaks_pc.asm"
 INCLUDE "engine/decorations.asm"
 INCLUDE "engine/routines/leveluphappinessmod.asm"
-INCLUDE "data/trainers/trainer_dvs.asm"
+INCLUDE "engine/battle/read_trainer_dvs.asm"
+INCLUDE "data/trainers/dvs.asm"
 INCLUDE "engine/battle/returntobattle_useball.asm"
 INCLUDE "engine/battle/consumehelditem.asm"
-INCLUDE "data/moves/move_effects_pointers.asm"
+INCLUDE "data/moves/effects_pointers.asm"
-INCLUDE "data/moves/move_effects.asm"
+INCLUDE "data/moves/effects.asm"
 INCLUDE "engine/events/kurt_selectquantity_interpretjoypad.asm"
 
 
@@ -141,12 +142,12 @@ INCBIN "gfx/battle/dude.2bpp.lz"
 SECTION "bankB", ROMX
 
 INCLUDE "engine/battle/trainer_huds.asm"
-INCLUDE "data/trainers/trainer_class_names.asm"
+INCLUDE "data/trainers/class_names.asm"
 INCLUDE "engine/battle/ai/redundant.asm"
 INCLUDE "engine/events/move_deleter.asm"
 INCLUDE "engine/mystery_gift_2.asm"
 INCLUDE "engine/tmhm2.asm"
-INCLUDE "data/moves/move_descriptions.asm"
+INCLUDE "data/moves/descriptions.asm"
 INCLUDE "engine/events/pokerus/pokerus.asm"
 INCLUDE "engine/battle/start_battle.asm"
 INCLUDE "engine/routines/placegraphic.asm"
@@ -162,7 +163,7 @@ SECTION "Enemy Trainers", ROMX
 INCLUDE "engine/battle/ai/items.asm"
 INCLUDE "engine/battle/ai/scoring.asm"
 INCLUDE "engine/battle/read_trainer_attributes.asm"
-INCLUDE "data/trainers/trainer_attributes.asm"
+INCLUDE "data/trainers/attributes.asm"
 INCLUDE "engine/battle/read_trainer_party.asm"
 INCLUDE "data/trainers/party_pointers.asm"
 INCLUDE "data/trainers/parties.asm"
@@ -171,7 +172,7 @@ INCLUDE "data/trainers/parties.asm"
 SECTION "Battle Core", ROMX
 
 INCLUDE "engine/battle/core.asm"
-INCLUDE "data/moves/effect_command_pointers.asm"
+INCLUDE "data/battle_command_pointers.asm"
 
 
 SECTION "bank10", ROMX
@@ -220,7 +221,7 @@ INCLUDE "data/collision_permissions.asm"
 INCLUDE "engine/routines/emptyallsrambanks.asm"
 INCLUDE "engine/routines/savemenu_copytilemapatonce.asm"
 INCLUDE "engine/routines/checksave.asm"
-INCLUDE "data/maps/map_scenes.asm"
+INCLUDE "data/maps/scenes.asm"
 INCLUDE "engine/routines/loadmappart.asm"
 INCLUDE "engine/routines/phonering_copytilemapatonce.asm"
 
@@ -270,7 +271,7 @@ INCLUDE "engine/routines/switchpartymons.asm"
 INCLUDE "gfx/load_pics.asm"
 INCLUDE "engine/move_mon_wo_mail.asm"
 INCLUDE "data/pokemon/base_stats.asm"
-INCLUDE "data/pokemon/pokemon_names.asm"
+INCLUDE "data/pokemon/names.asm"
 
 Unknown_53d84: ; unreferenced
 	db $1a, $15
@@ -390,7 +391,7 @@ INCLUDE "engine/events/trainer_scripts.asm"
 SECTION "bank32", ROMX
 
 INCLUDE "engine/battle_anims/bg_effects.asm"
-INCLUDE "data/moves/move_anims.asm"
+INCLUDE "data/moves/animations.asm"
 INCLUDE "engine/events/poisonstep_pals.asm"
 
 TheEndGFX:: ; cbd2e
@@ -593,9 +594,9 @@ INCLUDE "text/phone/trainers1.asm"
 
 SECTION "Miscellaneous Text", ROMX
 
-INCLUDE "data/items/item_names.asm"
+INCLUDE "data/items/names.asm"
-INCLUDE "data/items/item_descriptions.asm"
+INCLUDE "data/items/descriptions.asm"
-INCLUDE "data/moves/move_names.asm"
+INCLUDE "data/moves/names.asm"
 INCLUDE "engine/landmarks.asm"
 
 

tilesets/roofs.asm

@@ -17,4 +17,4 @@ LoadMapGroupRoof:: ; 1c000
 ; 1c021
 
 
-INCLUDE "data/maps/mapgroup_roofs.asm"
+INCLUDE "data/maps/roofs.asm"