pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-04-09 05:44:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #776 from Rangi42/unreferenced

Browse Source 
Comment, remove, or revise many unreferenced labels
This commit is contained in:
Rangi
2020-10-30 12:26:03 -04:00
committed by GitHub
parent a2b6befd7d 1092983bde
commit 7a42f1790a
256 changed files with 2455 additions and 2321 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
INSTALL.md
View File

@ -9,6 +9,12 @@ If you run into trouble, ask for help on IRC or Discord (see [README.md](README.
Download and install [**Windows Subsystem for Linux**](https://docs.microsoft.com/en-us/windows/wsl/install-win10). Then open the **WSL terminal**. Download and install [**Windows Subsystem for Linux**](https://docs.microsoft.com/en-us/windows/wsl/install-win10). Then open the **WSL terminal**.
Update WSL's software before continuing. If you chose Debian, Ubuntu, or another distribution that uses `apt-get`, then enter this command:
```bash
apt-get update && apt-get upgrade
```
WSL has its own file system that's not accessible from Windows, but Windows files *are* accessible from WSL. So you're going to want to install pokecrystal within Windows. You'll have to change the **current working directory** every time you open WSL. WSL has its own file system that's not accessible from Windows, but Windows files *are* accessible from WSL. So you're going to want to install pokecrystal within Windows. You'll have to change the **current working directory** every time you open WSL.
For example, if you want to store pokecrystal in **C:\Users\\*\<user>*\Desktop**, enter this command: For example, if you want to store pokecrystal in **C:\Users\\*\<user>*\Desktop**, enter this command:
@ -19,9 +25,9 @@ cd /mnt/c/Users/<user>/Desktop
(The Windows `C:\` drive is called `/mnt/c/` in WSL. Replace *\<user>* in the example path with your username.) (The Windows `C:\` drive is called `/mnt/c/` in WSL. Replace *\<user>* in the example path with your username.)
Then follow [the instructions for **Linux**](#linux). If this works, then follow [the instructions for **Linux**](#linux) below for whatever distribution you installed for WSL.
If this doesn't work, try following [the regular Windows instructions](#windows) below. Otherwise, continue reading below for [the older Windows instructions](#windows).
## Windows ## Windows
@ -36,9 +42,9 @@ Run setup and leave the default settings. At the "**Select Packages**" step, cho
Double click on the text that says "**Skip**" next to each package to select the most recent version to install. Double click on the text that says "**Skip**" next to each package to select the most recent version to install.
Then download [**rgbds**](https://github.com/gbdev/rgbds/releases/): the latest **win64.zip** or **win32.zip** release. Extract it and put all the `exe` and `dll` files individually in **C:\cygwin64\usr\local\bin**. Then follow the [**rgbds** instructions](https://rgbds.gbdev.io/install/windows) for Windows with Cygwin to install **rgbds 0.4.1**.
**Note: If you already have an older rgbds, you will need to update to 0.4.1.** Ignore this if you have never installed rgbds before. If a version newer than 0.4.1 does not work, try downloading 0.4.1. **Note:** If you already have an older rgbds, you will need to update to 0.4.1. Ignore this if you have never installed rgbds before. If a version newer than 0.4.1 does not work, try downloading 0.4.1.
Now open the **Cygwin terminal** and enter the following commands. Now open the **Cygwin terminal** and enter the following commands.
@ -55,17 +61,13 @@ cd /cygdrive/c/Users/<user>/Desktop
Now you're ready to [build **pokecrystal**](#build-pokecrystal). Now you're ready to [build **pokecrystal**](#build-pokecrystal).
## Mac OS X ## macOS
Install [**Homebrew**](https://brew.sh/). Follow the official instructions. Install [**Homebrew**](https://brew.sh/). Follow the official instructions.
Open **Terminal** and enter the following commands. Open **Terminal** and prepare to enter commands.
To install **rgbds**: Then follow the [**rgbds** instructions](https://rgbds.gbdev.io/install/macos) for macOS to install **rgbds 0.4.1**.
```bash
brew install rgbds
```
Now you're ready to [build **pokecrystal**](#build-pokecrystal). Now you're ready to [build **pokecrystal**](#build-pokecrystal).
@ -82,13 +84,7 @@ To install the software required for **pokecrystal**:
sudo apt-get install make gcc git sudo apt-get install make gcc git
``` ```
To install **rgbds**: Then follow the [**rgbds** instructions](https://rgbds.gbdev.io/install/source) to build **rgbds 0.4.1** from source.
```bash
sudo apt-get install pkg-config flex bison libpng-dev
git clone -b v0.4.1 --depth=1 https://github.com/gbdev/rgbds
sudo make -C rgbds install
```
### OpenSUSE ### OpenSUSE
@ -98,13 +94,7 @@ To install the software required for **pokecrystal**:
sudo zypper install make gcc git sudo zypper install make gcc git
``` ```
To install **rgbds**: Then follow the [**rgbds** instructions](https://rgbds.gbdev.io/install/source) to build **rgbds 0.4.1** from source.
```bash
sudo zypper install pkg-config flex bison libpng16-devel
git clone -b v0.4.1 --depth=1 https://github.com/gbdev/rgbds
sudo make -C rgbds install
```
### Arch Linux ### Arch Linux
@ -114,13 +104,9 @@ To install the software required for **pokecrystal**:
sudo pacman -S make gcc git rgbds sudo pacman -S make gcc git rgbds
``` ```
If you want to compile and install **rgbds** manually instead of using the Arch package: Then follow the [**rgbds** instructions](https://rgbds.gbdev.io/install/arch) for Arch Linux to install **rgbds 0.4.1**.
```bash If you want to compile and install **rgbds** yourself instead, then follow the [**rgbds** instructions](https://rgbds.gbdev.io/install/source) to build **rgbds 0.4.1** from source.
sudo pacman -S pkg-config flex bison libpng
git clone -b v0.4.1 --depth=1 https://github.com/gbdev/rgbds
sudo make -C rgbds install
```
### Termux ### Termux
@ -136,6 +122,8 @@ To install **rgbds**:
sudo apt install rgbds sudo apt install rgbds
``` ```
If you want to compile and install **rgbds** yourself instead, then follow the [**rgbds** instructions](https://rgbds.gbdev.io/install/source) to build **rgbds 0.4.1** from source.
### Other distros ### Other distros
If your distro is not listed here, try to find the required software in its repositories: If your distro is not listed here, try to find the required software in its repositories:
@ -145,19 +133,7 @@ If your distro is not listed here, try to find the required software in its repo
- `git` - `git`
- `rgbds` - `rgbds`
If `rgbds` is not available, you'll also need these: If `rgbds` is not available, you'll need to follow the [**rgbds** instructions](https://rgbds.gbdev.io/install/source) to build **rgbds 0.4.1** from source.
- `pkg-config`
- `flex`
- `bison`
- `libpng` (and the development headers)
To install **rgbds**:
```bash
git clone -b v0.4.1 --depth=1 https://github.com/gbdev/rgbds
sudo make -C rgbds install
```
Now you're ready to [build **pokecrystal**](#build-pokecrystal). Now you're ready to [build **pokecrystal**](#build-pokecrystal).

7
STYLE.md
View File

@ -69,6 +69,7 @@ PascalCase: ; label
PascalCase:: ; global label PascalCase:: ; global label
.snake_case ; local jump .snake_case ; local jump
.PascalCase: ; an atomic chunk of code or data that's local .PascalCase: ; an atomic chunk of code or data that's local
; don't define unused labels when a comment would do
; Labels are prefixed with lower case letters depending on location ; Labels are prefixed with lower case letters depending on location
wPascalCase: ; wram wPascalCase: ; wram
@ -151,9 +152,7 @@ endr
; do ; do
db \1, \2, \3, \4, \5 db \1, \2, \3, \4, \5
rept 5 shift 5
shift
endr
db \1, \2, \3, \4, \5 db \1, \2, \3, \4, \5
ENDM ENDM
@ -161,7 +160,7 @@ ENDM
UPPER_CASE_IS_OK_SOMETIMES: MACRO UPPER_CASE_IS_OK_SOMETIMES: MACRO
; but i can't think of any examples ; but I can't think of any examples besides ACRONYMS
ENDM ENDM

8
audio/cries.asm
View File

@ -464,7 +464,7 @@ Cry_Sentret_Ch6:
square_note 8, 15, 1, 1824 square_note 8, 15, 1, 1824
sound_ret sound_ret
Cry_Sentret_Ch8: Cry_Sentret_Ch8: ; unreferenced
noise_note 8, 3, -3, 0 noise_note 8, 3, -3, 0
noise_note 8, 9, 2, 0 noise_note 8, 9, 2, 0
sound_ret sound_ret
@ -1082,7 +1082,7 @@ Cry_Weepinbell:
channel 6, Cry_Weepinbell_Ch6 channel 6, Cry_Weepinbell_Ch6
channel 8, Cry_Weepinbell_Ch8 channel 8, Cry_Weepinbell_Ch8
Cry_Unused_Ch5: Cry_Unused_Ch5: ; unreferenced
duty_cycle_pattern 3, 3, 0, 0 duty_cycle_pattern 3, 3, 0, 0
square_note 15, 14, 0, 1920 square_note 15, 14, 0, 1920
square_note 15, 15, 0, 1924 square_note 15, 15, 0, 1924
@ -1092,7 +1092,7 @@ Cry_Unused_Ch5:
square_note 8, 7, 1, 1924 square_note 8, 7, 1, 1924
sound_ret sound_ret
Cry_Unused_Ch6: Cry_Unused_Ch6: ; unreferenced
duty_cycle_pattern 0, 0, 1, 1 duty_cycle_pattern 0, 0, 1, 1
square_note 15, 10, 0, 1857 square_note 15, 10, 0, 1857
square_note 15, 11, 0, 1859 square_note 15, 11, 0, 1859
@ -1102,7 +1102,7 @@ Cry_Unused_Ch6:
square_note 8, 3, 1, 1862 square_note 8, 3, 1, 1862
sound_ret sound_ret
Cry_Unused_Ch8: Cry_Unused_Ch8: ; unreferenced
noise_note 2, 15, 2, 76 noise_note 2, 15, 2, 76
noise_note 6, 14, 0, 58 noise_note 6, 14, 0, 58
noise_note 15, 13, 0, 58 noise_note 15, 13, 0, 58

15
audio/engine.asm
View File

@ -38,15 +38,16 @@ _InitSound::
dec e dec e
jr nz, .clearsound jr nz, .clearsound
ld hl, wChannels ; start of channel data ld hl, wAudio
ld de, wChannelsEnd - wChannels ; length of area to clear (entire sound wram area) ld de, wAudioEnd - wAudio
.clearchannels .clearaudio
xor a xor a
ld [hli], a ld [hli], a
dec de dec de
ld a, e ld a, e
or d or d
jr nz, .clearchannels jr nz, .clearaudio
ld a, MAX_VOLUME ld a, MAX_VOLUME
ld [wVolume], a ld [wVolume], a
call MusicOn call MusicOn
@ -1614,9 +1615,9 @@ Music_JumpIf:
ret ret
MusicEE: MusicEE:
; unused
; conditional jump ; conditional jump
; checks a byte in ram corresponding to the current channel ; checks a byte in ram corresponding to the current channel
; doesn't seem to be set by any commands
; params: 2 ; params: 2
; ll hh ; pointer ; ll hh ; pointer
@ -1666,15 +1667,15 @@ MusicEE:
ret ret
MusicF9: MusicF9:
; unused
; sets some flag ; sets some flag
; seems to be unused
; params: 0 ; params: 0
ld a, TRUE ld a, TRUE
ld [wUnusedMusicF9Flag], a ld [wUnusedMusicF9Flag], a
ret ret
MusicE2: MusicE2:
; seems to have been dummied out ; unused
; params: 1 ; params: 1
call GetMusicByte call GetMusicByte
ld hl, CHANNEL_FIELD2C ld hl, CHANNEL_FIELD2C

2
audio/music/magnettrain.asm
View File

@ -246,7 +246,7 @@ Music_MagnetTrain_Ch4:
drum_note 12, 16 drum_note 12, 16
sound_ret sound_ret
.sub1: ; unused .sub1: ; unreferenced
drum_note 9, 1 drum_note 9, 1
drum_note 8, 1 drum_note 8, 1
drum_note 8, 1 drum_note 8, 1

10
audio/sfx.asm
View File

@ -21,7 +21,8 @@ Sfx_Menu:
Sfx_ReadText: Sfx_ReadText:
Sfx_ReadText2: Sfx_ReadText2:
channel_count 1 channel_count 1
channel 5, Sfx_ReadText2_Ch5 channel 5, Sfx_ReadText_Ch5
assert Sfx_ReadText_Ch5 == Sfx_ReadText2_Ch5
Sfx_Poison: Sfx_Poison:
channel_count 1 channel_count 1
@ -467,6 +468,7 @@ Sfx_Unknown5F:
channel 6, Sfx_Unknown5F_Ch6 channel 6, Sfx_Unknown5F_Ch6
Sfx_Sandstorm: Sfx_Sandstorm:
channel 8, Sfx_Sandstorm_Ch8 channel 8, Sfx_Sandstorm_Ch8
assert Sfx_Sandstorm_Ch8 == Sfx_Unknown5F_Ch8
Sfx_HangUp: Sfx_HangUp:
channel_count 1 channel_count 1
@ -490,6 +492,10 @@ Sfx_DexFanfare5079:
channel 6, Sfx_LevelUp_Ch6 channel 6, Sfx_LevelUp_Ch6
channel 7, Sfx_LevelUp_Ch7 channel 7, Sfx_LevelUp_Ch7
channel 8, Sfx_LevelUp_Ch8 channel 8, Sfx_LevelUp_Ch8
assert Sfx_LevelUp_Ch5 == Sfx_DexFanfare5079_Ch5
assert Sfx_LevelUp_Ch6 == Sfx_DexFanfare5079_Ch6
assert Sfx_LevelUp_Ch7 == Sfx_DexFanfare5079_Ch7
assert Sfx_LevelUp_Ch8 == Sfx_DexFanfare5079_Ch8
Sfx_LevelUp_Ch5: Sfx_LevelUp_Ch5:
Sfx_DexFanfare5079_Ch5: Sfx_DexFanfare5079_Ch5:
@ -942,7 +948,7 @@ Sfx_Fanfare2:
channel 6, Sfx_Fanfare2_Ch6 channel 6, Sfx_Fanfare2_Ch6
channel 8, Sfx_Fanfare2_Ch8 channel 8, Sfx_Fanfare2_Ch8
Sfx_Unused: Sfx_Unused: ; unreferenced
channel_count 4 channel_count 4
channel 5, Sfx_Unused_Ch5 channel 5, Sfx_Unused_Ch5
channel 6, Sfx_Unused_Ch6 channel 6, Sfx_Unused_Ch6

4
audio/sfx_crystal.asm
View File

@ -184,7 +184,7 @@ Sfx_Tingle_Ch5:
duty_cycle 1 duty_cycle 1
transpose 0, 11 transpose 0, 11
note_type 1, 11, 1 note_type 1, 11, 1
Sfx_Tingle_branch_17996c: .loop1:
octave 5 octave 5
note C_, 3 note C_, 3
octave 6 octave 6
@ -192,7 +192,7 @@ Sfx_Tingle_branch_17996c:
octave 5 octave 5
note C_, 3 note C_, 3
rest 2 rest 2
sound_loop 2, Sfx_Tingle_branch_17996c sound_loop 2, .loop1
note C_, 2 note C_, 2
volume_envelope 10, 1 volume_envelope 10, 1
note G_, 13 note G_, 13

4
constants/collision_constants.asm
View File

@ -1,11 +1,11 @@
; collision permissions (see data/collision_permissions.asm) ; collision permissions (see data/collision/collision_permissions.asm)
LAND_TILE EQU $00 LAND_TILE EQU $00
WATER_TILE EQU $01 WATER_TILE EQU $01
WALL_TILE EQU $0f WALL_TILE EQU $0f
TALK EQU $10 TALK EQU $10
; collision data types (see data/tilesets/*_collision.asm) ; collision data types (see data/tilesets/*_collision.asm)
; TileCollisionTable indexes (see data/collision_permissions.asm) ; TileCollisionTable indexes (see data/collision/collision_permissions.asm)
COLL_FLOOR EQU $00 COLL_FLOOR EQU $00
COLL_01 EQU $01 ; garbage COLL_01 EQU $01 ; garbage
COLL_03 EQU $03 ; garbage COLL_03 EQU $03 ; garbage

4
constants/engine_flags.asm
View File

@ -15,7 +15,7 @@
const ENGINE_MOM_SAVING_MONEY const ENGINE_MOM_SAVING_MONEY
const ENGINE_MOM_ACTIVE const ENGINE_MOM_ACTIVE
; wUnusedTwoDayTimerOn ; wUnusedTwoDayTimerOn
const ENGINE_0A const ENGINE_UNUSED_TWO_DAY_TIMER_ON
; wStatusFlags ; wStatusFlags
const ENGINE_POKEDEX const ENGINE_POKEDEX
const ENGINE_UNOWN_DEX const ENGINE_UNOWN_DEX
@ -115,7 +115,7 @@
; wSwarmFlags ; wSwarmFlags
const ENGINE_BUENAS_PASSWORD_2 const ENGINE_BUENAS_PASSWORD_2
const ENGINE_GOLDENROD_DEPT_STORE_SALE_IS_ON const ENGINE_GOLDENROD_DEPT_STORE_SALE_IS_ON
; wGameTimerPause ; wGameTimerPaused
const ENGINE_62 const ENGINE_62
; wPlayerGender ; wPlayerGender
const ENGINE_PLAYER_IS_FEMALE const ENGINE_PLAYER_IS_FEMALE

60
constants/event_flags.asm
View File

@ -136,9 +136,9 @@
const EVENT_TIN_TOWER_5F_HIDDEN_FULL_RESTORE const EVENT_TIN_TOWER_5F_HIDDEN_FULL_RESTORE
const EVENT_TIN_TOWER_5F_HIDDEN_CARBOS const EVENT_TIN_TOWER_5F_HIDDEN_CARBOS
const EVENT_BURNED_TOWER_1F_HIDDEN_ETHER const EVENT_BURNED_TOWER_1F_HIDDEN_ETHER
const_skip ; unused const_skip ; unused in Crystal
const_skip ; unused const_skip ; unused in Crystal
const_skip ; unused const_skip ; unused in Crystal
const EVENT_NATIONAL_PARK_HIDDEN_FULL_HEAL const EVENT_NATIONAL_PARK_HIDDEN_FULL_HEAL
const EVENT_OLIVINE_LIGHTHOUSE_5F_HIDDEN_HYPER_POTION const EVENT_OLIVINE_LIGHTHOUSE_5F_HIDDEN_HYPER_POTION
const EVENT_TEAM_ROCKET_BASE_B1F_HIDDEN_REVIVE const EVENT_TEAM_ROCKET_BASE_B1F_HIDDEN_REVIVE
@ -281,11 +281,11 @@
const EVENT_GAVE_KURT_PNK_APRICORN const EVENT_GAVE_KURT_PNK_APRICORN
; Phone events ; Phone events
const EVENT_JACK_ASKED_FOR_PHONE_NUMBER const EVENT_JACK_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_BEVERLY_ASKED_FOR_PHONE_NUMBER const EVENT_BEVERLY_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_HUEY_ASKED_FOR_PHONE_NUMBER const EVENT_HUEY_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_GOT_PROTEIN_FROM_HUEY const EVENT_GOT_PROTEIN_FROM_HUEY
const EVENT_GOT_HP_UP_FROM_JOEY const EVENT_GOT_HP_UP_FROM_JOEY
const EVENT_GOT_CARBOS_FROM_VANCE const EVENT_GOT_CARBOS_FROM_VANCE
@ -293,55 +293,55 @@
const EVENT_GOT_CALCIUM_FROM_ERIN const EVENT_GOT_CALCIUM_FROM_ERIN
const EVENT_KENJI_ON_BREAK const EVENT_KENJI_ON_BREAK
const EVENT_GAVEN_ASKED_FOR_PHONE_NUMBER const EVENT_GAVEN_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_BETH_ASKED_FOR_PHONE_NUMBER const EVENT_BETH_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_JOSE_ASKED_FOR_PHONE_NUMBER const EVENT_JOSE_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_REENA_ASKED_FOR_PHONE_NUMBER const EVENT_REENA_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_JOEY_ASKED_FOR_PHONE_NUMBER const EVENT_JOEY_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_WADE_ASKED_FOR_PHONE_NUMBER const EVENT_WADE_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_RALPH_ASKED_FOR_PHONE_NUMBER const EVENT_RALPH_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_LIZ_ASKED_FOR_PHONE_NUMBER const EVENT_LIZ_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_ANTHONY_ASKED_FOR_PHONE_NUMBER const EVENT_ANTHONY_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_TODD_ASKED_FOR_PHONE_NUMBER const EVENT_TODD_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_GINA_ASKED_FOR_PHONE_NUMBER const EVENT_GINA_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_IRWIN_ASKED_FOR_PHONE_NUMBER const EVENT_IRWIN_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_ARNIE_ASKED_FOR_PHONE_NUMBER const EVENT_ARNIE_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_ALAN_ASKED_FOR_PHONE_NUMBER const EVENT_ALAN_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const_skip ; unused const_skip ; unused
const_skip ; unused const_skip ; unused
const EVENT_DANA_ASKED_FOR_PHONE_NUMBER const EVENT_DANA_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_CHAD_ASKED_FOR_PHONE_NUMBER const EVENT_CHAD_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_DEREK_ASKED_FOR_PHONE_NUMBER const EVENT_DEREK_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_TULLY_ASKED_FOR_PHONE_NUMBER const EVENT_TULLY_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_BRENT_ASKED_FOR_PHONE_NUMBER const EVENT_BRENT_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused
const EVENT_TIFFANY_ASKED_FOR_PHONE_NUMBER const EVENT_TIFFANY_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_VANCE_ASKED_FOR_PHONE_NUMBER const EVENT_VANCE_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_WILTON_ASKED_FOR_PHONE_NUMBER const EVENT_WILTON_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_KENJI_ASKED_FOR_PHONE_NUMBER const EVENT_KENJI_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_PARRY_ASKED_FOR_PHONE_NUMBER const EVENT_PARRY_ASKED_FOR_PHONE_NUMBER
const_skip ; unused const_skip ; unused in Crystal
const EVENT_ERIN_ASKED_FOR_PHONE_NUMBER const EVENT_ERIN_ASKED_FOR_PHONE_NUMBER
const EVENT_BUENA_OFFERED_HER_PHONE_NUMBER_NO_BLUE_CARD const EVENT_BUENA_OFFERED_HER_PHONE_NUMBER_NO_BLUE_CARD
const_skip ; unused const_skip ; unused
@ -1229,7 +1229,7 @@
const EVENT_COPYCAT_2 const EVENT_COPYCAT_2
const EVENT_GOLDENROD_SALE_OFF const EVENT_GOLDENROD_SALE_OFF
const EVENT_GOLDENROD_SALE_ON const EVENT_GOLDENROD_SALE_ON
const_skip ; unused const_skip ; unused in Crystal
const EVENT_ILEX_FOREST_APPRENTICE const EVENT_ILEX_FOREST_APPRENTICE
const EVENT_ILEX_FOREST_CHARCOAL_MASTER const EVENT_ILEX_FOREST_CHARCOAL_MASTER
const EVENT_CHARCOAL_KILN_FARFETCH_D const EVENT_CHARCOAL_KILN_FARFETCH_D

1
constants/gfx_constants.asm
View File

@ -21,6 +21,7 @@ SCREEN_META_WIDTH EQU 6 ; metatiles
SCREEN_META_HEIGHT EQU 5 ; metatiles SCREEN_META_HEIGHT EQU 5 ; metatiles
SURROUNDING_WIDTH EQU SCREEN_META_WIDTH * METATILE_WIDTH ; tiles SURROUNDING_WIDTH EQU SCREEN_META_WIDTH * METATILE_WIDTH ; tiles
SURROUNDING_HEIGHT EQU SCREEN_META_HEIGHT * METATILE_WIDTH ; tiles SURROUNDING_HEIGHT EQU SCREEN_META_HEIGHT * METATILE_WIDTH ; tiles
MAP_CONNECTION_PADDING_WIDTH EQU 3 ; metatiles
HP_BAR_LENGTH EQU 6 ; tiles HP_BAR_LENGTH EQU 6 ; tiles
EXP_BAR_LENGTH EQU 8 ; tiles EXP_BAR_LENGTH EQU 8 ; tiles

11
constants/hardware_constants.asm
View File

@ -71,10 +71,10 @@ rTIMA EQU $ff05 ; Timer counter (R/W)
rTMA EQU $ff06 ; Timer Modulo (R/W) rTMA EQU $ff06 ; Timer Modulo (R/W)
rTAC EQU $ff07 ; Timer Control (R/W) rTAC EQU $ff07 ; Timer Control (R/W)
rTAC_ON EQU 2 rTAC_ON EQU 2
rTAC_4096_HZ EQU 0 rTAC_4096_HZ EQU %00
rTAC_262144_HZ EQU 1 rTAC_262144_HZ EQU %01
rTAC_65536_HZ EQU 2 rTAC_65536_HZ EQU %10
rTAC_16384_HZ EQU 3 rTAC_16384_HZ EQU %11
rIF EQU $ff0f ; Interrupt Flag (R/W) rIF EQU $ff0f ; Interrupt Flag (R/W)
rNR10 EQU $ff10 ; Channel 1 Sweep register (R/W) rNR10 EQU $ff10 ; Channel 1 Sweep register (R/W)
rNR11 EQU $ff11 ; Channel 1 Sound length/Wave pattern duty (R/W) rNR11 EQU $ff11 ; Channel 1 Sound length/Wave pattern duty (R/W)
@ -147,6 +147,9 @@ rHDMA3 EQU $ff53 ; CGB Mode Only - New DMA Destination, High
rHDMA4 EQU $ff54 ; CGB Mode Only - New DMA Destination, Low rHDMA4 EQU $ff54 ; CGB Mode Only - New DMA Destination, Low
rHDMA5 EQU $ff55 ; CGB Mode Only - New DMA Length/Mode/Start rHDMA5 EQU $ff55 ; CGB Mode Only - New DMA Length/Mode/Start
rRP EQU $ff56 ; CGB Mode Only - Infrared Communications Port rRP EQU $ff56 ; CGB Mode Only - Infrared Communications Port
rRP_LED_ON EQU 0
rRP_RECEIVING EQU 1
rRP_ENABLE_READ_MASK EQU %11000000
rBGPI EQU $ff68 ; CGB Mode Only - Background Palette Index rBGPI EQU $ff68 ; CGB Mode Only - Background Palette Index
rBGPI_AUTO_INCREMENT EQU 7 ; increment rBGPI after write to rBGPD rBGPI_AUTO_INCREMENT EQU 7 ; increment rBGPI after write to rBGPD
rBGPD EQU $ff69 ; CGB Mode Only - Background Palette Data rBGPD EQU $ff69 ; CGB Mode Only - Background Palette Data

5
constants/landmark_constants.asm
View File

@ -102,8 +102,9 @@ KANTO_LANDMARK EQU const_value
const LANDMARK_FAST_SHIP ; 5f const LANDMARK_FAST_SHIP ; 5f
; used in CaughtData ; used in CaughtData
LANDMARK_GIFT EQU $7e const_def $7f, -1
LANDMARK_EVENT EQU $7f const LANDMARK_EVENT ; $7f
const LANDMARK_GIFT ; $7e
; Regions ; Regions
const_def const_def

2
constants/map_constants.asm
View File

@ -1,5 +1,5 @@
newgroup: MACRO newgroup: MACRO
const_value = const_value + 1 const_skip
__map_value__ = 1 __map_value__ = 1
ENDM ENDM

2
constants/map_data_constants.asm
View File

@ -66,7 +66,7 @@ NUM_MAP_PALETTES EQU const_value
shift_const NORTH shift_const NORTH
; SpawnPoints indexes (see data/maps/spawn_points.asm) ; SpawnPoints indexes (see data/maps/spawn_points.asm)
const_value = -1 const_def -1
const SPAWN_N_A const SPAWN_N_A
const SPAWN_HOME const SPAWN_HOME
const SPAWN_DEBUG const SPAWN_DEBUG

2
constants/misc_constants.asm
View File

@ -14,6 +14,8 @@ FEMALE EQU 1
; G/S version ID: 0 = Gold, 1 = Silver (used by checkver) ; G/S version ID: 0 = Gold, 1 = Silver (used by checkver)
GS_VERSION EQU 0 GS_VERSION EQU 0
; Pokémon Pikachu 2, a step counter / virtual pet device (used by Mystery Gift)
POKEMON_PIKACHU_2_VERSION EQU 3
; save file corruption check values ; save file corruption check values
SAVE_CHECK_VALUE_1 EQU 99 SAVE_CHECK_VALUE_1 EQU 99

4
constants/pokemon_constants.asm
View File

@ -10,14 +10,14 @@
; - PokemonPalettes (see data/pokemon/palettes.asm) ; - PokemonPalettes (see data/pokemon/palettes.asm)
; - PokedexDataPointerTable (see data/pokemon/dex_entry_pointers.asm) ; - PokedexDataPointerTable (see data/pokemon/dex_entry_pointers.asm)
; - AlphabeticalPokedexOrder (see data/pokemon/dex_order_alpha.asm) ; - AlphabeticalPokedexOrder (see data/pokemon/dex_order_alpha.asm)
; - EZChat_SortedPokemon (see data/pokemon/ezchat_order.asm)
; - NewPokedexOrder (see data/pokemon/dex_order_new.asm) ; - NewPokedexOrder (see data/pokemon/dex_order_new.asm)
; - Pokered_MonIndices (see data/pokemon/gen1_order.asm) ; - Pokered_MonIndices (see data/pokemon/gen1_order.asm)
; - Footprints (see gfx/footprints.asm)
; - AnimationPointers (see gfx/pokemon/anim_pointers.asm) ; - AnimationPointers (see gfx/pokemon/anim_pointers.asm)
; - AnimationIdlePointers (see gfx/pokemon/idle_pointers.asm) ; - AnimationIdlePointers (see gfx/pokemon/idle_pointers.asm)
; - BitmasksPointers (see gfx/pokemon/bitmask_pointers.asm) ; - BitmasksPointers (see gfx/pokemon/bitmask_pointers.asm)
; - FramesPointers (see gfx/pokemon/frame_pointers.asm) ; - FramesPointers (see gfx/pokemon/frame_pointers.asm)
; - Footprints (see gfx/footprints.asm) ; - EZChat_SortedPokemon (see data/pokemon/ezchat_order.asm)
const_def 1 const_def 1
const BULBASAUR ; 01 const BULBASAUR ; 01
const IVYSAUR ; 02 const IVYSAUR ; 02

2
constants/pokemon_data_constants.asm
View File

@ -179,7 +179,7 @@ NUM_TREEMON_SETS EQU const_value
const TREEMON_SCORE_RARE ; 2 const TREEMON_SCORE_RARE ; 2
; ChangeHappiness arguments (see data/happiness_changes.asm) ; ChangeHappiness arguments (see data/happiness_changes.asm)
const_value = 1 const_def 1
const HAPPINESS_GAINLEVEL ; 01 const HAPPINESS_GAINLEVEL ; 01
const HAPPINESS_USEDITEM ; 02 const HAPPINESS_USEDITEM ; 02
const HAPPINESS_USEDXITEM ; 03 const HAPPINESS_USEDXITEM ; 03

6
constants/scgb_constants.asm
View File

@ -35,6 +35,12 @@
SCGB_PARTY_MENU_HP_BARS EQU $fc SCGB_PARTY_MENU_HP_BARS EQU $fc
SCGB_DEFAULT EQU $ff SCGB_DEFAULT EQU $ff
; GetCrystalCGBLayout arguments (see engine/gfx/crystal_layouts.asm)
const_def
const CRYSTAL_CGB_MOBILE_0
const CRYSTAL_CGB_MOBILE_1
const CRYSTAL_CGB_NAME_CARD
; PredefPals indexes (see gfx/sgb/predef.pal) ; PredefPals indexes (see gfx/sgb/predef.pal)
; GetPredefPal arguments (see engine/gfx/color.asm) ; GetPredefPal arguments (see engine/gfx/color.asm)
const_def const_def

5
constants/serial_constants.asm
View File

@ -30,3 +30,8 @@ SERIAL_NO_DATA_BYTE EQU $fe
SERIAL_PATCH_LIST_PART_TERMINATOR EQU $ff SERIAL_PATCH_LIST_PART_TERMINATOR EQU $ff
SERIAL_PREAMBLE_LENGTH EQU 6 SERIAL_PREAMBLE_LENGTH EQU 6
; timeout duration after exchanging a byte
SERIAL_LINK_BYTE_TIMEOUT EQU $5000
MAX_MYSTERY_GIFT_PARTNERS EQU 5

Some files were not shown because too many files have changed in this diff Show More