Note possibly intentional "bugs"

This commit is contained in:
Rangi 2020-08-28 21:38:46 -04:00
parent cab4cd10b0
commit 77d97a04d5

View File

@ -1591,6 +1591,8 @@ Finally, edit [engine/battle/read_trainer_party.asm](https://github.com/pret/pok
## Some trainer NPCs have inconsistent overworld sprites
*Some of these may have been intentional behavior; use your own judgment for whether to fix them.*
Most trainer classes always use the same sprite and color for their overworld NPCs. There are some exceptions:
- [maps/FastShipCabins_SE_SSE_CaptainsCabin.asm](https://github.com/pret/pokecrystal/blob/master/maps/FastShipCabins_SE_SSE_CaptainsCabin.asm): `TrainerPsychicRodney` should use `SPRITE_YOUNGSTER`, not `SPRITE_SUPER_NERD`
@ -1685,6 +1687,8 @@ This is a mistake with the “`…`” tile in [gfx/battle/hp_exp_bar_border.png
## Move selection menu doesn't handle joypad properly
*This may have been intentional behavior; use your own judgment for whether to fix it.*
([Video](https://www.youtube.com/watch?v=vjFUo6Jr4po&t=438))
`hInMenu` isn't defined in the menu that handles selecting moves in a battle. Because of this, your cursor is usually rendered unable to keep scrolling when one of the directional keys is being held. It's up for debate whether this behavior was intentional or not, but this value should be defined when in the move selection menu. A value of 1 will allow it to keep scrolling, though it's usually 0 by default.
@ -1892,6 +1896,8 @@ This bug can allow you to talk to Eusine in Celadon City and encounter Ho-Oh wit
## `CheckOwnMonAnywhere` does not check the Day-Care
*This may have been intentional behavior; use your own judgment for whether to fix it.*
This bug can prevent you from talking to Eusine in Celadon City or encountering Ho-Oh when a caught legendary beast is in the Day-Care.
**Fix:** Edit `CheckOwnMonAnywhere` in [engine/pokemon/search.asm](https://github.com/pret/pokecrystal/blob/master/engine/pokemon/search.asm):