pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-09-08 08:13:02 -07:00
Code Issues Packages Projects Releases Wiki Activity

Label some mobile addresses, and revise some comments

Browse Source
This commit is contained in:
Rangi
2020-06-13 18:48:26 -04:00
parent 0d683ea0c7
commit 75035a71a5
22 changed files with 161 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
engine/battle/check_battle_scene.asm
View File

@@ -19,9 +19,9 @@ CheckBattleScene:
and a
jr nz, .from_wram
ld a, 4 ; MBC30 bank used by JP Crystal; inaccessible by MBC3
ld a, BANK(s4_a60c) ; MBC30 bank used by JP Crystal; inaccessible by MBC3
call GetSRAMBank
ld a, [$a60c] ; address of MBC30 bank
ld a, [s4_a60c]
ld c, a
call CloseSRAM

4
engine/battle/core.asm
View File

@@ -230,9 +230,9 @@ BattleTurn:
Stubbed_Function3c1bf:
ret
ld a, 5 ; MBC30 bank used by JP Crystal; inaccessible by MBC3
ld a, BANK(s5_a89b) ; MBC30 bank used by JP Crystal; inaccessible by MBC3
call GetSRAMBank
ld hl, $a89b ; address of MBC30 bank
ld hl, s5_a89b ; address of MBC30 bank
inc [hl]
jr nz, .finish
dec hl

2
engine/battle/effect_commands.asm
View File

@@ -1543,7 +1543,7 @@ BattleCommand_DamageVariation:
call Multiply
; ...divide by 100%...
ld a, $ff ; 100%
ld a, 100 percent
ldh [hDivisor], a
ld b, $4
call Divide

2
engine/battle/move_effects/rollout.asm
View File

@@ -14,7 +14,7 @@ BattleCommand_CheckCurl:
bit SUBSTATUS_ROLLOUT, a
jr z, .reset
ld b, $4 ; doturn
ld b, doturn_command
jp SkipToBattleCommand
.reset

4
engine/battle_anims/bg_effects.asm
View File

@@ -1510,10 +1510,10 @@ Tackle_BGEffect25_2d_two:
Functionc88a5:
push af
ld a, [wFXAnimID + 1] ; FXAnimID + 1
ld a, [wFXAnimID + 1]
or a
jr nz, .not_rollout
ld a, [wFXAnimID] ; FXAnimID
ld a, [wFXAnimID]
cp ROLLOUT
jr z, .rollout
.not_rollout

6
engine/link/mystery_gift.asm
View File

@@ -1537,12 +1537,12 @@ Function10578c:
ld a, [sCrystalData + 0]
ld [de], a
inc de
ld a, 4 ; MBC30 bank used by JP Crystal; inaccessible by MBC3
ld a, BANK(s4_a603) ; aka BANK(s4_a007) ; MBC30 bank used by JP Crystal; inaccessible by MBC3
call GetSRAMBank
ld hl, $a603 ; address of MBC30 bank
ld hl, s4_a603 ; address of MBC30 bank
ld bc, $8
call CopyBytes
ld hl, $a007 ; address of MBC30 bank
ld hl, s4_a007 ; address of MBC30 bank
ld bc, $c
call CopyBytes
call CloseSRAM

16
engine/menus/save.asm
View File

@@ -422,9 +422,9 @@ SaveData:
ret
Unreferenced_Function14d6c:
ld a, 4 ; MBC30 bank used by JP Crystal; inaccessible by MBC3
ld a, BANK(s4_a60b) ; MBC30 bank used by JP Crystal; inaccessible by MBC3
call GetSRAMBank
ld a, [$a60b] ; address of MBC30 bank
ld a, [s4_a60b] ; address of MBC30 bank
ld b, $0
and a
jr z, .ok
@@ -432,24 +432,24 @@ Unreferenced_Function14d6c:
.ok
ld a, b
ld [$a60b], a ; address of MBC30 bank
ld [s4_a60b], a ; address of MBC30 bank
call CloseSRAM
ret
Unreferenced_Function14d83:
ld a, 4 ; MBC30 bank used by JP Crystal; inaccessible by MBC3
ld a, BANK(s4_a60c) ; aka BANK(s4_a60d) ; MBC30 bank used by JP Crystal; inaccessible by MBC3
call GetSRAMBank
xor a
ld [$a60c], a ; address of MBC30 bank
ld [$a60d], a ; address of MBC30 bank
ld [s4_a60c], a ; address of MBC30 bank
ld [s4_a60d], a ; address of MBC30 bank
call CloseSRAM
ret
Unreferenced_Function14d93:
ld a, 7 ; MBC30 bank used by JP Crystal; inaccessible by MBC3
ld a, BANK(s7_a000) ; MBC30 bank used by JP Crystal; inaccessible by MBC3
call GetSRAMBank
xor a
ld [$a000], a ; address of MBC30 bank
ld [s7_a000], a ; address of MBC30 bank
call CloseSRAM
ret