Cosmetic fixes

constants/misc_constants.asm

@@ -7,9 +7,10 @@ MALE   EQU 0
 FEMALE EQU 1
 
 ; FlagAction arguments (see home/flag.asm)
-RESET_FLAG EQU 0
-SET_FLAG   EQU 1
-CHECK_FLAG EQU 2
+	const_def
+	const RESET_FLAG
+	const SET_FLAG
+	const CHECK_FLAG
 
 ; G/S version ID: 0 = Gold, 1 = Silver (used by checkver)
 GS_VERSION EQU 0

home/flag.asm

@@ -45,12 +45,10 @@ FlagAction::
 	and 7
 
 	; shift de right by three bits (get the index within memory)
+rept 3
 	srl d
 	rr e
-	srl d
-	rr e
-	srl d
-	rr e
+endr
 	add hl, de
 
 	; implement a decoder

macros/scripts/audio.asm

@@ -68,11 +68,11 @@ ENDM
 	enum sound_duty_cmd ; $de
 sound_duty: MACRO
 	db sound_duty_cmd
-	if _NARG == 4
+if _NARG == 4
 	db \1 | (\2 << 2) | (\3 << 4) | (\4 << 6) ; duty sequence
-	else
+else
 	db \1 ; LEGACY: Support for one-byte duty value
-	endc
+endc
 ENDM
 
 	enum togglesfx_cmd ; $df

macros/scripts/battle_anims.asm

@@ -17,6 +17,7 @@ if _NARG <= 4
 	db \3 ; y
 	db \4 ; param
 else
+; LEGACY: Support the tile+offset format
 	db \1 ; object
 	db (\2) * 8 + (\3) ; x_tile, x
 	db (\4) * 8 + (\5) ; y_tile, y