From c5f22b782b533772b80c2411a3ac19264210a436 Mon Sep 17 00:00:00 2001 From: mid-kid Date: Tue, 25 Feb 2020 14:59:06 +0100 Subject: [PATCH 1/2] Fix Mac OSX install instructions --- INSTALL.md | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/INSTALL.md b/INSTALL.md index cc96cf98d..2035da2ff 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -57,19 +57,14 @@ Now you're ready to [build **pokecrystal**](#build-pokecrystal). ## Mac OS X +Install [**Homebrew**](https://brew.sh/). Follow the official instructions. + Open **Terminal** and enter the following commands. -To install the **Xcode Command Line Tools**: - -```bash -xcode-select --install -``` - To install **rgbds**: ```bash -git clone --depth=1 https://github.com/rednex/rgbds -sudo make -C rgbds CFLAGS=-O2 install +brew install rgbds ``` Now you're ready to [build **pokecrystal**](#build-pokecrystal). @@ -91,7 +86,7 @@ To install **rgbds**: ```bash sudo apt-get install pkg-config flex bison libpng-dev -git clone --depth=1 https://github.com/rednex/rgbds +git clone -b v0.3.9 --depth=1 https://github.com/rednex/rgbds sudo make -C rgbds CFLAGS=-O2 install ``` @@ -107,7 +102,7 @@ To install **rgbds**: ```bash sudo zypper install pkg-config flex bison libpng16-devel -git clone --depth=1 https://github.com/rednex/rgbds +git clone -b v0.3.9 --depth=1 https://github.com/rednex/rgbds sudo make -C rgbds CFLAGS=-O2 install ``` @@ -125,7 +120,7 @@ Alternatively, to install **rgbds** manually: ```bash sudo pacman -S pkg-config flex bison libpng -git clone --depth=1 https://github.com/rednex/rgbds +git clone -b v0.3.9 --depth=1 https://github.com/rednex/rgbds sudo make -C rgbds CFLAGS=-O2 install ``` @@ -162,7 +157,7 @@ If `rgbds` is not available, you'll also need these: To install **rgbds**: ```bash -git clone --depth=1 https://github.com/rednex/rgbds +git clone -b v0.3.9 --depth=1 https://github.com/rednex/rgbds sudo make -C rgbds CFLAGS=-O2 install ``` From e7995159310f059727479a350801ef5fc66b90c8 Mon Sep 17 00:00:00 2001 From: mid-kid Date: Tue, 25 Feb 2020 19:38:24 +0100 Subject: [PATCH 2/2] Fix SRAM references in Function140ae --- engine/rtc/rtc.asm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/engine/rtc/rtc.asm b/engine/rtc/rtc.asm index f79c3f297..00098c0e5 100644 --- a/engine/rtc/rtc.asm +++ b/engine/rtc/rtc.asm @@ -136,15 +136,14 @@ Function140ae: .time_overflow farcall ClearDailyTimers farcall Function170923 -; mobile - ld a, 5 ; MBC30 bank used by JP Crystal; inaccessible by MBC3 + ld a, BANK(s5_aa8c) ; and BANK(s5_b2fa) call GetSRAMBank - ld a, [$aa8c] ; address of MBC30 bank + ld a, [s5_aa8c] inc a - ld [$aa8c], a ; address of MBC30 bank - ld a, [$b2fa] ; address of MBC30 bank + ld [s5_aa8c], a + ld a, [s5_b2fa] inc a - ld [$b2fa], a ; address of MBC30 bank + ld [s5_b2fa], a call CloseSRAM ret